* [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain
@ 2023-10-18 20:31 Uwe Kleine-König
2024-01-24 10:01 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2023-10-18 20:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, kernel,
Leonard Göhrs
From: Leonard Göhrs <l.goehrs@pengutronix.de>
This results in a slight improvement in EMI performance due to the lines
no longer being driven by the somewhat noisy VDD_IO supply of the SoM.
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts | 2 +-
arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
index 8a34d15e9005..4cc177031661 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
@@ -148,7 +148,7 @@ adc@0 {
compatible = "ti,lmp92064";
reg = <0>;
- reset-gpios = <&gpioa 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
shunt-resistor-micro-ohms = <15000>;
spi-max-frequency = <5000000>;
vdd-supply = <®_pb_3v3>;
diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
index f09b7c384bd9..188c9cfc7102 100644
--- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
@@ -409,7 +409,7 @@ &sdmmc2 {
&spi2 {
pinctrl-names = "default";
pinctrl-0 = <&spi2_pins_c>;
- cs-gpios = <&gpiof 12 GPIO_ACTIVE_LOW>;
+ cs-gpios = <&gpiof 12 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
status = "okay";
};
base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain
2023-10-18 20:31 [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain Uwe Kleine-König
@ 2024-01-24 10:01 ` Uwe Kleine-König
2024-01-24 10:09 ` Alexandre TORGUE
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2024-01-24 10:01 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue
Cc: kernel, devicetree, Leonard Göhrs, linux-stm32,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2045 bytes --]
Hello,
On Wed, Oct 18, 2023 at 10:31:55PM +0200, Uwe Kleine-König wrote:
> From: Leonard Göhrs <l.goehrs@pengutronix.de>
>
> This results in a slight improvement in EMI performance due to the lines
> no longer being driven by the somewhat noisy VDD_IO supply of the SoM.
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts | 2 +-
> arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> index 8a34d15e9005..4cc177031661 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> @@ -148,7 +148,7 @@ adc@0 {
> compatible = "ti,lmp92064";
> reg = <0>;
>
> - reset-gpios = <&gpioa 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> shunt-resistor-micro-ohms = <15000>;
> spi-max-frequency = <5000000>;
> vdd-supply = <®_pb_3v3>;
> diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> index f09b7c384bd9..188c9cfc7102 100644
> --- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> @@ -409,7 +409,7 @@ &sdmmc2 {
> &spi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&spi2_pins_c>;
> - cs-gpios = <&gpiof 12 GPIO_ACTIVE_LOW>;
> + cs-gpios = <&gpiof 12 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> status = "okay";
> };
>
>
> base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
Gentle ping. Given this patch is two months old now I assume it fell
through the cracks?
Best regards
UWe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain
2024-01-24 10:01 ` Uwe Kleine-König
@ 2024-01-24 10:09 ` Alexandre TORGUE
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2024-01-24 10:09 UTC (permalink / raw)
To: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Coquelin
Cc: kernel, devicetree, Leonard Göhrs, linux-stm32,
linux-arm-kernel
On 1/24/24 11:01, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 18, 2023 at 10:31:55PM +0200, Uwe Kleine-König wrote:
>> From: Leonard Göhrs <l.goehrs@pengutronix.de>
>>
>> This results in a slight improvement in EMI performance due to the lines
>> no longer being driven by the somewhat noisy VDD_IO supply of the SoM.
>>
>> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
>> arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts | 2 +-
>> arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
>> index 8a34d15e9005..4cc177031661 100644
>> --- a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
>> +++ b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
>> @@ -148,7 +148,7 @@ adc@0 {
>> compatible = "ti,lmp92064";
>> reg = <0>;
>>
>> - reset-gpios = <&gpioa 4 GPIO_ACTIVE_HIGH>;
>> + reset-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>> shunt-resistor-micro-ohms = <15000>;
>> spi-max-frequency = <5000000>;
>> vdd-supply = <®_pb_3v3>;
>> diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
>> index f09b7c384bd9..188c9cfc7102 100644
>> --- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
>> +++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
>> @@ -409,7 +409,7 @@ &sdmmc2 {
>> &spi2 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&spi2_pins_c>;
>> - cs-gpios = <&gpiof 12 GPIO_ACTIVE_LOW>;
>> + cs-gpios = <&gpiof 12 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
>> status = "okay";
>> };
>>
>>
>> base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
>
> Gentle ping. Given this patch is two months old now I assume it fell
> through the cracks?
>
Yes, apologize for that.
Applied on stm32-next.
Cheers
Alex
> Best regards
> UWe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-24 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 20:31 [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain Uwe Kleine-König
2024-01-24 10:01 ` Uwe Kleine-König
2024-01-24 10:09 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).