From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82DE2CD128A for ; Sat, 6 Apr 2024 05:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/0jwW17VvdVgIZcIOPRsCfLx4bQwDM2zmmprHjR0Bm4=; b=aLcEeba2FGmtEC 05hKyABR0ybaslSwRunl67zzN5lXPaiX3MfUHU1oTrx8X1+Z6tD+j5nAJHqB4g4KVFNqaRE/O1FTj JztGnzPr34/yJl08BVMeHkZugGN8nd6Gts80uod1r1Jou6yxRMFfIE7hAv+o9TeIb6CQFv5LwNWHH MZxffJI4hQMROtUhW3yWlyigDHcPQBlYrNHOZYWrLEmXUTjfsqPlT+FMiqYk7LyLNn8ZAN0nujMz7 HJmyrqgs8nXhxNfM5v15wQK9QXI1h3DdB1Uz1ChebH1SU0gQaPKeNq3rMEmmM03SsS5E6LidBvdMX 0Eg17FILJPuhDmupKqEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsybq-00000009ial-3pZm; Sat, 06 Apr 2024 05:28:58 +0000 Received: from mail-108-mta237.mxroute.com ([136.175.108.237]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsybn-00000009iaH-3G6u for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 05:28:57 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta237.mxroute.com (ZoneMTA) with ESMTPSA id 18eb1dce0660003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 06 Apr 2024 05:23:46 +0000 X-Zone-Loop: 8ddb6f03071a332fdecdd1fd920658bd85d21feebebd X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZmuhkTALxM8lf0cfAvP+7dJ0PJ20DaBe8z1ii1wZ960=; b=RU30JmeZw8NfKZujRbkVuhHZc7 Wdnson/TB15EBa0BLASqHxyQNxUo4sK/fpaxMJHvihEmZLBTATxOJV2BXo3NfWsttfvLKNJJWHRsE CeKtDYAyQP6Ppj2blTGdGqOtuua7XHqeODzZls2nZUb2ZPnnyrjg5+IiMbLf1veOem4ZcIE6FulIa cFzdxpC9SCQ77SbyAmHMfGhhZKRZBLnK2b3qt+pu5WL3NOdQhoD4Sx3PAD7JyD1tpsiBRFs/Iw5M2 WYtRtpD/Nl5uPmjzU7acJ0j6ti7PD2GE0ijqjph2h/9H2Iu3mWHFgIpfSZoj8eNzC+j+RW3r4jlbG IjfS1GLw==; Message-ID: Date: Fri, 5 Apr 2024 23:23:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/25] media: i2c: imx258: Add regulator control To: Pavel Machek Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-6-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_222855_909932_5A88C86E X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/3/24 12:44, Pavel Machek wrote: > Hi! > >> The device tree bindings define the relevant regulators for the >> sensor, so update the driver to request the regulators and control >> them at the appropriate times. > >> @@ -995,9 +1007,19 @@ static int imx258_power_on(struct device *dev) >> struct imx258 *imx258 = to_imx258(sd); >> int ret; >> >> + ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES, >> + imx258->supplies); >> + if (ret) { > > Will this make it fail for all current users? > > Best regards, > Pavel > It shouldn't affect current users as this was added in by dave for a completely different sensor and it still works on my ppp. Looking at the dmesg for imx258 it does reference the regulators that the ppp doesnt have but it still works. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel