From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A7BFCCF2D2 for ; Mon, 19 Jan 2026 09:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NXcdWG287LzF08jF155k+OwAYqGcwl1txjLdu6FJhII=; b=iyhgo4XJfhFYZsoX0BJzdmmpgm a7ShU00jDgroiaclLkHFpm71Q53fKVeV3F/1XJk/rOj5Ute/X+Fm+S/w6X3qYxsOe0bZzccrz73LH tsoR772Cne+hRjxWeoBHVq6cZi81UW8RuS5MQcvd9z2Oizs6kyTx6/I9Ab9t0BhlKKuOgKp1O/6wU ZcUvxXV2g9G8dPPSrjRLjCTfXx0rCFJeJhbW36sYDmKWpGEYwltY22kbESgTS6h90SV4YIFQRADcY Fh4w1eXIkZdXk0rkBj0gkenF9S1PT2OkB+G1YXN8cYsPym2Sug5gHO80UaVuWxsD7oWRpquwJbGqf G9oCL12g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhlXe-00000001dSo-0FhX; Mon, 19 Jan 2026 09:27:22 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhlXb-00000001dS8-0OmJ; Mon, 19 Jan 2026 09:27:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1768814838; x=1800350838; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FnDqYCqY4eMQu1KfJO2diG09+hGAQVkPBUCJXUeIZ0A=; b=mkG5skaIOQjYosZQq4bgzYL0Rt0GVK3ebTWZCHg5B+cflS6ijPVqOBXZ grB8oWmyGLUPvo8R+1rycaZkA8m5pD4lCBdxw1jaUpVCLFdWxv2EAAlA4 TA9wYvP36+exx/UHAgevKKMEZad7wSTuHo8Bu2RnFXcx5W+wdx4kEYUf2 2dII6Zq5Ge3hgTL4VW2nYm/Q4feTSjPKuGJUHULMH6CHuGZFkCd6AWrqw FUuSi3LR7ren20az831WLjBeJQMiaj8D7dZVRpsQMGXAHrW/t8vdlkXRe 6Irsup9Et0uoksqGMOptvS0Nh867qAgkAYC/QHKDn3yX569ujtAB+mfVj Q==; X-CSE-ConnectionGUID: i0zijf1nTfiJcIl2a1rGow== X-CSE-MsgGUID: 5Vc33klYRPeu5OUwKZF+zg== X-IronPort-AV: E=Sophos;i="6.21,237,1763449200"; d="scan'208";a="219379894" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jan 2026 02:27:15 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Mon, 19 Jan 2026 02:26:44 -0700 Received: from [10.159.245.205] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Mon, 19 Jan 2026 02:26:40 -0700 Message-ID: Date: Mon, 19 Jan 2026 10:26:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 9/9] crypto: atmel: Use dmaengine_prep_config_single() API To: Frank Li , Vinod Koul , Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Herbert Xu , "David S. Miller" , Alexandre Belloni , Claudiu Beznea , Koichiro Den , Niklas Cassel CC: , , , , , , , , References: <20260105-dma_prep_config-v3-0-a8480362fd42@nxp.com> <20260105-dma_prep_config-v3-9-a8480362fd42@nxp.com> From: Nicolas Ferre Content-Language: en-US, fr Organization: microchip In-Reply-To: <20260105-dma_prep_config-v3-9-a8480362fd42@nxp.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260119_012719_427968_581B9AF6 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/01/2026 at 23:46, Frank Li wrote: > Using new API dmaengine_prep_config_single() to simple code. > > No functional change. > > Tested-by: Niklas Cassel > Signed-off-by: Frank Li Looks good to me: Acked-by: Nicolas Ferre Thanks, best regards, Nicolas > --- > drivers/crypto/atmel-aes.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index 3a2684208dda9ee45d71b4bc2958be293a4fb6fe..e300672ffd7185b0f5bf356c2376681537047def 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -795,7 +795,6 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, > struct dma_slave_config config; > dma_async_tx_callback callback; > struct atmel_aes_dma *dma; > - int err; > > memset(&config, 0, sizeof(config)); > config.src_addr_width = addr_width; > @@ -820,12 +819,9 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, > return -EINVAL; > } > > - err = dmaengine_slave_config(dma->chan, &config); > - if (err) > - return err; > - > - desc = dmaengine_prep_slave_sg(dma->chan, dma->sg, dma->sg_len, dir, > - DMA_PREP_INTERRUPT | DMA_CTRL_ACK); > + desc = dmaengine_prep_config_sg(dma->chan, dma->sg, dma->sg_len, dir, > + DMA_PREP_INTERRUPT | DMA_CTRL_ACK, > + &config); > if (!desc) > return -ENOMEM; > > > -- > 2.34.1 >