From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Juan Yescas <jyescas@google.com>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v8 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
Date: Mon, 30 Mar 2026 14:10:57 +0200 [thread overview]
Message-ID: <bc0f6fe7-c3bd-4c75-8829-11123a7649a0@kernel.org> (raw)
In-Reply-To: <dcf2c447d9bbe16e800a4dd7e74ecc26d3ade3db.camel@linaro.org>
On 30/03/2026 14:00, André Draszik wrote:
> On Sat, 2026-03-21 at 20:14 +0100, Krzysztof Kozlowski wrote:
>>
>> This causes warnings, so I dropped the patches.
>
> I assume warnings are because I didn't make it clear enough that patch
> 2 is actually required?
No, these are obvious errors coming from bindings. You can try yourself
instead of asking maintainer to run the commands for you...
>
>> I really do not
>> understand how this is organized. This is not a dependency for pm
>> domains driver but it is included here.
>
> The binding is being updated, and the driver follows suit.
> I particular, the driver needs to be aware that pd is (can be) a child
> of pmu.
>
> Yes, the driver does not depend on this binding update, but it shows what
> the driver must support. I believe this is what we have done in the past:
> binding and driver updates in same series.
Yes, foo-binding goes with foo-driver to foo-subsystem. It does not mean
you put here completely different bindings. Why? Because just like foo
goes to foo-subsystem, then bar-binding goes with bar-driver to
bar-subsystem.
>
> I could move patches 3 and 4 from this series together with a DTS
> update patch into a separate series, if that would be deemed a better
> approach?
I asked you what are the dependencies and you answer there are some but
you can move it outside of patchset. So are there or are there not
dependencies? If there are, then you cannot move out. But then I ask
what are the dependencies.
It feels like question to trick the maintainer. Maintainer complained,
so you propose whatever he objected to without understanding whether
this is correct or not correct approach.
>
>> It is a soft dependency for DTS,
>> but that is nowhere to be found.
>
> I was waiting for review of all binding changes before posting DTS.
That would be fine explanation, if you also read maintainer soc profile
for Samsung and try what is written there. You would see that you
introduced new warnings without any fix possible as far as next is
concerned.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-30 12:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:27 [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-03-18 15:27 ` [PATCH v8 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-03-18 15:27 ` [PATCH v8 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:52 ` André Draszik
2026-03-30 10:55 ` Krzysztof Kozlowski
2026-03-30 10:59 ` André Draszik
2026-03-30 11:03 ` Krzysztof Kozlowski
2026-03-18 15:27 ` [PATCH v8 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-03-18 15:27 ` [PATCH v8 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-03-21 19:14 ` Krzysztof Kozlowski
2026-03-30 12:00 ` André Draszik
2026-03-30 12:10 ` Krzysztof Kozlowski [this message]
2026-03-22 23:08 ` Rob Herring (Arm)
2026-03-18 15:27 ` [PATCH v8 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-03-19 10:13 ` Ulf Hansson
2026-03-19 10:29 ` Marek Szyprowski
2026-03-19 11:58 ` André Draszik
2026-03-19 15:57 ` Marek Szyprowski
2026-03-19 16:42 ` Ulf Hansson
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:53 ` André Draszik
2026-03-18 15:27 ` [PATCH v8 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-03-18 15:27 ` [PATCH v8 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:55 ` André Draszik
2026-03-18 15:27 ` [PATCH v8 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-03-18 15:27 ` [PATCH v8 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-03-18 15:27 ` [PATCH v8 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-03-21 13:17 ` (subset) [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 Krzysztof Kozlowski
2026-03-23 11:13 ` Ulf Hansson
2026-03-30 9:54 ` Krzysztof Kozlowski
2026-03-30 10:13 ` Ulf Hansson
2026-03-30 10:17 ` Krzysztof Kozlowski
2026-03-30 11:12 ` Ulf Hansson
2026-03-30 11:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0f6fe7-c3bd-4c75-8829-11123a7649a0@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox