From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] ARM: dts: ux500: Fix up the thermal nodes
Date: Wed, 28 Aug 2019 17:25:16 +0200 [thread overview]
Message-ID: <bc1e8257-2812-da1c-3ddf-c17581e4445f@linaro.org> (raw)
In-Reply-To: <20190828135218.7307-1-linus.walleij@linaro.org>
On 28/08/2019 15:52, Linus Walleij wrote:
> The thermal driver for the DB8500 was never properly converted
> to device tree, the node should definitely be activated for
> all board variants so move this down into the main SoC
> DTSI, and default on.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/boot/dts/ste-dbx5x0.dtsi | 22 +++++++++++++++++++++-
> arch/arm/boot/dts/ste-snowball.dts | 29 -----------------------------
> 2 files changed, 21 insertions(+), 30 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> index b1a31134f860..7953eea7c486 100644
> --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> @@ -505,10 +505,30 @@
> thermal@801573c0 {
> compatible = "stericsson,db8500-thermal";
> reg = <0x801573c0 0x40>;
> + interrupt-parent = <&prcmu>;
> interrupts = <21 IRQ_TYPE_LEVEL_HIGH>,
> <22 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "IRQ_HOTMON_LOW", "IRQ_HOTMON_HIGH";
> - status = "disabled";
> + num-trips = <4>;
> +
> + trip0-temp = <70000>;
> + trip0-type = "active";
> + trip0-cdev-num = <1>;
> + trip0-cdev-name0 = "thermal-cpufreq-0";
> +
> + trip1-temp = <75000>;
> + trip1-type = "active";
> + trip1-cdev-num = <1>;
> + trip1-cdev-name0 = "thermal-cpufreq-0";
> +
> + trip2-temp = <80000>;
> + trip2-type = "active";
> + trip2-cdev-num = <1>;
> + trip2-cdev-name0 = "thermal-cpufreq-0";
> +
> + trip3-temp = <85000>;
> + trip3-type = "critical";
> + trip3-cdev-num = <0>;
I think you can fold both patches, that would be clearer than moving and
then removing.
> };
>
> db8500-prcmu-regulators {
> diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> index 3428290644ba..064e8abec954 100644
> --- a/arch/arm/boot/dts/ste-snowball.dts
> +++ b/arch/arm/boot/dts/ste-snowball.dts
> @@ -376,40 +376,11 @@
> pinctrl-0 = <&ssp0_snowball_mode>;
> };
>
> - cpufreq-cooling {
> - status = "okay";
> - };
> -
> prcmu@80157000 {
> cpufreq {
> status = "okay";
> };
>
> - thermal@801573c0 {
> - num-trips = <4>;
> -
> - trip0-temp = <70000>;
> - trip0-type = "active";
> - trip0-cdev-num = <1>;
> - trip0-cdev-name0 = "thermal-cpufreq-0";
> -
> - trip1-temp = <75000>;
> - trip1-type = "active";
> - trip1-cdev-num = <1>;
> - trip1-cdev-name0 = "thermal-cpufreq-0";
> -
> - trip2-temp = <80000>;
> - trip2-type = "active";
> - trip2-cdev-num = <1>;
> - trip2-cdev-name0 = "thermal-cpufreq-0";
> -
> - trip3-temp = <85000>;
> - trip3-type = "critical";
> - trip3-cdev-num = <0>;
> -
> - status = "okay";
> - };
> -
> ab8500 {
> ab8500-gpio {
> /*
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-28 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 13:52 [PATCH 1/2] ARM: dts: ux500: Fix up the thermal nodes Linus Walleij
2019-08-28 13:52 ` [PATCH 2/2] ARM: dts: ux500: Update thermal zone Linus Walleij
2019-08-28 15:43 ` Daniel Lezcano
2019-08-28 15:25 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1e8257-2812-da1c-3ddf-c17581e4445f@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox