From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F81C10F0E for ; Tue, 9 Apr 2019 16:27:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FF562084F for ; Tue, 9 Apr 2019 16:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HfEkVEtu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FF562084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S2S9GmyRJRbM2UNOw+L7BxZFPraKYy+aUwY+p3qvv3M=; b=HfEkVEtuqgRz8P ADMtXSSe1U8PIDSwX4XB3Of0tuoHbZx3d1SJpn483bv8fT/W3ySfzXvweKwthmG7RpbUUhgZTiJg0 70durjkDz7D2nsJenMcTW9Pe0c2ic9AlocA9WkepKkto9cummMXrO1Ie5AEutgMPiLGROmZVHDD/j Ds4tdXO61UXfO/DiGSK62koH49diSTQENoddn/3iICCSuP5tNlpI8BF03XNZ9Zu8Uuq7bXBtpn9Ot 9MNDlG1FZlBo84HaYkt6CPXTOFdrYoiH93DRck/dCg61G+WVpJ0sHTCgfxqTL5l+8oumgBuaXjKly kaCUhmjSRzYGMgvLnZTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtbJ-0003Qk-Nj; Tue, 09 Apr 2019 16:27:57 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtbH-0003Pn-2s for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 16:27:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01AC715AB; Tue, 9 Apr 2019 09:27:52 -0700 (PDT) Received: from [10.1.197.45] (e112298-lin.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D3A93F68F; Tue, 9 Apr 2019 09:27:50 -0700 (PDT) Subject: Re: [RFC 3/6] objtool: arm64: Adapt the stack frame checks and the section analysis for the arm architecture To: Mark Rutland , Peter Zijlstra References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-4-raphael.gault@arm.com> <20190409161204.GS11158@hirez.programming.kicks-ass.net> <20190409162420.GB32587@lakrids.cambridge.arm.com> From: Julien Thierry Message-ID: Date: Tue, 9 Apr 2019 17:27:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190409162420.GB32587@lakrids.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_092755_133280_48EC3BAE X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Raphael Gault , jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2019 17:24, Mark Rutland wrote: > On Tue, Apr 09, 2019 at 06:12:04PM +0200, Peter Zijlstra wrote: >> >> I'm just doing my initial read-through,.. however >> >> On Tue, Apr 09, 2019 at 02:52:40PM +0100, Raphael Gault wrote: >>> + if (!(sec->sh.sh_flags & SHF_EXECINSTR) >>> + && (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) >>> continue; >> >> could you please not format code like that. Operators go at the end of >> the line, and continuation should match the indentation of the opening >> paren. So the above would look like: >> >>> + if (!(sec->sh.sh_flags & SHF_EXECINSTR) && >>> + (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) >>> continue; >> >> You appear to be doing that quit consistently, and it is against style. > > Raphael, as a heads-up, ./scripts/checkpatch.pl can catch issues like > this. You can run it over a list of patches, so for a patch series you > can run: > > $ ./scripts/checkpatch.pl *.patch > > ... and hopefully most of the output will be reasonable. > For this particular case, checkpatch only warns about it if you pass it "--strict" option. So in general it might be useful to include this option at least for the first pass at including large pieces of code. Cheers, -- Julien Thierry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel