From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7F66EE644B for ; Fri, 15 Sep 2023 09:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FHNuuqlHx2SArqrEUFiRqUaynYkLONq2CPkoox8WSbc=; b=Pd5xsXp7qj9iP6 kOMa/29qMmGdBhW1cxufY3UOmyt8O+3Pyu++jxozDgTHZ4xX559FlovwhcjQw5iZyqhRa9MSN/gvI zHElH5WuZWedsf0YCMluiHi+3X/hJjhpEdiY8yOqYDjyGw0LVvpDsfQV+NLKzke3o0E2Bb5nRsxfQ b9oPFdhw93Wwb4A+fDgliPNSNbw2UEMg3zfENRso6y/M1HTh0gOIovuHHayyh0Vx/OyPA6N42ZwWL ovCyar/SPKzUmwrzSZn806zYaJRoClCYCqUmSODeVIK2lI5L5EuaLy4FpEZfmbcAyYsmpAjikoUXo 1uxoLIsUwahah8zz3aPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qh53e-00AH6e-0T; Fri, 15 Sep 2023 09:24:14 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qh53b-00AH4a-1H for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 09:24:12 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38F9Nt6B079447; Fri, 15 Sep 2023 04:23:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694769835; bh=4VeziTl+d8+AbgxzpJag5vUqbkWM3E4fMIuyXtnWn1U=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=F3kyzuFFrqo13xYV4oBqzGrPfPlQHB81syKDNevbRnSkMHhRgtrbCfu2fYN/EByUN LhLVg872+ZhwGYqeP3Tjks+JHEcQ/z9RNUnhK3mMj0DpTbOD7T+7Fm9a7nHw8R8xAi g6zmhI/q4Q4oxy9XQifNqsKN7nsb0XDY5l+dVTB4= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38F9NtFX120940 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 15 Sep 2023 04:23:55 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 15 Sep 2023 04:23:55 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 15 Sep 2023 04:23:55 -0500 Received: from [10.24.69.29] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38F9Npqr039108; Fri, 15 Sep 2023 04:23:51 -0500 Message-ID: Date: Fri, 15 Sep 2023 14:53:50 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Content-Language: en-US To: Nishanth Menon CC: Krzysztof Kozlowski , , , , , , , , , , , References: <20230913114711.2937844-1-n-yadav@ti.com> <20230913114711.2937844-2-n-yadav@ti.com> <32c82fa2-f8b9-d22d-f0ac-f8d6e48df39d@linaro.org> <20230914160450.knooq6q3dflostv4@playtime> From: Nitin Yadav In-Reply-To: <20230914160450.knooq6q3dflostv4@playtime> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_022411_581936_0F35D919 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/09/23 21:34, Nishanth Menon wrote: > On 14:56-20230914, Nitin Yadav wrote: >> Hi Krzysztof, >> >> On 14/09/23 11:57, Krzysztof Kozlowski wrote: >>> On 13/09/2023 13:47, Nitin Yadav wrote: >>>> Add support for AM62Q NAND card: X8 NAND EXPANSION >>>> BOARD card (PROC143E1) for AM62x LP SK board. > > Commit message is all too wrong as well. Sigh. > >>>> >>>> Signed-off-by: Nitin Yadav >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++ >>>> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++ >>>> 2 files changed, 31 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >>>> index 284b90c94da8..e93e79d8083f 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >>>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 { >>>> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>; >>>> status = "disabled"; >>>> }; >>>> + gpmc0: memory-controller@3b000000 { >>>> + status = "disabled"; >>> >>> status is never first in DTSI. Really, where did you see such code? >> Thank for pointing out, Will send a revised version. > > GPMC is not functional without board specific interface configuration > such as pinmux. this approach, in fact is all over the place now and > discussed in the mailing list multiple times now. > > What is missing here is the documentation of the constraints as to why > it is set as disabled by default. gpmc nand is only am62x lp sk in am62x series. it has pinmux conflict with macsp1, so disabling gpmc & elm by default for other am62 series. For am62x lpsk in overlay macsp1 is disabled. > > >>> >>>> + compatible = "ti,am64-gpmc"; >>>> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>; >>> >>> First is compatible, second is reg/reg-names/ranges. >>> >>> >>> Best regards, >>> Krzysztof >>> >> >> -- >> Regards, >> Nitin > -- Regards, Nitin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel