From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 968CFC433EF for ; Wed, 11 May 2022 16:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1uYRVG0pay91RpR7DRPYtBRbUSV+yo5oRVItbpjhS5s=; b=USu7wFWbyURYz0 6+iJIV1qVofyMjDvF+narI7tNJB1v6zKBdMMyjR3nibJWjor+1s+hQnpCN1FeAkeM3UMCaL5JIkrS pDj0QB93gbZFSszvm3+SaftzYparLy/9futJP4dJOIa079cGqi13x5ma9pWDTMEAqm6GC4qMGh2AB eMozP4YBs6gemE+I586iXki3xLAPomefA9o71RbTVaC2Twi2jH7Ah9zMupA1axuIE3BkLfWSIhnif YwtPSKdbpETi7fJ4YRMjghee6DRdLn2jd5CzZNgRxolcToKWH3lUvIWagh3Dksg/XLgzxKB7B5nJm uiIXddIVTBVPeH3pnZIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nopCE-007msd-FP; Wed, 11 May 2022 16:28:18 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nopCC-007mr0-5V for linux-arm-kernel@bombadil.infradead.org; Wed, 11 May 2022 16:28:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=eFymRECNSN5ye7k5OChXPswBlwaVnIJWXD7MjpienjQ=; b=V9m/gb8n/1sa+NEyW1rtE5S/0r eeo+xqflFk+YnqxrzpfRqZ5rjrlEYptkGxhZUo3nH6xsuDsC5ydMz4SfU/8Hqu9fofPsJUPKf3DJ5 u5rkXXW1Bw3rVCFwXyQASGHJ+cKzrHP0uNis4GytCl2g6Nf/0qs0quIMego4AIqqhxQ5bO6HnlY6Q vY4/Wj+sUWBINVJ3gao0tra0OIRNGR5H2xDpInyiZYo5zAYnEXmf/0OySVhyCfTtzs+eLG9m2kgeY +MIqtz4fgz9w7B5tZsBlYcCDoZYEjDPU+POFLugMEtYF0unnGC027DolsU3QBfYobbgae6+r5PmVP QoVIKDAg==; Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nool6-00DCyy-UP for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 16:00:19 +0000 Received: by mail-ej1-x62b.google.com with SMTP id gh6so5074911ejb.0 for ; Wed, 11 May 2022 09:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eFymRECNSN5ye7k5OChXPswBlwaVnIJWXD7MjpienjQ=; b=F8pFd7IGqv380dhqtK0KUi/veBULkaOkmVT6fq87+YWimx0KDIrCzrcCX8IYQKF/e2 oifPmC+J49ba6koD7ggfZOyGFUhIjC2N+16S6Grd6DDdO60jDtNJ02G4RaGXPqY1N6uF RAJX0qkM4aeq3FAX3HSSC4FdYlg494N45ZRXgjh3MBE2G5mA1qADr3Z3HX5PrnfAKsE+ 3qAF2nttDit3HJJA3df5v3MsyBoApdNtXGFtcvI+NrNFU5H4aNtop8fpoKoYE0tamXnY epxaeiEPpwQ3xxKm3aJ/LyLPCYh3aaXRXwiV6gV7AifLUaDZlElN6m9ZtJ0RNh42fQ/U D4XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eFymRECNSN5ye7k5OChXPswBlwaVnIJWXD7MjpienjQ=; b=JQjbeJgtqwj1uWQ6kwsOn31p+6TK/zllIXIg9ftlf5+4/Rhc0ioJJsB5+jJvWUStvO Te/QborckVeYHCccy1SNJgjQ8eJ6+P77UtdO+mX5KqgpgP38Ub/vzL81HO648nmzPySd bcnY/jtR/8SrVgfCNW1Om0N/EqQXloi+xT8a/czE6qp2CbYODbP7OzQpunsE/oogn2HX okezKkNzYjAsxoActgk2mUjzY2f0BflXsGIpCBT+AwgKICmiXJ77+5oH4XkmEqtd3bSh TtdeFjTuXSP8pxnwggbpZfJUbdMlFzBl7PWY1xyax/Sz05OrcNsCSHDnvfSlLNbrUgsV n3WQ== X-Gm-Message-State: AOAM530IWQ2yyzJbZwxZkc2S3NpxNAyIgh/n6hQhWDOpu3ZhX79cx7Gp 1KgVMFXsE3BEjS1CZSssXqtdcKHUEEX7r2Id X-Google-Smtp-Source: ABdhPJysoqA/nzZ30scYkBwjFxjUK+dAiYf2mo8FGsNQSfR4U30SbuOWRSjFXYoH1g9Yg334VcVh6g== X-Received: by 2002:a17:907:9690:b0:6f5:160a:25b8 with SMTP id hd16-20020a170907969000b006f5160a25b8mr25654920ejc.504.1652284811118; Wed, 11 May 2022 09:00:11 -0700 (PDT) Received: from [192.168.0.155] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z12-20020a50e68c000000b0042617ba63b7sm1513122edm.65.2022.05.11.09.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 09:00:10 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 18:00:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/3] dt-bindings: media: rockchip-vpu: Add RK3568 VEPU compatible Content-Language: en-US To: Nicolas Frattaroli , Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Ezequiel Garcia , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220511155309.2637-1-frattaroli.nicolas@gmail.com> <20220511155309.2637-2-frattaroli.nicolas@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220511155309.2637-2-frattaroli.nicolas@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_170017_213458_3FCE907C X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/05/2022 17:53, Nicolas Frattaroli wrote: > The RK3568 and RK3566 have a Hantro VPU node solely dedicated to > encoding. This patch adds a compatible for it, and also allows > the bindings to only come with a vepu interrupt. > > Signed-off-by: Nicolas Frattaroli > --- > .../devicetree/bindings/media/rockchip-vpu.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index bacb60a34989..965ca80b5cea 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -22,6 +22,7 @@ properties: > - rockchip,rk3288-vpu > - rockchip,rk3328-vpu > - rockchip,rk3399-vpu > + - rockchip,rk3568-vepu > - rockchip,px30-vpu > - items: > - const: rockchip,rk3188-vpu > @@ -39,7 +40,9 @@ properties: > > interrupt-names: > oneOf: > - - const: vdpu > + - enum: > + - vdpu > + - vepu > - items: > - const: vepu > - const: vdpu > @@ -76,6 +79,18 @@ required: > > additionalProperties: false > > +allOf: > + # compatibles that end in -vepu should only have the vepu interrupt > + - if: > + properties: > + compatible: > + contains: > + pattern: "^[a-zA-Z0-9\\-,_.]+\\-vepu$" Why not listing the compatible how I asked? This is the common way of handling allOf:if:then per variant. https://lore.kernel.org/all/ea94f18d-3172-98bb-0892-a98236a08018@linaro.org/ Your patches do not apply on next, so the set might not have been tested by Rob's bot. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel