From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32743C38142 for ; Mon, 23 Jan 2023 11:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gqUciqWo7FsHGw4esBrq3NkwedYLEgr1A47Z4gc1Hto=; b=x8TkwUzTpohfLW 687fTwX17fEpKx3+Y83jyTDp+7RxkoBKcXfI883XTq+dbPZN+e1sVBm0OQ+wO7VqGWkd2vYG9LClA kXM536vIQH3W3I5zMawQEZRQxAiPOSt8BMT5mNO7EdlLW+Bxmkn5HFik1dRAnQk6nOmqHf2e5msfS +mn0tTPpG2MUy0H4afItn/VQdltA+dE05yAOgJFe9w0DuH7Wq1TFQugptjaMbobY1RBFicT6LdPHU AEZckvxMc5R4yoNFui9j9rezRyxgKzldp7LbiDRS9dQIw+wu5roUlokUbGU2h95vXrf6NtqFyukny OrbuPjCUecUvp1V1Wm3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJvJl-00H0HX-Qx; Mon, 23 Jan 2023 11:48:54 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJvJi-00H0Fr-9B for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 11:48:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674474530; x=1706010530; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MqK+k1al8CIzRI41by3oaXUn/9kDU4MqvAJ4vBrzrvM=; b=YEosL8McoudqeL+ZTY2ZBm0SbNpkMxz8yMkgVvepjeRF5SgnuDC/cEDc JNjGrB+2Loa8Y2Vpp/kMACrs93GuEVvkfE8iVzwCptlmbXUsLSpmoU5o3 BzNxxy5B3z0sPJhSumySA9tFdHvb/VdshvZKaMx7Jp8OvBlPue5e+OajR kgDQbTX8gNfjkruxvAOxzYhLNNWP81R2jJN6hzo7U3oWTTgvBn6FBuuR9 ufpbvpuyVZNRp/kENxdDpciGQDxwi4TcN4tEsNSEA3hCYH0Ac3xwYlW9R Mlx/zSEcGXl1OP5EywXnnGAWvneyNrzs55dqJeBQ+ot6+X/dYnb8vJTpj g==; X-IronPort-AV: E=Sophos;i="5.97,239,1669100400"; d="scan'208";a="133562808" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Jan 2023 04:48:44 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 23 Jan 2023 04:48:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 23 Jan 2023 04:48:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfUWO3GKrTR8pjAY7H2SN0vDs2K47tDr9Z09iopL1HhmUH39iFe6CWP8SF1YDmgpE2UbxRkPEIbbG/fRdtaOccQyVKtCg7nsjOY14nqocBbsH2WVU0okCcMc00qqs7kh1/qt36vFDH8TnxC71Aw905ugRDXEHy5bL9R7H4FAUsxhk33TAm9+aQPameRI6LCrqCi3PNf2pZSZ/2ZEpByzKU++dqjSiiGHSAcHt8gW5yyxnGDhr5clBRrdfiwtHkpd1AXKt1PVat+oxcei4JbJzwJbQ/uiujLG519TCsqUCFspAvSWPI8eF93aJmYmK4vBIFd4gCJh3enppa6NPdTpUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MqK+k1al8CIzRI41by3oaXUn/9kDU4MqvAJ4vBrzrvM=; b=EqEYz6FWGCP1O/106GwV1c/zPl9AUP2dfKV8y7NMwiZ+i/KINSnYllDEDY07BrF1YOy7bdoIeb2EjS4s9+pmTM+oZCYFG/TaC6FOTTcLnILSSyuUDBtJaP6xJQshPsujpTdgzkSOra00d87fQO4FMO9EgSemfqImBaICIbFYyyTOw0ZSND4tY/vcJ2BwGCOc2Yjvdu9O/GyGbDMRMOEHuY5t6xbOvp/nc4Dvdg/iIUfy2kamaQIcdLNb4SCz6qYMKqFTRHITpAMCRN0b/kmSiusy34vyvwqPCBRm4M7si1fP1ZG9w8Qs7w609+icYqAU+lqJl+CL5S9XWwbyE2f1UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MqK+k1al8CIzRI41by3oaXUn/9kDU4MqvAJ4vBrzrvM=; b=pQ+ROBNZ3FATkxU4rQjmuzmiM9uW4RCvqhlInuLUpTPc9ZboNDdJHg8WXa1GZT81dc/unfYMyhGRrurG6+rQ5AO03ILFRKvc9kOHR6Lm6bEvn+TOswTA8rsPBwQcfleOzZn8Nj+fHXfNnmOWw+FYeNy2gqLeKpzfEw9wVU9/0g0= Received: from CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:99::15) by SA0PR11MB4718.namprd11.prod.outlook.com (2603:10b6:806:98::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 11:48:43 +0000 Received: from CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::3758:fd2d:5bd1:9758]) by CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::3758:fd2d:5bd1:9758%7]) with mapi id 15.20.6002.033; Mon, 23 Jan 2023 11:48:43 +0000 From: To: , CC: , , , , , , , , , Subject: Re: [PATCH 06/15] soc: add Ambarella driver Thread-Topic: [PATCH 06/15] soc: add Ambarella driver Thread-Index: AQHZLv3IyzxhA+fjH0GH7s70/n+1xK6r4zOA Date: Mon, 23 Jan 2023 11:48:42 +0000 Message-ID: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-7-lchen@ambarella.com> In-Reply-To: <20230123073305.149940-7-lchen@ambarella.com> Accept-Language: en-IE, en-US Content-Language: en-IE X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5154:EE_|SA0PR11MB4718:EE_ x-ms-office365-filtering-correlation-id: d54f3fb5-c7bb-43e8-e653-08dafd37c6dd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZsE2Zqd2kv0fMsX68y9XKNf6yBzocdyLgLa8NI7WZHyVek4s+c/eMhYDwdkg0GEnSfJ2K4O7v4k8nZskY0Rq9qSBJSl30ifmTCgTPcntCGGaUeN+a3k1jTLDo0fnnItsD/wWg5jB8uysEpH9Q6KbAMblLoQ4yUzB1mVYAkJuVFDi3BI71CtwjffyvFt3mfY0JCpUG/T266CJHM+AYJKaoL5Kc4X+ermUd/QX7LonFMLAE+d2ZLq8UClB/T2PymNFhDzDtryDvC4NMomVZglRxxLMRb+edRhjKDOjTY3GRaJ0Lcj9bcpqZQ8QSte81hnNjjJloOTKD+xCd7YumwXvouxNPceYIqsvfb0M4wHUr4NciV3g/5IQkub+OF2pIDI44QoqpZtzE3VXdoDj9aVozxfJQDVdJr5P/uI1e87y2oCqgBSYHpufE64sVrcwLUS2/jKAMcSgv2fRoyhxxoz18f73PuRzW81mpl8aHxh/A/VUjmH1F+PSZy7BBKvmDgbZh5Vv3k9rnDHWu9r93XufF+Ds8d1ZOvB9p8w+TMTjiwMtHC0dicEj3ej+Ix4ITrPEIvlBA0kU4x01m9hibPi/MfMV22JsncLLfLOuA+G4d2ulRupOXlZ7NW0atX28LXw8sTxHZHUsVnhM5V9bWnIw0Pj83LGUGYcQ+dqCSxO7eifFIMvCKHjTdoznDzg/p8agXUKu9rq9I0GbKJ1ztihwQkU5y3tD4rIzwHw3ItE3LJz6TuoPtfW/EKdbNB3xbu7GgtRP7QO0RxYbgXo+mqOW1ht71SE5sTHXkEUwGKmkxEo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5154.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36756003)(38070700005)(2906002)(5660300002)(7416002)(38100700002)(8936002)(4326008)(41300700001)(122000001)(83380400001)(86362001)(31696002)(66446008)(71200400001)(478600001)(110136005)(6486002)(91956017)(31686004)(66476007)(8676002)(6512007)(53546011)(26005)(186003)(6506007)(316002)(54906003)(2616005)(66946007)(76116006)(64756008)(66556008)(41080700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a1BFaUlnYUVvaUp4M24yUW9ZcGp4TS95T01WWmM1dUY1YURVYWxUWllWQU9l?= =?utf-8?B?UWd2KzFDVGxPN09ZVVRBeGNneGhza1pMR1p6MU5iTXFZaWt1bDNacGRmblRL?= =?utf-8?B?ZlBOdkpxV2h5dGU4N2VtTXY2aVU0NVdnZnNRNkwvL1VJdE9Mbk8yL3VyaXRF?= =?utf-8?B?eFJHQ2g2WkNxQklmZ2xzeHcrWUtXd3FvVnh2Ni9PZFhURVZQNkQ0QWw4cE9u?= =?utf-8?B?Z1ZrVUdhWGpmZzh5WVF3VHA2THJnd1pjb1lNdjVSbXdTVktwRW1OWmU4UGR1?= =?utf-8?B?ejFBMGRTeTNVSWhIdm53VU9TVHk3eHpZWHZkbWVVelo4QnpYU3c2WDR2Smo0?= =?utf-8?B?cVpRUjBHQkF0Mm5JaEVRVjVTM2dBMkNUTkF1ME9sVmgvRnFtTFdYTTY0N0hZ?= =?utf-8?B?RVRJZE9iQlNpb0ZhbXlMTFBnYXBNVFhRODNMUVM2b2RQcHhnYWN5ZlNHRXVG?= =?utf-8?B?clgzZFk4VSsrMi9TSE1VOW1hK1lreXdsVFVMSWRjekNPK3ROamkxSytEZU1x?= =?utf-8?B?R2lPYnByakxJWXgrVWdwQ0Q5ditpeVNhL0RKMFQ0S1MzTVR0a3g0RHBPekxy?= =?utf-8?B?cXJUWDRYbGlCSzJUUHhtTlpUcXR6VlN2QXUweGJxK2RWeDN2eGlYUXovcWxv?= =?utf-8?B?SkEzZXdHem1HMVRFdzc1RU1wRHdpOENmS3lZU1g0aEZ1RE96dUs4SWdQVklO?= =?utf-8?B?TmgwUDhQaVpXY2JmeGx4Qlk4cmw0WE1Ka2xRNDVsYngrdU05dnJNTmdEOHow?= =?utf-8?B?RlRsaUw0aHBDSFFNUTFVcHdENkl3bUwya3lGWHJESmk1bmczNlVqbWFMcnpY?= =?utf-8?B?RmRMSkZBMWdkUFZuTXdxbVk5Wk1VZlh5R3dySURpY0ZOeHBGd2h2SkVkMDBI?= =?utf-8?B?YU0xUlpRZ1BvZTd2eC96elhVOUxzdk14bEpMUVFIT1dDRnllRHZYcUZNS2Rz?= =?utf-8?B?bjVTZ2lUNmZ5RGg3M3A4QzhUSStkZjcwdzZLZFlmbkxjTk9VTXdmN2RDZ2dX?= =?utf-8?B?RDhqMTN5ZzNVVWpkQyt4bkd2TFY0ZGcwV0VJT0phOEJ1dUFnc1Z0WHJmU2w5?= =?utf-8?B?UDFvdmthNVpnR1dwYTVjSHNNa3VFTFhQdDhQWXBqaGJYaGhBc0N1UnRXV1VN?= =?utf-8?B?dGZSN2xIOTF1N0pHL0lVRitDL0RXTmYybUV5RmwwZTZ5Y29qYXpNMUZDMGta?= =?utf-8?B?Q01ZQnNZdlFyb0NOMnliQ0ZQN1plalpmSHJmSlFkaEM2VXBXOUwwdmRlUElB?= =?utf-8?B?ZE9jcGNvUHZ3bnByY1NDT3V2SEtlOFhrYjh0bkRSRVV5eG1Na0VYQndHM2dk?= =?utf-8?B?SEpqT3A2SFNGNmZadVdRR0xtWVBPbFl2V0NrSXJnQ2RGWmttZnBSeFdUWUkw?= =?utf-8?B?YWVRVG9mZEtHTWRUWGFRQndRMy9CT0pXaVE5cjVYc1ZEWjczTHlOdjM5MHRs?= =?utf-8?B?RFptTTZUU1d3SmFFNENpUW9lcFF6VitTMlFVVGNwOW9PNU1ZWlkvQkdaSzVt?= =?utf-8?B?WVg0Zk4rNnpMYkJLY2dOUjIzcHRmenFmeTdURitLN1NLMmFET1VtdlV4c1VO?= =?utf-8?B?bkIraU0wUlpvWGp1R21jN05ZWW1BdTV1TXFMeW1FTmhVZW1kTVV1akRyZktl?= =?utf-8?B?VXhkOVhKSHJEdERIM2Rmd2xDYTMwemxQZlVzWlZobzRFOWhpdEd5S2RkQ3d1?= =?utf-8?B?TEkvL3RneTlzalNTWjFuT1ZiTEZpMDlnYVRQaCtOUHRSa2ozRUlHenZ2UnJM?= =?utf-8?B?Wkh4R2RQQ3JxMDZ4VVFpbXN3eDU4eGJKaUV0QU80dUtGOHp6c1lGTmpqSEEv?= =?utf-8?B?bFhUUnFLeE56UDUrSXl6eU40K3daZ01VWDN0S2dLbVdrdHQ1WlBkRThwUUJG?= =?utf-8?B?d0IwS25QeDBLVXh5ZlJDVmQ5VnZZRTQwV2g5ODVHSTl0a3dVcTZYN2MxWS8y?= =?utf-8?B?MytOYTRlamJGVTlNWGRDQUZwcWlYYWo5dFFIZVJ3VmhsY2x4bnJWVU1SWUlV?= =?utf-8?B?Z2hLSzc0MisydnZidWJweE91RWc5Ui9kd0JEMllQdjd1Q3NoZXI0VElVWTR0?= =?utf-8?B?VlVsdjNSV0FtZHhPQ0gvTCtHOXdWZ0t2UVh5MysvUzJHNUs2OWE3akZjWFBL?= =?utf-8?Q?zNn1sfXCCrOOflweWVdp/TEhX?= Content-ID: <75407D7E8B0A064AAABFFD64E26133F0@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5154.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d54f3fb5-c7bb-43e8-e653-08dafd37c6dd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 11:48:42.7649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RxIaEWc7n1ai+IQicA4d6yIoTTn/DBiV9XO6KczypcOT8mNVyBmbgjpYR8MCiMHwB2J0bsxGl3NyKTxsIMQiWMUglxXwd9dBEToA7Sxp9og= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4718 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_034850_662806_1051E8D8 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Li Chen, Since you've already got a bunch of other comments, I have two minor ones for you. On 23/01/2023 07:32, Li Chen wrote: > > This driver add soc_id support for Ambarella, > which is stored inside "cpuid" AXI address mapping. > > Also provide sys_config(POC, aka power on configuration) > for other drivers. > > Signed-off-by: Li Chen > Change-Id: I4869a3497366ac7779e792835f8e0309239036a8 > --- > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > index fff513bd522d..e3e270aa32a4 100644 > --- a/drivers/soc/Makefile > +++ b/drivers/soc/Makefile > @@ -8,6 +8,7 @@ obj-y += apple/ > obj-y += aspeed/ > obj-$(CONFIG_ARCH_AT91) += atmel/ > obj-y += bcm/ > +obj-$(CONFIG_ARCH_AMBARELLA) += ambarella/ > obj-$(CONFIG_SOC_CANAAN) += canaan/ If you could follow the existing (by directory) alphabetical order that'd be great. > obj-$(CONFIG_ARCH_DOVE) += dove/ > obj-$(CONFIG_MACH_DOVE) += dove/ > diff --git a/drivers/soc/ambarella/Makefile b/drivers/soc/ambarella/Makefile > new file mode 100644 > index 000000000000..384276c046ca > --- /dev/null > +++ b/drivers/soc/ambarella/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +obj-$(CONFIG_ARCH_AMBARELLA) += soc.o The subdirectory is already gated by this symbol, so is there much point gating it on the same one again? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel