From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72DE6CF2579 for ; Sun, 13 Oct 2024 10:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xElVQ4mKdF99aRyJNyik2rnaeNmbp+Nxc8ep/QMb65Q=; b=I2slNp9pJ+8uilR3wBLM4uYgiT 5oBIVdD3hQulDxHEXT0W99T1PimDp934bNP3ZZtYtCBafq7MhK4phYf9nsxDjYXljLowt43Kz0GM2 ExsVLeXxHBaya97EyUxgOQLULRUKRw0BMHd91uuXRXNzf7lUsD5lG52J/7Q8AzqXt9S4iEBT2Vasa GPq446GGOUV0dNEZAKByfNwJ7uGbJt6zQk60/EiUUMC03QVlkiX+w/Y9WCoNLcp4q0oPAHak4QoIL XRFvqwJUi5HrNBsPpjBZ3QUPRASsP5fomRx2yaZD0By9fRxYnEjRrHkbG98h1hvQP+calZQLwdt6g 4n5c43wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szvzE-00000002Wr0-0mB7; Sun, 13 Oct 2024 10:38:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szvxi-00000002Wlv-1qfm; Sun, 13 Oct 2024 10:36:43 +0000 Received: from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7712A4CE; Sun, 13 Oct 2024 12:34:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728815691; bh=jv181G+FaIRLVdfFraR5EE0bpproMOxHJsKmM5Os9HE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mscq3wPuxaMUV0emVJ0SaMswbj9okRLex+1DjuEN3wug1OphqXwSL/UadvJq3HkR+ 8eFiaLN7k3kZlpfHtXgCZzkbx9VUHaF4MH0e0pWGiwZSsKvUR8Ozy5GjPbQ5wKoRVx 4HL+YaXlTQDoxd34q+VQ9Uu1tqF7OgZkO1zaxZ54= Message-ID: Date: Sun, 13 Oct 2024 16:06:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] staging: vchiq_arm: Use devm_kzalloc for mgmt To: Stefan Wahren , Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Dan Carpenter , Laurent Pinchart , kernel-list@raspberrypi.com References: <20241013084529.377488-1-umang.jain@ideasonboard.com> <20241013084529.377488-3-umang.jain@ideasonboard.com> <50425e82-2a41-4a3b-a983-2560ab0ccab2@gmx.net> Content-Language: en-US From: Umang Jain In-Reply-To: <50425e82-2a41-4a3b-a983-2560ab0ccab2@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241013_033634_875118_58353EE4 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/10/24 2:43 pm, Stefan Wahren wrote: > Hi Umang, > > Am 13.10.24 um 10:45 schrieb Umang Jain: >> Signed-off-by: Umang Jain > except of the missing commit message, this patch looks good to me. I > understand the concerns about devm_kzalloc, but I think this doesn't > apply in this case. That's what I was wondering as well, since I tried module unloading and with the cdev also goes away? So shouldn't be conern, right ? > > Since this should be treated as RFC, is it already tested? yes, it was tested > > Regards >> --- >>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +--- >>   1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git >> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index e780ed714a14..334fb7037766 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -1345,7 +1345,7 @@ static int vchiq_probe(struct platform_device >> *pdev) >>           return -ENOENT; >>       } >> >> -    mgmt = kzalloc(sizeof(*mgmt), GFP_KERNEL); >> +    mgmt = devm_kzalloc(&pdev->dev, sizeof(*mgmt), GFP_KERNEL); >>       if (!mgmt) >>           return -ENOMEM; >> >> @@ -1403,8 +1403,6 @@ static void vchiq_remove(struct platform_device >> *pdev) >> >>       arm_state = vchiq_platform_get_arm_state(&mgmt->state); >>       kthread_stop(arm_state->ka_thread); >> - >> -    kfree(mgmt); >>   } >> >>   static struct platform_driver vchiq_driver = { >