linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shin Son <shin.son@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sunyeal Hong <sunyeal.hong@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: exynosautov920: add cpucl0 clock DT nodes
Date: Tue, 22 Apr 2025 10:00:14 +0200	[thread overview]
Message-ID: <bc7a33de-9c8c-4377-a813-562da18ab314@kernel.org> (raw)
In-Reply-To: <20250418061500.1629200-4-shin.son@samsung.com>

On 18/04/2025 08:15, Shin Son wrote:
> Add cmu_cpucl0 clocks for switch, cluster, and dbg domains respectively.
> 
> Signed-off-by: Shin Son <shin.son@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index fc6ac531d597..d1528633adfe 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -582,6 +582,21 @@ pinctrl_aud: pinctrl@1a460000 {
>  			compatible = "samsung,exynosautov920-pinctrl";
>  			reg = <0x1a460000 0x10000>;
>  		};
> +
> +		cmu_cpucl0: clock-controller@1ec00000 {
> +			compatible = "samsung,exynosautov920-cmu-cpucl0";
> +			reg = <0x1EC00000 0x8000>;

Lowercase hex.
> +			#clock-cells = <1>;
> +
> +			clocks = <&xtcxo>,
> +				<&cmu_top DOUT_CLKCMU_CPUCL0_SWITCH>,

This looks misaligned.


Best regards,
Krzysztof


  reply	other threads:[~2025-04-22  9:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250418061515epcas2p1ddd9ec01dd5de8b238c77dcef14d745a@epcas2p1.samsung.com>
2025-04-18  6:14 ` [PATCH 0/3] add CPUCL0 clock support for exynosauto v920 SoC Shin Son
2025-04-18  6:14   ` [PATCH 1/3] dt-bindings: clock: exynosautov920: add cpucl0 clock definitions Shin Son
2025-04-22  7:54     ` Krzysztof Kozlowski
2025-04-23  0:45       ` 손신
2025-04-18  6:14   ` [PATCH 2/3] clk: samsung: exynosautov920: add cpucl0 clock support Shin Son
2025-04-22  7:59     ` Krzysztof Kozlowski
2025-04-23  0:59       ` 손신
2025-04-18  6:15   ` [PATCH 3/3] arm64: dts: exynosautov920: add cpucl0 clock DT nodes Shin Son
2025-04-22  8:00     ` Krzysztof Kozlowski [this message]
2025-04-23  1:05       ` 손신

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc7a33de-9c8c-4377-a813-562da18ab314@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=shin.son@samsung.com \
    --cc=sunyeal.hong@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).