Re: [PATCH V2 4/7] dt-bindings: PCI: host-generic-pci: Add power-domains related binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/07/2024 20:13, Mayank Rana wrote:
> Add "power-domains" usage (optional) related binding to power up ECAM
> compliant PCIe root complex.
> 
> Signed-off-by: Mayank Rana <quic_mrana@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> index 3484e0b..9c714fa 100644
> --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> @@ -110,6 +110,12 @@ properties:
>    iommu-map-mask: true
>    msi-parent: true
>  
> +  power-domains:
> +    maxItems: 1
> +    description:
> +      A phandle to the node that controls power or/and system resource or interface to firmware

Wrap how Coding Style asks (so 80).

I am sorry, but power domains are power domains, not interface to
firmware to enable your hardware. Rephrase it to actually describe the
hardware.

Also, drop all redundant information. It cannot be anything else than
phandle to the node...

> +      to enable ECAM compliant PCIe root complex.
> +

Anyway, there are no DTS users with such power domain. Look at the
binding and its compatibles. Does any of these devices have power
domain? No.

Best regards,
Krzysztof