From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8219C4338F for ; Wed, 4 Aug 2021 16:25:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D68760FC4 for ; Wed, 4 Aug 2021 16:25:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D68760FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ITQ7H5E101IQVk2zj68RiwXn7qcNStRPJ+Y8AsWcsEw=; b=FTuTrhhEK59FRuFitERUcJEZZF E9IliXBUbzE0xRXMoDQdLWB4A/FFsvRydiFDlumo8TJCgeMkX5RBB8FMk7Bsxpch7/nH1PKMOxexd AohN+NUfyBKaZForWT0olar7OYBsCVzBoymRgd6uNL59eq6KQiXR9aRZiBGke95SJBvcGOQNghhfK X0NYVd7ZsDwyNxcJTqUY4VyqquFgIWD7xOBtSsDeAkvLWjPKIQKfSJA+a3DYQXakNgzUsvBdpksKu ovVJ/Eqm3tKsZjWPD62M6cTWBASXyiRKGsqaiwoob4ems7NxAkNIFzM3kLI9jisYZEaGB6xRDCOHy DvSmIyXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJgH-006kfr-Hv; Wed, 04 Aug 2021 16:23:45 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJgD-006kfJ-Vy for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 16:23:43 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 174GNQSa023223; Wed, 4 Aug 2021 11:23:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1628094206; bh=P3bpeuO0QmNE3qQI826O8a5FJlDGgmTnBCuYCPidq/Q=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=lxTWKiuGpabrBMtSVN9ikaWr2+zniBG6PA460BZgke0VMO9VGL8mLBCR+J6LKYQzC dh+Sbj+oHD7ustNXVYbSLiJKTN0aGtR273axx8bXa+CUDzzcmxze+rFd8wg0nC4YcU Jt5ySxiJV0FfMVWmCSqxlBbbzcYbtKaQtrHhgM6A= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 174GNQPH099461 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Aug 2021 11:23:26 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 4 Aug 2021 11:23:25 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 4 Aug 2021 11:23:25 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 174GNOQ6057761; Wed, 4 Aug 2021 11:23:25 -0500 Subject: Re: [PATCH] ARM: Fix Keystone 2 kernel mapping regression To: "Russell King (Oracle)" , Linus Walleij CC: , Nishanth Menon References: <20210804135747.737233-1-linus.walleij@linaro.org> <20210804141042.GQ22278@shell.armlinux.org.uk> From: Grygorii Strashko Message-ID: Date: Wed, 4 Aug 2021 19:23:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804141042.GQ22278@shell.armlinux.org.uk> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_092342_175133_7D2E4204 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/08/2021 17:10, Russell King (Oracle) wrote: > Hi Linus, > > Looks fine. An improvement: > > On Wed, Aug 04, 2021 at 03:57:47PM +0200, Linus Walleij wrote: >> @@ -250,7 +253,12 @@ __create_page_tables: >> add r0, r4, #KERNEL_OFFSET >> (SECTION_SHIFT - PMD_ORDER) >> ldr r6, =(_end - 1) >> adr_l r5, kernel_sec_start @ _pa(kernel_sec_start) >> - str r8, [r5] @ Save physical start of kernel >> +#ifdef CONFIG_CPU_ENDIAN_BE8 >> + add r5, r5, #4 @ Move to the upper 32bit word >> + str r8, [r5] @ Save physical start of kernel (BE) > > These two instructions can simply be replaced with: > > str r8, [r5, #4] > >> +#else >> + str r8, [r5] @ Save physical start of kernel (LE) >> +#endif >> orr r3, r8, r7 @ Add the MMU flags >> add r6, r4, r6, lsr #(SECTION_SHIFT - PMD_ORDER) >> 1: str r3, [r0], #1 << PMD_ORDER >> @@ -259,7 +267,12 @@ __create_page_tables: >> bls 1b >> eor r3, r3, r7 @ Remove the MMU flags >> adr_l r5, kernel_sec_end @ _pa(kernel_sec_end) >> - str r3, [r5] @ Save physical end of kernel >> +#ifdef CONFIG_CPU_ENDIAN_BE8 >> + add r5, r5, #4 @ Move to the upper 32bit word >> + str r8, [r5] @ Save physical end of kernel (BE) > > Same here. > > The patch can still usefully be tested by Nishanth without these > changes... it'll tell us if this was indeed the issue. > > Thanks! > with 903101cbc1f6 (HEAD -> next-master) ARM: Fix Keystone 2 kernel mapping regression c3f7b3be172b (tag: next-20210803, linux-next/master) Add linux-next specific files for 20210803 eaf554c397cd Merge branch 'akpm/master' can boot to console. https://pastebin.ubuntu.com/p/fPJPQWxwkT/ -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel