linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sean.wang@mediatek.com (sean.wang at mediatek.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 06/19] arm: dts: mt7623: fix USB initialization fails on bananapi-r2
Date: Fri, 23 Feb 2018 18:16:26 +0800	[thread overview]
Message-ID: <bcb9dbeb1389e71f4eaba0c2def1c991703e10c4.1519378872.git.sean.wang@mediatek.com> (raw)
In-Reply-To: <cover.1519378871.git.sean.wang@mediatek.com>

From: Sean Wang <sean.wang@mediatek.com>

Fix that USB initialization fails as below runtime log is present during
booting on bananapi-r2 board by adding missing regulators the USB device
requires. Current regulators USB device uses are being updated with the
correct ones to reflect real configurations which are all from fixed
regulators rather than MT6323 one's output.

[    6.473958] xhci-mtk 1a1c0000.usb: fail to get vbus
[    6.479313] xhci-mtk 1a240000.usb: fail to get vbus

Cc: stable at vger.kernel.org
Fixes: f4ff257cd160 ("arm: dts: mt7623: add support for Bananapi R2 (BPI-R2) board")
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
 arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
index ec11e14..f660d15 100644
--- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
+++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
@@ -39,6 +39,24 @@
 		};
 	};
 
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	reg_5v: regulator-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-5V";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	gpio_keys {
 		compatible = "gpio-keys";
 		pinctrl-names = "default";
@@ -502,12 +520,14 @@
 };
 
 &usb1 {
-	vusb33-supply = <&mt6323_vusb_reg>;
+	vusb33-supply = <&reg_3p3v>;
+	vbus-supply = <&reg_5v>;
 	status = "okay";
 };
 
 &usb2 {
-	vusb33-supply = <&mt6323_vusb_reg>;
+	vusb33-supply = <&reg_3p3v>;
+	vbus-supply = <&reg_5v>;
 	status = "okay";
 };
 
-- 
2.7.4

  parent reply	other threads:[~2018-02-23 10:16 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 10:16 [PATCH v1 00/19] refactor dts and add support for more boards sean.wang at mediatek.com
2018-02-23 10:16 ` [PATCH v1 01/19] dt-bindings: pinctrl: mediatek: use - instead of _ in examples sean.wang at mediatek.com
2018-03-02  7:43   ` Linus Walleij
2018-02-23 10:16 ` [PATCH v1 02/19] dt-bindings: cpufreq: " sean.wang at mediatek.com
2018-02-26  4:13   ` Viresh Kumar
2018-03-19  2:51     ` Sean Wang
2018-03-19 10:35       ` Matthias Brugger
2018-03-02 15:53   ` Rob Herring
2018-02-23 10:16 ` [PATCH v1 03/19] dt-bindings: pinctrl: mediatek: add bindings for I2C2 and SPI2 on MT7623 sean.wang at mediatek.com
2018-03-02  7:44   ` Linus Walleij
2018-02-23 10:16 ` [PATCH v1 04/19] dt-bindings: arm: mediatek: add support for more mt7623 reference boards sean.wang at mediatek.com
2018-03-02 16:00   ` Rob Herring
2018-03-12 11:03     ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 05/19] arm: dts: mt7623: add BTIF, HSDMA and SPI-NOR device nodes sean.wang at mediatek.com
2018-03-12  9:40   ` Matthias Brugger
2018-03-12  9:53     ` Sean Wang
2018-02-23 10:16 ` sean.wang at mediatek.com [this message]
2018-03-12 11:03   ` [PATCH v1 06/19] arm: dts: mt7623: fix USB initialization fails on bananapi-r2 Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 07/19] arm: dts: mt7623: fix the regulators mmc should use " sean.wang at mediatek.com
2018-03-18 23:49   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 08/19] arm: dts: mt7623: enable three available UARTs " sean.wang at mediatek.com
2018-03-18 23:49   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 09/19] arm: dts: mt7623: add related clock properties to cpu[1-3] nodes sean.wang at mediatek.com
2018-02-26  4:13   ` Viresh Kumar
2018-03-18 23:49   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 10/19] arm: dts: mt7623: remove useless property pinctrl-names at node switch@0 sean.wang at mediatek.com
2018-03-18 23:50   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 11/19] arm: dts: mt7623: use - instead of _ in DT node name sean.wang at mediatek.com
2018-03-18 23:50   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 12/19] arm: dts: mt7623: fix all Warnings (unit_address_vs_reg) sean.wang at mediatek.com
2018-03-18 21:54   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 13/19] arm: dts: mt7623: move node mt6323 leds to mt6323.dtsi sean.wang at mediatek.com
2018-03-02 15:40   ` Rob Herring
2018-03-02 22:46     ` Sean Wang
2018-03-18 23:46       ` Matthias Brugger
2018-03-18 22:01   ` Matthias Brugger
2018-02-23 10:16 ` [PATCH v1 14/19] arm: dts: mt7623: extend common file to unify all boards with MT7623 SoCs sean.wang at mediatek.com
2018-02-23 10:16 ` [PATCH v1 15/19] arm: dts: mt7623: add SPI[1, 2], I2C2 and sound related nodes to reference board sean.wang at mediatek.com
2018-02-23 10:16 ` [PATCH v1 16/19] arm: dts: mt7623: fixup available memory size on bananapi-r2 sean.wang at mediatek.com
2018-03-02 15:42   ` Rob Herring
2018-03-02 23:27     ` Sean Wang
2018-03-05 14:16       ` Rob Herring
2018-03-05 15:46         ` Sean Wang
2018-02-23 10:16 ` [PATCH v1 17/19] arm: dts: mt7623: add MT7623N reference board with eMMC sean.wang at mediatek.com
2018-02-23 10:16 ` [PATCH v1 18/19] arm: dts: mt7623: add MT7623A reference boards sean.wang at mediatek.com
2018-03-02 15:45   ` Rob Herring
2018-03-03  2:15     ` Sean Wang
2018-03-05 14:10       ` Rob Herring
2018-03-05 15:10         ` Sean Wang
2018-02-23 10:16 ` [PATCH v1 19/19] arm: dts: mediatek: converted to using SPDX identifiers sean.wang at mediatek.com
2018-03-02 15:52   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcb9dbeb1389e71f4eaba0c2def1c991703e10c4.1519378872.git.sean.wang@mediatek.com \
    --to=sean.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).