From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E04EDC001B0 for ; Tue, 8 Aug 2023 20:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mlRm51YHnkiqzlIm3CNUOuJhsGVk6fR1smQqMeazCMk=; b=a2TLgYXSq1+zKx 9+wPzoXlvNBTAHLoCiU5BPSZqDnXW72pW+HFeC5S7leLN5WXY1GhyhkQ3iphPVYFKJF34aUiRRcKt y9URIxLnKC9N0shPMHRKIZMOYJUhJcz+72jkP1CRpiW5d0xp31oyRXhKTj8mEZ+S6N5JjmI95NsKk A8z71OCWEratYGzdL2x+922J0xiBX1nBr1UBBr0SVUp5dRSBLaABahHFgQqRIvJHSKt3GKEU0yLvQ 3SyUDfDkDCxGpZ5dD+4T9i5ZQXKYsjG9R1OeCyqde0rMkOU7G+HqD0geIdrIud988sDxIEbcGR1tc 5olIP0qHSLTvhj0mxjtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTTga-003S8h-08; Tue, 08 Aug 2023 20:52:12 +0000 Received: from out-125.mta0.migadu.com ([2001:41d0:1004:224b::7d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTTgW-003S7z-26 for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 20:52:10 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691527919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0xvoeirahWFZ+3tNj8n9ficPcKAPak4lBFOk6V+FiJU=; b=NPb2ggKevHGdvXHMqS//lDI8x3nQGwGQPb6cUdkEMzTsiejj/VSYBxdNqn5UmY8lHHB/S1 +/Ng0nHQnpOnpnsQq0MxS1qC/Oy0q0Zjqge3DvakcnmYHiAHovNty6TNGkAu3NIF7g6E28 zQqWf+vcCwqAB400CTa7tQYQGMaWl0E= Date: Tue, 8 Aug 2023 21:51:55 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Simon Horman References: <20230804190454.394062-1-vadim.fedorenko@linux.dev> <20230804190454.394062-3-vadim.fedorenko@linux.dev> <20230808130327.5638d15b@kernel.org> <20230808130617.5ad74486@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230808130617.5ad74486@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_135208_832600_EBE7B064 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 21:06, Jakub Kicinski wrote: > On Tue, 8 Aug 2023 13:03:27 -0700 Jakub Kicinski wrote: >>> const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE >>> + 1] = { >>> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), >>> [DPLL_A_PIN_ID] = { .type = NLA_U32, }, >>> >>> >>> The "/* private: */" comment was added to the generator after Simon's >>> comment. But I'll include this part into the next version. >> >> We only added private for enum masks, I'll send a patch for nlattrs. > > On closer look these have no kdoc, so the priv markings are not > necessary, dropping them sounds right. Ok, I'll add the version which is generated by the script with the lastest patch, I mean with new line and priv markings. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel