From: Krzysztof Kozlowski <krzk@kernel.org>
To: fnkl.kernel@gmail.com, Hector Martin <marcan@marcan.st>,
Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
asahi@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Janne Grunau <j@jannau.net>
Subject: Re: [PATCH v2 4/5] arm64: dts: apple: Add touchbar screen nodes
Date: Tue, 26 Nov 2024 17:47:13 +0100 [thread overview]
Message-ID: <bcd5e48d-bb2d-4d49-88b4-e66839559dc9@kernel.org> (raw)
In-Reply-To: <20241126-adpdrm-v2-4-c90485336c09@gmail.com>
On 26/11/2024 17:34, Sasha Finkelstein via B4 Relay wrote:
> /*
> * Force the bus number assignments so that we can declare some of the
> * on-board devices and properties that are populated by the bootloader
> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index 1666e6ab250bc0be9b8318e3c8fc903ccd3f3760..b8d2d22ab81adfb7642ea362c6a6af4c04a9bf9d 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -379,6 +379,68 @@ cpufreq_p: cpufreq@211e20000 {
> #performance-domain-cells = <0>;
> };
>
> + display_dfr: display-pipe@228200000 {
> + compatible = "apple,t8112-display-pipe", "apple,h7-display-pipe";
> + reg-names = "be", "fe";
> + reg = <0x2 0x28200000 0x0 0xc000>,
> + <0x2 0x28400000 0x0 0x4000>;
Please follow DTS coding style in respect of order of properties and
indentation/alignment.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-26 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 16:34 [PATCH v2 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay
2024-11-26 16:34 ` [PATCH v2 1/5] dt-bindings: display: Add Apple pre-DCP display controller bindings Sasha Finkelstein via B4 Relay
2024-11-26 16:46 ` Krzysztof Kozlowski
2024-11-26 16:54 ` Krzysztof Kozlowski
2024-11-26 17:00 ` Sasha Finkelstein
2024-11-26 17:20 ` Krzysztof Kozlowski
2024-11-26 18:24 ` Hector Martin
2024-11-26 18:33 ` Sasha Finkelstein
2024-11-26 18:25 ` Nick Chan
2024-11-26 16:34 ` [PATCH v2 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay
2024-11-26 21:00 ` Alyssa Ross
2024-11-26 16:34 ` [PATCH v2 3/5] drm: panel: Add a panel driver for the Summit display Sasha Finkelstein via B4 Relay
2024-11-30 9:29 ` Dmitry Baryshkov
2024-11-30 11:15 ` Sasha Finkelstein
2024-11-30 11:36 ` Dmitry Baryshkov
2025-01-12 20:27 ` Sasha Finkelstein
2024-11-26 16:34 ` [PATCH v2 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay
2024-11-26 16:47 ` Krzysztof Kozlowski [this message]
2024-11-26 16:34 ` [PATCH v2 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd5e48d-bb2d-4d49-88b4-e66839559dc9@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=sven@svenpeter.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).