From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DACA9C38A02 for ; Mon, 31 Oct 2022 05:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IsVOyxJjrKaCgz1hyaXcAIvb0vXumQ7ijFQEkB/h41Y=; b=3+ih6bRjLf74iE G+n8C7lREMjKouEI3iM2THS339yUATtc1dE9oB/sf0yWTcKZ0DpFK4dZHHfdgxLo1xZV6ixN1uNTX FkvmbgP/kg6q8lW3//oW95mGsNcTqjUdJ2hWlLONnB7Q67t69shB/40CWXXIx6krb0tcuJoaAiaN5 bqa7n5i8ppiuvlZh+1WaCm+jcaNJskxLxDcR308uKM03SWzhzFhdpZ9QTlRJrDKSFKHwTDKtKmuCR y/VgyZ52uG0BaOH8ry+AConotjPrl+OHRApZcU1FcFTeJW45Hrn76pumjA7ffviVJqxMVr8sDmSob puJt8FDW2hn2sFfGfe8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opNSQ-008Lxr-QR; Mon, 31 Oct 2022 05:35:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opNSL-008LhR-Js; Mon, 31 Oct 2022 05:35:33 +0000 X-UUID: db80cd4fe8ef42fa9f067d89b2d86847-20221030 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=7MAPi0ms0jEGVMhPjHoeVledbMOROyqdqM9ZKAoJTLM=; b=jx24bNQfvDr3GBXdTmnOasr4H97th2+ZEruoyAOSC6weA6w+SQleDlHqDYBUpF3HEoov3BJig5kbnPJ326zfljVhcSzOscSW6ADdRMkyzVWjUFnyuaWqE9lo/Mj9k9Z7+Q61WcY3EKvJv2+/tSVmziS7BSvz9vApp6mRe6rj/Ps=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.12,REQID:d39f6625-ed8e-4a13-9aa6-1f8c518962cc,IP:0,U RL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:62cd327,CLOUDID:b26c1490-1a78-4832-bd08-74b1519dcfbf,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: db80cd4fe8ef42fa9f067d89b2d86847-20221030 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 812958764; Sun, 30 Oct 2022 22:35:19 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 31 Oct 2022 13:14:44 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n1.mediatek.com (172.21.101.34) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 31 Oct 2022 13:14:44 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5NkoK6TP0NEuuM+ZzigIalEEzHA7lXFCzf6hFUv9ZcxplTyfj4+fAfq+8f6C+ppEsmQCpY+bmIpM6D0aFTwVWk4MGKv1yIthv8m4IbR5Xi0YZ2PM+wQ81g0KInP3FFCJ3/D5u4MeivswWH+kmxoaBfmEHtAjd7fp4hFodaCeokO1Wl9BBuklU2LQtDh0C4qxiWUT/okvuk+7CMMdRgbfkGF4gDY60qoSopdg2xMjVfRe7Yccv5UH+KhTJp4SoaRAWMW2vvAjtim46HjT2wRBD8z98xetZdyK9huyP6zEMGO1Shkj9X/YtJs718gWoYxcAqb6wz0JEKfqpVyBUK2Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7MAPi0ms0jEGVMhPjHoeVledbMOROyqdqM9ZKAoJTLM=; b=Wsz2Vvit4XUGk7+5Wy08vGl6sh0tV5CCFkVE+8XN5xZslKWFFbu+4YNryVuGrKv3CLk4bEZaux+uuBfysFmz3YcD4BugsCnzP3LaTz1dpXpIgueyliTd8hpzxRv8rbBOrzyCLDR5xal1OB4S0r+3EfGw7Be5D4PqH6Mo62UiuQW6Nmfcz/3kKKI2PvKAhz9YzxV0c1bbEpTsFY5JQi3HFbwLDY0VycptGz32sHWF8SqCQGz4LOnm9LGJqbwaa1tpKaT/g6wvJlRWf0sMuGOVAP06W4TeqxVOMt8q7sbPdU9Myq3y1tcj66VzBCJsrNnaQ/k9rQx7jmKp6KUkK7MeVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MAPi0ms0jEGVMhPjHoeVledbMOROyqdqM9ZKAoJTLM=; b=ms9bmX72S6ScE9Q/IyXu48ws8jJkQMBjlsNENt6F/dDjVR4zOizF/eMPDsilkVtgZQ9l3A/Q7QKP9HHdVUtPEZ70q6hiM6fk+nzOeP86wkqgfbyZgzTfaaoqbuNXIAtG989/hd9AdIVlHie9W8llqF/mdS9x8pRiJV+UU71WoHY= Received: from SEYPR03MB6531.apcprd03.prod.outlook.com (2603:1096:101:8a::9) by SG2PR03MB6231.apcprd03.prod.outlook.com (2603:1096:4:16a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 31 Oct 2022 05:14:41 +0000 Received: from SEYPR03MB6531.apcprd03.prod.outlook.com ([fe80::d882:f0e9:8578:7b2]) by SEYPR03MB6531.apcprd03.prod.outlook.com ([fe80::d882:f0e9:8578:7b2%6]) with mapi id 15.20.5791.010; Mon, 31 Oct 2022 05:14:41 +0000 From: =?utf-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= To: "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "sboyd@kernel.org" , "angelogioacchino.delregno@collabora.com" , "mturquette@baylibre.com" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , =?utf-8?B?UnVueWFuZyBDaGVuICjpmYjmtqbmtIsp?= , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , =?utf-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , "linux-clk@vger.kernel.org" , "nfraprado@collabora.com" Subject: Re: [PATCH v6 1/3] reset: mediatek: Move MediaTek system clock reset to reset/mediatek Thread-Topic: [PATCH v6 1/3] reset: mediatek: Move MediaTek system clock reset to reset/mediatek Thread-Index: AQHY5TqrdEtTIcSC5USdcV24arVPjK4e8MAAgAkUJQA= Date: Mon, 31 Oct 2022 05:14:40 +0000 Message-ID: References: <20221021104804.21391-1-rex-bc.chen@mediatek.com> <20221021104804.21391-2-rex-bc.chen@mediatek.com> <8b73e38b-ae78-1f85-f5f0-f13bce6e45de@collabora.com> In-Reply-To: <8b73e38b-ae78-1f85-f5f0-f13bce6e45de@collabora.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEYPR03MB6531:EE_|SG2PR03MB6231:EE_ x-ms-office365-filtering-correlation-id: 6f3ac7b7-df91-4a08-1ea9-08dabafed092 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1z5ilEeDUrMsUWTxwS6R0jpt74YYIQr87zu3tJF3pj4U+T5mLsSJhkW3zXp7ucehRidfFIGC7LCNwuqVB0WtPbzAtKkQab+peZfACJq4wWheh/VKsocmcQhUFX0Q6iKckeXtPeTC5hy61ybnZEZp+na0xC/spk58b6AH3m5taI1+fDjZ0Xv4tnkox8c5KMO+kT1bD+vBvO4YponOO9P4D/zcJcRPonuZ3inu5bPz6CEYya++udIU3AJLGI6qqXPEeSwKmaJkhPkyI2+gB9RhjgUsaWaMEk/Lf4B3PKOgYJnw80Sb5v+cBdtVh3UuyAd1GO9n6HIstz5ptK0di5CqwB7YPmD6dsiFE5cE0AUU4nTRQHxJKTJUhFC7IBq33f7ovDyu708rvDbz4kB1JFK51AQFHSunf1SwIpIeFgUtidN38fSv5a3PyWOCtwHElZi/EhOWM02MGaJ3OD4d28nSEavhyxHiA+VB6lMCxTjGx0t2bLu1MINUgwDOB1ybvB5/sharB9JuuQFDwAH6eIMfhshsWED86SgN2I5sLN3MQLryocNvBCHUUu4lWw3hdd+SvoNCgKAdW4BJAPQAg/+Q4sUIsLIzE1mrVYnjrpInwtaWko39Fjs9UEuV480zjMeffexcDGROw1EqIoJOAFxLmZuAQz6Jyi+G21bvwz54ZWXbZzTonrdT8OvtxBTe7EE5x3k5rxrYR3MF8Lx1onhR/gbrezu5ejXVc/PcrYui2QAPd/O3iToZlTMsMagnQ7AJH+8W+ZnqAr3iSJomA8IEckXRbz5jMMlaqfSWF7Efa8I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEYPR03MB6531.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(451199015)(8676002)(8936002)(85182001)(66556008)(91956017)(2616005)(36756003)(6486002)(66476007)(86362001)(110136005)(4326008)(71200400001)(54906003)(66446008)(76116006)(4001150100001)(316002)(66946007)(38070700005)(64756008)(6512007)(6506007)(83380400001)(122000001)(26005)(38100700002)(966005)(478600001)(186003)(30864003)(41300700001)(5660300002)(2906002)(7416002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T3VXbjQ5c09maWxLa0JNWUVOdkFCUjliUmNuZ0tNQjlScWdKQnBPRzVBWW12?= =?utf-8?B?Nk9lR0VlT1ZKdU9MZzk3MUhjaGVkd3pOQXhBcGprWEM5d2taL2xIQUhzYWND?= =?utf-8?B?OE54dURwNzJKRVpQNitBd2NDbkUzL3o2TzJ5dSsrU05XTERsWXVkWWd1QnFi?= =?utf-8?B?emdGR2xpcVpYdGdvOWMyUzYyQUsyQ2RGMW13Q3EzZ2NuWkE4d3dFWloxRFR6?= =?utf-8?B?dVlpS01UVEpRSm9DVTVVWGtCMXhkcHo0U2tlOGIrNGd6SWtkV3dIRnk0bmJS?= =?utf-8?B?RUdPQVpLNHFEckpiMmZOQTZLR3NEN3luNy84WVpHMTlXU2pDQ0dVRFNydzlI?= =?utf-8?B?S0poVmxFOFRGT3kzZVR2QlRCeUp2R0lseXYwNE9TazEvbkoxdEI5L21rNWRL?= =?utf-8?B?RlNZRHRNMy9NaUJmQ3E0TnM5Ym52enZqSjVBbE1xTk02R0hnL0t1T0l6OHBQ?= =?utf-8?B?MS84SXp1aFRtK0J1eHVYbVFEdnd6WkdDVkR0Mit6M3hIdkZQc1BNSGVSK0Vi?= =?utf-8?B?QTZCNEZTYWI5VWtBY215em5wZ3haZVRxWmpsZGZGcGpFQUVSVXRacnhjZmRU?= =?utf-8?B?dGRlaWxlbmFpTzAyWmdpS3pMWitHNmwrTk16Q2RQM09RZ1pYSWxhNnVnaWpS?= =?utf-8?B?enJTOVJmZUtXcjgyTWRoV1Ayc2tyMFdQWFhneXFzQ21tUTZvdGdmUHRQK3lZ?= =?utf-8?B?SmpLaUhIQXk4RERZbVhaVGw2clV3R1E3eG9SUEZZQXZLS3Q2clpxSzlHY3FN?= =?utf-8?B?Tkh1L3drODZ6UWNJeEtxaFJTdmxmNDl6Z0YyYVZlUDdSRVF5UEJ0ZGJmVk1Y?= =?utf-8?B?YjJGU2Z2eFkwZUZHUU82ajc5R3I1SGNIVTBxMWFsaUV6YXBINmU1a2NLaE8y?= =?utf-8?B?OGNsTjNWK3N2VXZLbW93Um16YW9VL291K2hGMVVzUi9yc0RmWTBhWWFsakpx?= =?utf-8?B?SndFSTYxeDVqY2FBZ3VaWVZYd2ZwUC9GQWR5RXd1MUxJbEpVejQrM2llNC9G?= =?utf-8?B?Z2pOdklRSk9ZK2FJa1RaRUxnQ2xNazNMZktLUTVvQU9zckRsaHNyNzk1Tk9X?= =?utf-8?B?bmZ4TlB6NkFZQ3NvcVZkZkk0K2h0Uklrd25BWXRNYkZBUFR3SWhUUXFHTG0y?= =?utf-8?B?M2d3cHRQNEVXb0NZbXEzRzVpVDFnaFJFcktrNHNWb2MvcCtnek9JNjFxc25p?= =?utf-8?B?UGJsQ25LSzd1bkRMUEVnK3ZPN2RDOE9lMlFYS1h2Z293UDBNZ0RHOWZ4czhl?= =?utf-8?B?T0FkSzZvUnB2UGdZV2l0bUpFN0hIdlkrL2VTNzQwa05nVFB0YVhZcmZ2dnYv?= =?utf-8?B?Vkp5dzlaRzg2Z2hicXgrdTdWSjhBTmhkbVNFK1JsWXBXaTlFZlB6VHYrcFgx?= =?utf-8?B?WUMvR2pUWVJzZTBMaVFCUnhzRjFRY0JyU1RwdnphUUFrbGNwbXRHZ01kZFdz?= =?utf-8?B?TU95dE5SZ1BJcXBLb1AxWWtmeU1zbExUSUZjdm1wRVRZaDhIZzVncHBTSGtQ?= =?utf-8?B?V3Jsa2QxRUFIbEFmejJiOHZvczdyT08ydDJ6NWlpWE5oS2NHYUpsZHZ5V1Vz?= =?utf-8?B?OGx4QU50bEZmcFowWDh0Q2huTjlTQ1NLN3VnM0tMOUdxdUZnSGdFajZHaWs0?= =?utf-8?B?YmVJZmVJY3cvS08wY1VUS3EzVm9rNUlhQnhxK2VOejBtRHNoUStlSkFjeDlO?= =?utf-8?B?YVd2MVYwNHYyQmh2TGppYkdvd2V6bVo1L0QwYmdGc1J0cEU3UGxMbkRTdjRi?= =?utf-8?B?VUg3bzBmWFNGL0JrY1VWT3pTNkRySmVySy9TbkNkNC9XT2hqdVdKcmJxQ0ZF?= =?utf-8?B?VmxzZzNKVWVmdUliQytWVzRDdExqNVd3SFhxOSsyeERmaVo2dWpCaUJiaURu?= =?utf-8?B?M2RweHVMUXFiSzVsYlo0UTZFb2NSc3dMUEd6ZHdwb2F6ekd2VytKdmRRN1pu?= =?utf-8?B?amdLbjh3dE5nREJXSHpGbnJqU3ozUzkyZVZkMGtQR2dGN1BKd1h2djdhdWVn?= =?utf-8?B?dVRaaldCVzRzdFhJVkdpTzlueVd4T3FIZmZIT2VXNUFRWmFkd3ZabmV4NU9D?= =?utf-8?B?WFhJbWlBMnMxR3dSb1hxWE1uTkhRZWJGMjJNSG5kSEJHd3hwazFXdHdhMk9C?= =?utf-8?B?Wk9SbnVJTHh4dHRHRHdLZXpwQ0NWdlJsRkhxS3p3R0pHeHBtVDNyaE9pSTNJ?= =?utf-8?B?N2c9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEYPR03MB6531.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f3ac7b7-df91-4a08-1ea9-08dabafed092 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 05:14:40.9418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0ueTmGOakPXCP01AiHq0z45pvbzZU5Lu2KFVVwhpDS9fmVVrR9fbOWyncdos3uAtpKorwBnAhQusnjLelVsS4xKkuBxWCcebFoAWKuSayXs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR03MB6231 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221030_223530_205984_E916BC64 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-10-25 at 12:36 +0200, AngeloGioacchino Del Regno wrote: > Il 21/10/22 12:48, Bo-Chen Chen ha scritto: > > To manager MediaTek system clock reset easier, we move the driver > > to > > drivers/reset/mediatek. > > > > - Create reset/mediatek folder. > > - Move clk/mediatek/reset.c to reset/mediatek/reset-mediatek- > > sysclk.c > > - Because we don't want to build in unsed static variable, we use > > clk > > KConfig to separate them. For example, when we use MT8186, we > > don't > > want to build in the static constants for MT8195. > > - Move reset data which are scattered around the mediatek drivers > > to > > reset-mtxxxx.c. > > - There are two version for mtk_reset_init because some mediatek > > clock > > drivers (mt8135 and mt8173) are using device_node instead of > > device, > > so we need to add two version for the init function. > > > > Suggested-by: Stephen Boyd > > Signed-off-by: Bo-Chen Chen > > --- > > drivers/clk/mediatek/Kconfig | 1 + > > drivers/clk/mediatek/Makefile | 2 +- > > drivers/clk/mediatek/clk-mt2701-eth.c | 10 +- > > drivers/clk/mediatek/clk-mt2701-g3d.c | 10 +- > > drivers/clk/mediatek/clk-mt2701-hif.c | 10 +- > > drivers/clk/mediatek/clk-mt2701.c | 22 +- > > drivers/clk/mediatek/clk-mt2712.c | 22 +- > > drivers/clk/mediatek/clk-mt6795-infracfg.c | 22 +- > > drivers/clk/mediatek/clk-mt6795-pericfg.c | 20 +- > > drivers/clk/mediatek/clk-mt7622-eth.c | 10 +- > > drivers/clk/mediatek/clk-mt7622-hif.c | 12 +- > > drivers/clk/mediatek/clk-mt7622.c | 22 +- > > drivers/clk/mediatek/clk-mt7629-eth.c | 10 +- > > drivers/clk/mediatek/clk-mt7629-hif.c | 12 +- > > drivers/clk/mediatek/clk-mt8135.c | 23 +- > > drivers/clk/mediatek/clk-mt8173.c | 22 +- > > drivers/clk/mediatek/clk-mt8183.c | 15 +- > > drivers/clk/mediatek/clk-mt8186-infra_ao.c | 23 +- > > drivers/clk/mediatek/clk-mt8192.c | 27 +- > > drivers/clk/mediatek/clk-mt8195-infra_ao.c | 28 +- > > drivers/clk/mediatek/clk-mtk.c | 5 +- > > drivers/clk/mediatek/clk-mtk.h | 5 +- > > drivers/clk/mediatek/reset.c | 233 ----------- > > drivers/reset/Kconfig | 1 + > > drivers/reset/Makefile | 1 + > > drivers/reset/mediatek/Kconfig | 5 + > > drivers/reset/mediatek/Makefile | 13 + > > .../reset/mediatek/reset-mediatek-sysclk.c | 388 > > ++++++++++++++++++ > > drivers/reset/mediatek/reset-mt2701.c | 102 +++++ > > drivers/reset/mediatek/reset-mt2712.c | 42 ++ > > drivers/reset/mediatek/reset-mt6795.c | 61 +++ > > drivers/reset/mediatek/reset-mt7622.c | 91 ++++ > > drivers/reset/mediatek/reset-mt7629.c | 62 +++ > > drivers/reset/mediatek/reset-mt8135.c | 43 ++ > > drivers/reset/mediatek/reset-mt8173.c | 43 ++ > > drivers/reset/mediatek/reset-mt8183.c | 31 ++ > > drivers/reset/mediatek/reset-mt8186.c | 39 ++ > > drivers/reset/mediatek/reset-mt8192.c | 43 ++ > > drivers/reset/mediatek/reset-mt8195.c | 44 ++ > > .../linux/reset/reset-mediatek-sysclk.h | 62 +-- > > 40 files changed, 1080 insertions(+), 557 deletions(-) > > delete mode 100644 drivers/clk/mediatek/reset.c > > create mode 100644 drivers/reset/mediatek/Kconfig > > create mode 100644 drivers/reset/mediatek/Makefile > > create mode 100644 drivers/reset/mediatek/reset-mediatek-sysclk.c > > create mode 100644 drivers/reset/mediatek/reset-mt2701.c > > create mode 100644 drivers/reset/mediatek/reset-mt2712.c > > create mode 100644 drivers/reset/mediatek/reset-mt6795.c > > create mode 100644 drivers/reset/mediatek/reset-mt7622.c > > create mode 100644 drivers/reset/mediatek/reset-mt7629.c > > create mode 100644 drivers/reset/mediatek/reset-mt8135.c > > create mode 100644 drivers/reset/mediatek/reset-mt8173.c > > create mode 100644 drivers/reset/mediatek/reset-mt8183.c > > create mode 100644 drivers/reset/mediatek/reset-mt8186.c > > create mode 100644 drivers/reset/mediatek/reset-mt8192.c > > create mode 100644 drivers/reset/mediatek/reset-mt8195.c > > rename drivers/clk/mediatek/reset.h => include/linux/reset/reset- > > mediatek-sysclk.h (59%) > > > > diff --git a/drivers/clk/mediatek/Kconfig > > b/drivers/clk/mediatek/Kconfig > > index 843cea0c7a44..e372f145eada 100644 > > --- a/drivers/clk/mediatek/Kconfig > > +++ b/drivers/clk/mediatek/Kconfig > > @@ -8,6 +8,7 @@ menu "Clock driver for MediaTek SoC" > > config COMMON_CLK_MEDIATEK > > tristate > > select RESET_CONTROLLER > > + select RESET_MEDIATEK_SYSCLK > > help > > MediaTek SoCs' clock support. > > > > ..snip.. > > > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > > index 3e7e5fd633a8..5cef7ccc9a7d 100644 > > --- a/drivers/reset/Makefile > > +++ b/drivers/reset/Makefile > > @@ -1,6 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0 > > obj-y += core.o > > obj-y += hisilicon/ > > +obj-y += mediatek/ > > I'd be more for > > obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ > > as there's no reason to even compile these if MTK support isn't > enabled at all. > Hello Angelo, thanks for your review. I obj-y += mediatek/ because if I don't write like this, it will build fail for x86. Is there any suggestion for this? /tmp/src_kernel/prebuilt/toolchain/0day/gcc/x86_64-linux/bin/x86_64- linux-ld: vmlinux.o: in function `mtk_pericfg_init': clk-mt8135.c:(.init.text+0x12a2b7): undefined reference to `mtk_reset_init_with_node' /tmp/src_kernel/prebuilt/toolchain/0day/gcc/x86_64-linux/bin/x86_64- linux-ld: vmlinux.o: in function `mtk_infrasys_init': clk-mt8135.c:(.init.text+0x12a3bb): undefined reference to `mtk_reset_init_with_node' /tmp/src_kernel/prebuilt/toolchain/0day/gcc/x86_64-linux/bin/x86_64- linux-ld: vmlinux.o: in function `mtk_infrasys_init': clk-mt8173.c:(.init.text+0x12ac47): undefined reference to `mtk_reset_init_with_node' /tmp/src_kernel/prebuilt/toolchain/0day/gcc/x86_64-linux/bin/x86_64- linux-ld: vmlinux.o: in function `mtk_pericfg_init': clk-mt8173.c:(.init.text+0x12ad25): undefined reference to `mtk_reset_init_with_node' /tmp/src_kernel/kernel/mediatek/scripts/Makefile.vmlinux:34: recipe for target 'vmlinux' failed make[3]: *** [vmlinux] Error 1 make[3]: Target '__default' not remade because of errors. /tmp/src_kernel/kernel/mediatek/Makefile:1236: recipe for target 'vmlinux' failed make[2]: *** [vmlinux] Error 2 make[2]: Target '__all' not remade because of errors. make[2]: Leaving directory '/tmp/out_kernel/out/allyesconfig.x86_64' Makefile:231: recipe for target '__sub-make' failed make[1]: *** [__sub-make] Error 2 make[1]: Target '__all' not remade because of errors. make[1]: Leaving directory '/tmp/src_kernel/kernel/mediatek' build/core/kbuild_test.mk:61: recipe for target 'all' failed make: *** [all] Error 2 [11:44:04] Error: failed to build allyesconfig.x86_64 > > obj-$(CONFIG_ARCH_STI) += sti/ > > obj-$(CONFIG_ARCH_TEGRA) += tegra/ > > obj-$(CONFIG_RESET_A10SR) += reset-a10sr.o > > diff --git a/drivers/reset/mediatek/Kconfig > > b/drivers/reset/mediatek/Kconfig > > new file mode 100644 > > index 000000000000..a416cb938753 > > --- /dev/null > > +++ b/drivers/reset/mediatek/Kconfig > > @@ -0,0 +1,5 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > Similarly, we should at this point also do.... > > if ARCH_MEDIATEK > > > +config RESET_MEDIATEK_SYSCLK > > + tristate "MediaTek System Clock Reset Driver" > > + help > > + This enables the system clock reset driver for MediaTek SoCs. > > endif # ARCH_MEDIATEK > > > diff --git a/drivers/reset/mediatek/Makefile > > b/drivers/reset/mediatek/Makefile > > new file mode 100644 > > index 000000000000..83f26c2cecdd > > --- /dev/null > > +++ b/drivers/reset/mediatek/Makefile > > @@ -0,0 +1,13 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +obj-$(CONFIG_RESET_MEDIATEK_SYSCLK) += reset-mediatek-sysclk.o > > +obj-$(CONFIG_COMMON_CLK_MT2701) += reset-mt2701.o > > +obj-$(CONFIG_COMMON_CLK_MT2712) += reset-mt2712.o > > +obj-$(CONFIG_COMMON_CLK_MT6795) += reset-mt6795.o > > +obj-$(CONFIG_COMMON_CLK_MT7622) += reset-mt7622.o > > +obj-$(CONFIG_COMMON_CLK_MT7629) += reset-mt7629.o > > +obj-$(CONFIG_COMMON_CLK_MT8135) += reset-mt8135.o > > +obj-$(CONFIG_COMMON_CLK_MT8173) += reset-mt8173.o > > +obj-$(CONFIG_COMMON_CLK_MT8183) += reset-mt8183.o > > +obj-$(CONFIG_COMMON_CLK_MT8186) += reset-mt8186.o > > +obj-$(CONFIG_COMMON_CLK_MT8192) += reset-mt8192.o > > +obj-$(CONFIG_COMMON_CLK_MT8195) += reset-mt8195.o > > diff --git a/drivers/reset/mediatek/reset-mediatek-sysclk.c > > b/drivers/reset/mediatek/reset-mediatek-sysclk.c > > new file mode 100644 > > index 000000000000..9cf115e66a4d > > --- /dev/null > > +++ b/drivers/reset/mediatek/reset-mediatek-sysclk.c > > ..snip.. > > > + > > +static struct mtk_rst_id mtk_sysclk_reset_ids[] = { > > ..snip.. > > > + { > > + .name = "mt2712-peri-rst", > > + .driver_data = MTK_RST_ID_MT2712_PERI, > > + }, > > + { > > + .name = "mt6795-ifa", > > Keep the names consistent please... "mt6795-infra-rst" > The reason I rename it as this because the limitation of name in struct auxiliary_device_id. It's 32. The KBUILD_MODNAME "clk_mt6795_infracfg" and "clk_mt6795_pericfg" is fixed, so I need to modify the device_name. refs: https://elixir.bootlin.com/linux/latest/source/include/linux/mod_devicetable.h#L854 > > + .driver_data = MTK_RST_ID_MT6795_INFRA, > > + }, > > + { > > + .name = "mt6795-peri", > > mt6795-peri-rst > > > + .driver_data = MTK_RST_ID_MT6795_PERI, > > + }, > > + { > > + .name = "mt7622-eth-rst", > > + .driver_data = MTK_RST_ID_MT7622_ETH, > > + }, > > + { > > + .name = "mt7622-usb-rst", > > + .driver_data = MTK_RST_ID_MT7622_SSUSBSYS, > > + }, > > + { > > + .name = "mt7622-pcie-rst", > > + .driver_data = MTK_RST_ID_MT7622_PCIESYS, > > + }, > > + { > > + .name = "mt7622-infrasys-rst", > > + .driver_data = MTK_RST_ID_MT7622_INFRASYS, > > + }, > > + { > > + .name = "mt7622-pericfg-rst", > > + .driver_data = MTK_RST_ID_MT7622_PERICFG, > > + }, > > + { > > + .name = "mt7629-ethsys-rst", > > + .driver_data = MTK_RST_ID_MT7629_ETHSYS, > > + }, > > + { > > + .name = "mt7629-usb-rst", > > + .driver_data = MTK_RST_ID_MT7629_SSUSBSYS, > > + }, > > + { > > + .name = "mt7629-pcie-rst", > > + .driver_data = MTK_RST_ID_MT7629_PCIESYS, > > + }, > > + { > > + .name = "clk_mt8135.mt8135-infrasys-rst", > > Why do we have this "clk_mt8135." prefix here (and also mt8173), when > all of > the others don't have any prefix? > > That's not consistent and shall be changed, unless there's a valid > reason not to. > I do this because in patch [3/3], other name will be added KBUILD_MODNAME and for 8135 and 8173, we can not use the aux bus interface because there is no have not device provided by them. > > + .driver_data = MTK_RST_ID_MT8135_INFRASYS, > > + }, > > + { > > + .name = "clk_mt8135.mt8135-pericfg-rst", > > + .driver_data = MTK_RST_ID_MT8135_PERICFG, > > + }, > > + { > > + .name = "clk_mt8173.mt8173-infracfg-rst", > > + .driver_data = MTK_RST_ID_MT8173_INFRACFG, > > + }, > > + { > > + .name = "clk_mt8173.mt8173-pericfg-rst", > > + .driver_data = MTK_RST_ID_MT8173_PERICFG, > > + }, > > + { > > + .name = "mt8183-infra-rst", > > + .driver_data = MTK_RST_ID_MT8183_INFRA, > > + }, > > + { > > + .name = "mt8186-infra-ao-rst", > > + .driver_data = MTK_RST_ID_MT8186_INFRA_AO, > > + }, > > + { > > + .name = "mt8192-infra-rst", > > + .driver_data = MTK_RST_ID_MT8192_INFRA, > > + }, > > + { > > + .name = "mt8195-infra-ao-rst", > > + .driver_data = MTK_RST_ID_MT8195_INFRA_AO, > > + }, > > + { > > + }, > > +}; > > + > > ..snip.. > > > + > > +int mtk_rst_register_clk_rst_data(u32 index, struct > > mtk_clk_rst_data *data) > > +{ > > + if (index >= MTK_RST_ID_MAX) > > + return -EINVAL; > > + > > + p_clk_rst_data[index] = data; > > + > > + pr_info("%s, register mediatek sysclock reset(%d).\n", > > __func__, index); > > Is this really informative? > There's sysfs telling you infos about drivers that has been (or > hasn't been yet) > registered... so, please change that to a pr_debug() instead. > ok, I will do this. BRs, Bo-Chen > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(mtk_rst_register_clk_rst_data); > > + > > Apart from that, looks good. > > Regards, > Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel