* [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
@ 2023-11-19 11:28 Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, intel-gfx
Cc: linux-i2c, Heiner Kallweit, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
v2:
- change tag in commit subject of patch 03
- add ack tags
v3:
- fix a compile error in patch 5
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
drivers/gpu/drm/ast/ast_i2c.c | 1 -
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
drivers/gpu/drm/display/drm_dp_helper.c | 1 -
drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
drivers/video/fbdev/core/fb_ddc.c | 1 -
drivers/video/fbdev/cyber2000fb.c | 1 -
drivers/video/fbdev/i740fb.c | 1 -
drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
drivers/video/fbdev/s3fb.c | 1 -
drivers/video/fbdev/tdfxfb.c | 1 -
drivers/video/fbdev/tridentfb.c | 1 -
drivers/video/fbdev/via/via_i2c.c | 1 -
include/linux/i2c.h | 1 -
31 files changed, 9 insertions(+), 47 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
@ 2023-11-19 11:28 ` Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, Sandy Huang
Cc: linux-i2c, Heiner Kallweit, Heiko Stübner, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter,
dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 6e5b922a1..a7739b27c 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi)
init_completion(&i2c->cmp);
adap = &i2c->adap;
- adap->class = I2C_CLASS_DDC;
adap->owner = THIS_MODULE;
adap->dev.parent = hdmi->dev;
adap->dev.of_node = hdmi->dev->of_node;
diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
index fa6e592e0..7a3f71aa2 100644
--- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
+++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
@@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi)
init_completion(&i2c->cmpltn);
adap = &i2c->adap;
- adap->class = I2C_CLASS_DDC;
adap->owner = THIS_MODULE;
adap->dev.parent = hdmi->dev;
adap->dev.of_node = hdmi->dev->of_node;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
@ 2023-11-19 11:28 ` Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, Maxime Ripard
Cc: linux-i2c, Heiner Kallweit, Chen-Yu Tsai, Maarten Lankhorst,
Thomas Zimmermann, David Airlie, Daniel Vetter, Jernej Skrabec,
Samuel Holland, dri-devel, linux-arm-kernel, linux-sunxi,
linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
index d1a65a921..f5f62eb0e 100644
--- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
+++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
@@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi)
return -ENOMEM;
adap->owner = THIS_MODULE;
- adap->class = I2C_CLASS_DDC;
adap->algo = &sun4i_hdmi_i2c_algorithm;
strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name));
i2c_set_adapdata(adap, hdmi);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
@ 2023-11-19 11:28 ` Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, Russell King
Cc: linux-i2c, Heiner Kallweit, Helge Deller, linux-arm-kernel,
linux-fbdev, dri-devel, linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/video/fbdev/cyber2000fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
index 52105dc1a..79775deda 100644
--- a/drivers/video/fbdev/cyber2000fb.c
+++ b/drivers/video/fbdev/cyber2000fb.c
@@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb)
strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id,
sizeof(cfb->ddc_adapter.name));
cfb->ddc_adapter.owner = THIS_MODULE;
- cfb->ddc_adapter.class = I2C_CLASS_DDC;
cfb->ddc_adapter.algo_data = &cfb->ddc_algo;
cfb->ddc_adapter.dev.parent = cfb->fb.device;
cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
` (2 preceding siblings ...)
2023-11-19 11:28 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
@ 2023-11-19 11:28 ` Heiner Kallweit
2023-11-20 13:56 ` AngeloGioacchino Del Regno
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
4 siblings, 1 reply; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, Chun-Kuang Hu
Cc: linux-i2c, Heiner Kallweit, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, AngeloGioacchino Del Regno,
dri-devel, linux-mediatek, linux-kernel, linux-arm-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index d675c954b..54e46e440 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name));
ddc->adap.owner = THIS_MODULE;
- ddc->adap.class = I2C_CLASS_DDC;
ddc->adap.algo = &mtk_hdmi_ddc_algorithm;
ddc->adap.retries = 3;
ddc->adap.dev.of_node = dev->of_node;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
` (3 preceding siblings ...)
2023-11-19 11:28 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
@ 2023-11-19 20:28 ` Helge Deller
2023-11-19 20:48 ` Heiner Kallweit
4 siblings, 1 reply; 10+ messages in thread
From: Helge Deller @ 2023-11-19 20:28 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 11/19/23 12:28, Heiner Kallweit wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
The fbdev changes look at least ok so far, so:
Acked-by: Helge Deller <deller@gmx.de> #fbdev
> v2:
> - change tag in commit subject of patch 03
> - add ack tags
> v3:
> - fix a compile error in patch 5
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> drivers/gpu/drm/ast/ast_i2c.c | 1 -
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
> drivers/video/fbdev/core/fb_ddc.c | 1 -
> drivers/video/fbdev/cyber2000fb.c | 1 -
> drivers/video/fbdev/i740fb.c | 1 -
> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
> drivers/video/fbdev/s3fb.c | 1 -
> drivers/video/fbdev/tdfxfb.c | 1 -
> drivers/video/fbdev/tridentfb.c | 1 -
> drivers/video/fbdev/via/via_i2c.c | 1 -
> include/linux/i2c.h | 1 -
> 31 files changed, 9 insertions(+), 47 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
@ 2023-11-19 20:48 ` Heiner Kallweit
2023-11-19 20:51 ` Heiner Kallweit
0 siblings, 1 reply; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 20:48 UTC (permalink / raw)
To: Helge Deller, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 19.11.2023 21:28, Helge Deller wrote:
> On 11/19/23 12:28, Heiner Kallweit wrote:
>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>> Class-based device auto-detection is a legacy mechanism and shouldn't
>> be used in new code. So we can remove this class completely now.
>>
>> Preferably this series should be applied via the i2c tree.
>
> The fbdev changes look at least ok so far, so:
> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>
I think this refers to patch 5 of the series. Could you please reply
to patch 5 instead of the cover letter with your acked-by so that
patchwork gets it right? Thanks!
>
>> v2:
>> - change tag in commit subject of patch 03
>> - add ack tags
>> v3:
>> - fix a compile error in patch 5
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>> ---
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>> drivers/video/fbdev/cyber2000fb.c | 1 -
>> drivers/video/fbdev/i740fb.c | 1 -
>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>> drivers/video/fbdev/s3fb.c | 1 -
>> drivers/video/fbdev/tdfxfb.c | 1 -
>> drivers/video/fbdev/tridentfb.c | 1 -
>> drivers/video/fbdev/via/via_i2c.c | 1 -
>> include/linux/i2c.h | 1 -
>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:48 ` Heiner Kallweit
@ 2023-11-19 20:51 ` Heiner Kallweit
2023-11-19 21:51 ` Helge Deller
0 siblings, 1 reply; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-19 20:51 UTC (permalink / raw)
To: Helge Deller, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 19.11.2023 21:48, Heiner Kallweit wrote:
> On 19.11.2023 21:28, Helge Deller wrote:
>> On 11/19/23 12:28, Heiner Kallweit wrote:
>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>> be used in new code. So we can remove this class completely now.
>>>
>>> Preferably this series should be applied via the i2c tree.
>>
>> The fbdev changes look at least ok so far, so:
>> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>>
> I think this refers to patch 5 of the series. Could you please reply
> to patch 5 instead of the cover letter with your acked-by so that
> patchwork gets it right? Thanks!
>
Sorry, just looked at where you are in To, not Cc.
So your ack includes patches 6, 9, 10, 13?
>>
>>> v2:
>>> - change tag in commit subject of patch 03
>>> - add ack tags
>>> v3:
>>> - fix a compile error in patch 5
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> ---
>>>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>> drivers/video/fbdev/i740fb.c | 1 -
>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>> drivers/video/fbdev/s3fb.c | 1 -
>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>> drivers/video/fbdev/tridentfb.c | 1 -
>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>> include/linux/i2c.h | 1 -
>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:51 ` Heiner Kallweit
@ 2023-11-19 21:51 ` Helge Deller
0 siblings, 0 replies; 10+ messages in thread
From: Helge Deller @ 2023-11-19 21:51 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 11/19/23 21:51, Heiner Kallweit wrote:
> On 19.11.2023 21:48, Heiner Kallweit wrote:
>> On 19.11.2023 21:28, Helge Deller wrote:
>>> On 11/19/23 12:28, Heiner Kallweit wrote:
>>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>>> be used in new code. So we can remove this class completely now.
>>>>
>>>> Preferably this series should be applied via the i2c tree.
>>>
>>> The fbdev changes look at least ok so far, so:
>>> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>>>
>> I think this refers to patch 5 of the series. Could you please reply
>> to patch 5 instead of the cover letter with your acked-by so that
>> patchwork gets it right? Thanks!
>>
> Sorry, just looked at where you are in To, not Cc.
> So your ack includes patches 6, 9, 10, 13?
Yes.
Helge
>>>
>>>> v2:
>>>> - change tag in commit subject of patch 03
>>>> - add ack tags
>>>> v3:
>>>> - fix a compile error in patch 5
>>>>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>
>>>> ---
>>>>
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>>> drivers/video/fbdev/i740fb.c | 1 -
>>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>>> drivers/video/fbdev/s3fb.c | 1 -
>>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>>> drivers/video/fbdev/tridentfb.c | 1 -
>>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>>> include/linux/i2c.h | 1 -
>>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>>
>>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
@ 2023-11-20 13:56 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-20 13:56 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, Chun-Kuang Hu
Cc: linux-i2c, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel,
linux-arm-kernel
Il 19/11/23 12:28, Heiner Kallweit ha scritto:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-11-20 13:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-20 13:56 ` AngeloGioacchino Del Regno
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
2023-11-19 20:48 ` Heiner Kallweit
2023-11-19 20:51 ` Heiner Kallweit
2023-11-19 21:51 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox