From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Albert Ou <aou@eecs.berkeley.edu>,
asahi@lists.linux.dev, David Woodhouse <dwmw2@infradead.org>,
Heiko Stuebner <heiko@sntech.de>,
iommu@lists.linux.dev, Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joerg Roedel <joro@8bytes.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-tegra@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hector Martin <marcan@marcan.st>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Robin Murphy <robin.murphy@arm.com>,
Samuel Holland <samuel@sholland.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Sven Peter <sven@svenpeter.dev>,
Thierry Reding <thierry.reding@gmail.com>,
Tomasz Jeznach <tjeznach@rivosinc.com>,
Krishna Reddy <vdumpa@nvidia.com>, Chen-Yu Tsai <wens@csie.org>,
Will Deacon <will@kernel.org>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Joerg Roedel <jroedel@suse.de>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
patches@lists.linux.dev, David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 08/23] iommu/vtd: Use virt_to_phys()
Date: Sat, 15 Feb 2025 16:49:34 +0800 [thread overview]
Message-ID: <bd54b742-16c8-4b55-95cb-5cb6847cec07@linux.intel.com> (raw)
In-Reply-To: <8-v2-545d29711869+a76b5-iommu_pages_jgg@nvidia.com>
On 2/15/25 01:07, Jason Gunthorpe wrote:
> If all the inlines are unwound virt_to_dma_pfn() is simply:
> return page_to_pfn(virt_to_page(p)) << (PAGE_SHIFT - VTD_PAGE_SHIFT);
>
> Which can be re-arranged to:
> (page_to_pfn(virt_to_page(p)) << PAGE_SHIFT) >> VTD_PAGE_SHIFT
>
> The only caller is:
> ((uint64_t)virt_to_dma_pfn(tmp_page) << VTD_PAGE_SHIFT)
>
> re-arranged to:
> ((page_to_pfn(virt_to_page(tmp_page)) << PAGE_SHIFT) >> VTD_PAGE_SHIFT) << VTD_PAGE_SHIFT
>
> Which simplifies to:
> page_to_pfn(virt_to_page(tmp_page)) << PAGE_SHIFT
>
> That is the same as virt_to_phys(tmp_page), so just remove all of this.
>
> Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
next prev parent reply other threads:[~2025-02-15 8:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 17:07 [PATCH v2 00/23] iommu: Further abstract iommu-pages Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 01/23] iommu/terga: Do not use struct page as the handle for as->pd memory Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 02/23] iommu/tegra: Do not use struct page as the handle for pts Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 03/23] iommu/pages: Remove __iommu_alloc_pages()/__iommu_free_pages() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 04/23] iommu/pages: Make iommu_put_pages_list() work with high order allocations Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 05/23] iommu/pages: Remove the order argument to iommu_free_pages() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 06/23] iommu/pages: Remove iommu_free_page() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 07/23] iommu/pages: De-inline the substantial functions Jason Gunthorpe
2025-02-15 8:48 ` Baolu Lu
2025-02-18 20:19 ` Jason Gunthorpe
2025-02-19 2:56 ` Baolu Lu
2025-02-14 17:07 ` [PATCH v2 08/23] iommu/vtd: Use virt_to_phys() Jason Gunthorpe
2025-02-15 8:49 ` Baolu Lu [this message]
2025-02-14 17:07 ` [PATCH v2 09/23] iommu/pages: Formalize the freelist API Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 10/23] iommu/riscv: Convert to use struct iommu_pages_list Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 11/23] iommu/amd: " Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 12/23] iommu: Change iommu_iotlb_gather to use iommu_page_list Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 13/23] iommu/pages: Remove iommu_put_pages_list_old and the _Generic Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 14/23] iommu/pages: Move from struct page to struct ioptdesc and folio Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 15/23] iommu/pages: Move the __GFP_HIGHMEM checks into the common code Jason Gunthorpe
2025-02-15 9:10 ` Baolu Lu
2025-02-14 17:07 ` [PATCH v2 16/23] iommu/pages: Allow sub page sizes to be passed into the allocator Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 17/23] iommu/amd: Change rlookup, irq_lookup, and alias to use kvalloc() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 18/23] iommu/amd: Use roundup_pow_two() instead of get_order() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 19/23] iommu/riscv: Update to use iommu_alloc_pages_node_lg2() Jason Gunthorpe
2025-02-20 19:35 ` Tomasz Jeznach
2025-02-14 17:07 ` [PATCH v2 20/23] iommu: Update various drivers to pass in lg2sz instead of order to iommu pages Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 21/23] iommu/pages: Remove iommu_alloc_page/pages() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 22/23] iommu/pages: Remove iommu_alloc_page_node() Jason Gunthorpe
2025-02-14 17:07 ` [PATCH v2 23/23] iommu/pages: Remove iommu_alloc_pages_node() Jason Gunthorpe
2025-02-15 9:47 ` Baolu Lu
2025-02-18 20:21 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd54b742-16c8-4b55-95cb-5cb6847cec07@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alim.akhtar@samsung.com \
--cc=alyssa@rosenzweig.io \
--cc=aou@eecs.berkeley.edu \
--cc=asahi@lists.linux.dev \
--cc=bagasdotme@gmail.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marcan@marcan.st \
--cc=palmer@dabbelt.com \
--cc=pasha.tatashin@soleen.com \
--cc=patches@lists.linux.dev \
--cc=paul.walmsley@sifive.com \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=tjeznach@rivosinc.com \
--cc=vdumpa@nvidia.com \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).