From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72B14C25B47 for ; Wed, 25 Oct 2023 07:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oiz8Gpvp7Z4SfrzX3FluryxUGHccKeWZV1xMk1th/Jg=; b=vK/tHwn82Gz5gD tOsuMpm5cv34qCfgTyQxfy/finPavnrUIuOLhBBvjWTieeG5cVoR1IllgN5QV/W74BEa5gHJI+2eV h7iuqVUrbSt6Gy76wAMNGB1AIfuKufxoj8J+WkPBwmtilppOOgVKM9vDwKld3NB0Ub11IXY7FlTrp CWQ+jFqS4tVytvIbhvJdcVYa6DXF7YEiZZE5FJT9Lrt8xRbX9dxPl1ZVoTuST5Gfs/x8JkRjPEJDD n59jD6umnqIskVJDbnHklzP9ZI2WostXqWljJPjc1bgla8QuuVDAoIATElb1SpRWXTEOkBvrU5WbO 29RxjAvMrSEr2WY51MLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvY26-00BXnd-0I; Wed, 25 Oct 2023 07:10:26 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvY23-00BXmD-03 for linux-arm-kernel@lists.infradead.org; Wed, 25 Oct 2023 07:10:24 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so74555851fa.3 for ; Wed, 25 Oct 2023 00:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698217812; x=1698822612; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O/a2enGvtc1HJJcrsQxtyTV+TZ4Dj/K1d5FQy70Je18=; b=k7h3+x+p8FEc2o1VqV5ktOSykGfPzhYog1WwOFj1dTlx4KuY/w44A8C9lFEFZTEXQG gvtgsjDXmd9yz066FInl7NKxlmjV3CIcVE78zW8UAKKTevzcNhno1LQWbMJxex60URmg 3j+2CYlPsN1yN4fsLlUJX5mhmM+Ga+MxUqhBaDZoPE0OngePwd/ko+47UGT4Boi/TVl4 pivkClLnPqojkVwrHnWUxiff6MtFXaSaPwx9nOLjfOkOl0sz6DMp2KBi7H/E1HUY7V9Q 8lkERqvO8OueADjrGinytsFodxuy+OIN6/GUfA6Xuvwmi53Unih5sMrl/j8+3CDYXhhe hVEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698217812; x=1698822612; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O/a2enGvtc1HJJcrsQxtyTV+TZ4Dj/K1d5FQy70Je18=; b=IEOvq7gq5H6CFohXciqhA16Tuvn3KWwE8ux0wTwpz2I34IGBEFbw6MW98rBFTRSIg5 mr3FweVslPe6e+LkrBmJTjbpZlWH+zVqkZEzOUe1XfaGMcHJ7a0fLUstbdRdcOFr/DBi +fNb4Mg6M4k6tuZER2Zqle8jknUqZBksPPbGxQnPPoyWsTSz5MDIvYOcTTrvkElWdVce ww3sDsA7D4tBC1oitL3cp5Vdfg4aZpgP7Cntqy2wJ8CeCfBS8XPUNGft5hnvXMWeCsdo ICQFYTfZ/Yk4qthzwbz44XuWtzfkU1w5nyDcmvTbg1/V4uALQE5WKIhq8/7+pOXL92MO CKsw== X-Gm-Message-State: AOJu0YwGafSwYHoAQCWkTIbN3hjAdcuOqKIKmj9ZqJv6s0IrLHrw8yh5 CQwwWISDecZC8bNJrGkOlSPW/w== X-Google-Smtp-Source: AGHT+IFrjhPdd6vWCM5twqWe8Gx1vQOZe4ftjHiARiD5M6kbpwMjDkRu3Y6/bbkfib0ftOWckR13og== X-Received: by 2002:a2e:350e:0:b0:2c5:1c4:9005 with SMTP id z14-20020a2e350e000000b002c501c49005mr9520358ljz.32.1698217812468; Wed, 25 Oct 2023 00:10:12 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n13-20020a05600c3b8d00b004053e9276easm18734063wms.32.2023.10.25.00.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 00:10:12 -0700 (PDT) Date: Wed, 25 Oct 2023 10:10:08 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , "Ricardo B . Marliere" , Sakari Ailus Subject: Re: [PATCH 1/1] staging: vc04_services: Use %p4cc format modifier to print FourCC codes Message-ID: References: <20231025060717.71895-1-umang.jain@ideasonboard.com> <20231025060717.71895-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231025060717.71895-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_001023_050193_D0EEDA78 X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 25, 2023 at 02:07:17AM -0400, Umang Jain wrote: > Drop VCHIQ_FOURCC_AS_4CHARS macro in favour of %p4cc format > modifier to print FourCC codes in the logs. > > vchiq_use_internal() and vchiq_release_internal() uses entity > character-array to store a transient string that contains > a FourCC code. Increase the length of entity array(to 64 bytes) > since %p4cc requires more bytes to hold the output characters. > > Suggested-by: Kieran Bingham > Signed-off-by: Umang Jain > --- > .../interface/vchiq_arm/vchiq_arm.c | 20 +++++----- > .../interface/vchiq_arm/vchiq_core.c | 40 +++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 6 --- > .../interface/vchiq_arm/vchiq_dev.c | 7 ++-- > 4 files changed, 33 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index fc6d33ec5e95..de6a24304a4d 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1441,7 +1441,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, > { > struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state); > int ret = 0; > - char entity[16]; > + char entity[64]; > int *entity_uc; > int local_uc; > > @@ -1454,8 +1454,8 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, > sprintf(entity, "VCHIQ: "); > entity_uc = &arm_state->peer_use_count; > } else if (service) { > - sprintf(entity, "%c%c%c%c:%03d", > - VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), > + sprintf(entity, "%p4cc:%03d", Not related to your patch but these sprintfs() make me very uncomfortable. KTODO: change sprintf() to snprintf() in staging/vc04_services/ regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel