From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31091CA0FF6 for ; Mon, 4 Sep 2023 19:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rm7uQFTZAPXGik/KBur2HOzr5YPAZ+/2kIRfX3R5w2s=; b=fz8v7OZDSdaPhN azKLcYw/PRYklwIxyMIZOaVYX81+8LP1kEYwvplPSsc2P8HWjOPaCY04xuYUUskqMjfeuMrpsIMLq 7v1gcgbcpfaFMehqUq/nRghDek/yEaaquH6wiY9ukHDFYsyUpyrcpHHJlgXa9lz0TduXAfCGbewSe aydqf+7Flo+4MWFzVbbJkkANcxU7gNspPPTBzPkhai679o4RNjGqmD94pjD1vmP5y9KmgY35UMOhb 0Kz5EaIQP+zz+kG+Dd880XYcrrX05asiwUMGGHQ5pZT1G2M2sWUy4qGn3MVg326DHW+Lu/tpHBlF3 vE9fLS7cQ5GHLyzvT65Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdFJd-004hcG-1b; Mon, 04 Sep 2023 19:32:53 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdFJa-004hbg-1X for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 19:32:51 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-52e64bc7c10so30145a12.1 for ; Mon, 04 Sep 2023 12:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693855967; x=1694460767; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JZ6H5M4q548gV0CNQehrzM4g+Qp6ZkTiIwLgzPLmdrE=; b=dMawyBe9DR6HM2LFXIRtdFt+bhwYTkYH6BU1Z4hWvwwCAnUlJKiEHyGW27dEjPi4D7 y/PQBuA0x/UIRLlTXu3xR9LbYhn/L6zNsdlyewcmV8ek9wjLE0yhNZK3p85fZ/E4ree4 dzZK8A0gtadsGzsA0+DbfOxYtDAVpNd7zKDeR9ifwQXsD87wdmDhMeq8CqAdsBAEMh2D kh6BvRG4Mrileqrn10dYrpJZ+yddnp4K/0SCbAeOUxR9gNMMrXiZMnQBw7n8Vlw7W7Tl uwD9kA8lE4a9rJNt++IV7byr1/0rT92NtZX9pd8PutbsqQo8Fx6tYKOLWjVjhZpsF0p0 ZCbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693855967; x=1694460767; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JZ6H5M4q548gV0CNQehrzM4g+Qp6ZkTiIwLgzPLmdrE=; b=FUy5SmoUwyZoJR47/hkJUKQwhAJZAB4ct3DomGHaXIO2j0sfoTMvQiOFeAI9jgecgx bJsr7FHl3naUSdL5IiPPvmAqPTh6gJoKnafsioo2MvjlZ8sJGovx5dwx4E6vVjcwQ0gX Id3aRIwTgj8l/8AXWt9NVm1FYjURRNL013nVOOasRtOzSEBc6KQpKnyV3eHEC4yDKzji svKBmFV/qQvXBqEFyGwsXI9L6YS71G7xWL5eGDtzHQOnBM7aOpx97Nm5ZzWVs1Ti2hMI SFKEOIDYx6m79cgE5O4sRfadDPlq1wXHo1d5SFL+KddjZ7S1mi0vYEm+4RciIvMc7b/v pIdA== X-Gm-Message-State: AOJu0YwXUy8sL7uGfiRC/P7h3DVPSRH16GFlFYGiTqKP3tqk+jo42ji1 inQvQj6LxRpl9yillHeK/jRfJw== X-Google-Smtp-Source: AGHT+IH0xh+QO8RhaNAVW0WGOeQOxfC0ae3lGMMNGhE9JO1OTC8YPy5jmTHCLOWkkmmbswgc2wghsw== X-Received: by 2002:a17:907:b12:b0:9a1:aea2:d18d with SMTP id h18-20020a1709070b1200b009a1aea2d18dmr7710392ejl.48.1693855966844; Mon, 04 Sep 2023 12:32:46 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id qc8-20020a170906d8a800b009a5f7fb51dcsm6480287ejb.42.2023.09.04.12.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 12:32:46 -0700 (PDT) Message-ID: Date: Mon, 4 Sep 2023 21:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616 Content-Language: en-US From: Krzysztof Kozlowski To: Martin Botka , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-3-b8842e525c43@somainline.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_123250_523248_5DF10560 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/09/2023 21:31, Krzysztof Kozlowski wrote: > On 04/09/2023 17:57, Martin Botka wrote: >> We need to add compatible for H616 to H6 cpufreq driver bindings. > > Please describe the hardware, not what is needed for drivers. > >> >> Also enable opp_supported_hw property that will be needed for H616. >> >> Signed-off-by: Martin Botka >> --- >> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >> index 51f62c3ae194..2fa1199f2d23 100644 >> --- a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >> +++ b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >> @@ -23,7 +23,10 @@ allOf: >> >> properties: >> compatible: >> - const: allwinner,sun50i-h6-operating-points >> + contains: > > This does not look like part of allOf, so contains is no correct here. > This must be specific, so drop contains. BTW, I also do no see it used by the driver at all. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel