From: Stephen Boyd <sboyd@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>, mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Michael Turquette <mturquette@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 11/27] kbuild, clk: bcm2835: remove MODULE_LICENSE in non-modules
Date: Wed, 22 Feb 2023 15:43:40 -0800 [thread overview]
Message-ID: <bdac18adf87f3b03104c16b7c0caaf8a.sboyd@kernel.org> (raw)
In-Reply-To: <20230222121453.91915-12-nick.alcock@oracle.com>
Quoting Nick Alcock (2023-02-22 04:14:37)
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-rpi-kernel@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
Unless you want me to pick this up?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-22 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 02/27] kbuild, video: fbdev: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 04/27] kbuild, soc: bcm: raspberrypi-power: " Nick Alcock
2023-02-24 21:26 ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 05/27] kbuild, soc: bcm: bcm2835-power: " Nick Alcock
2023-02-24 21:26 ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 06/27] kbuild, pinctrl: bcm: ns: " Nick Alcock
2023-02-22 12:14 ` [PATCH 08/27] kbuild, clocksource: " Nick Alcock
2023-02-22 12:14 ` [PATCH 11/27] kbuild, clk: bcm2835: " Nick Alcock
2023-02-22 23:43 ` Stephen Boyd [this message]
2023-02-23 1:36 ` Luis Chamberlain
2023-03-06 19:29 ` Stephen Boyd
2023-02-22 12:14 ` [PATCH 19/27] kbuild, dmaengine: stm32-mdma: " Nick Alcock
2023-02-22 12:14 ` [PATCH 27/27] kbuild, gpio: gpio-aspeed-sgpio: " Nick Alcock
2023-03-06 9:59 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdac18adf87f3b03104c16b7c0caaf8a.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nick.alcock@oracle.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).