From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fabio Estevam <festevam@gmail.com>, broonie@kernel.org
Cc: linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br,
heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] spi: dt-bindings: spi-peripheral-props: Document spi-cpha and spi-cpol
Date: Sat, 31 Aug 2024 08:26:15 +0200 [thread overview]
Message-ID: <be44add4-1fe8-4cc6-ba0d-7f82b09447f2@kernel.org> (raw)
In-Reply-To: <20240829201315.3412759-1-festevam@gmail.com>
On 29/08/2024 22:13, Fabio Estevam wrote:
> The 'spi-cpha' and 'spi-cpol' are commonly used SPI peripheral
> properties that indicate the device clock phase and polarity.
>
> Document these properties.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> index 0bb443b8decd..b2e2717f3619 100644
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> @@ -29,6 +29,16 @@ properties:
> description:
> Chip select used by the device.
>
> + spi-cpha:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + The device data is sampled on trailing (last) edge of the SPI clock.
> +
> + spi-cpol:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + The device clock has a falling lead (first) edge.
That would be a revert of earlier commit without explanation why such
revert is needed. :(
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-31 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:13 [PATCH 1/2] spi: dt-bindings: spi-peripheral-props: Document spi-cpha and spi-cpol Fabio Estevam
2024-08-29 20:13 ` [PATCH 2/2] dt-bindings: trivial-devices: Add a reference to spi-peripheral-props.yaml Fabio Estevam
2024-08-30 14:14 ` Conor Dooley
2024-08-30 15:05 ` Fabio Estevam
2024-08-30 15:17 ` Conor Dooley
2024-08-30 18:05 ` Rob Herring
2024-08-30 18:24 ` Conor Dooley
2024-08-31 6:32 ` Krzysztof Kozlowski
2024-08-30 14:11 ` [PATCH 1/2] spi: dt-bindings: spi-peripheral-props: Document spi-cpha and spi-cpol Conor Dooley
2024-08-31 6:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be44add4-1fe8-4cc6-ba0d-7f82b09447f2@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).