From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B104CC04FF9 for ; Mon, 15 Apr 2024 19:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pb1TY2/vrBqNqK8Yc5Ez3+1QD4R1LY7y80/7sSOIx7M=; b=zfYXLBcVsccb1I 4iuPfV0MykddWat7nxkGYWdnUuGB7U5B9X2S9hDPbUv0mLc8eshoH2hyReTJbMxOuCD/wjGLXW6MW Vw1RFiBNYgslPKpOhLKRxziWJrQKbCeMFRSbzwEuJNGh+i1O+9tUxZpJitxA5O3+qXoqx7P0cOVe+ LoosMd3A2I/BEKOndqa8/R3WCDiIJWLtgWkBeqvoj/6kYRRDLwdC+uovuqXt/2VXGKGeIjQM001Jl gbua+IsTnNhkHaNszxAVTsOgPH9UR007JsRm0lRLWEifPhKYyzFnB5F/giViWYT6NrIuwYcDyP9pz wKVX42gcCOv9OP1rkQ3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSE7-00000009gXu-1Gza; Mon, 15 Apr 2024 19:42:51 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSE3-00000009gWY-29xz for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:42:48 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-516d3a470d5so4180611e87.3 for ; Mon, 15 Apr 2024 12:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713210166; x=1713814966; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pel4IuSMXhoiMO3e3jJODv6FFXqtNPQdDIe5/vhiNjE=; b=f7GWoU8hE1RZ2v9mAr04QtjCDwmxRduisg2I/txhUhUO9gNJsb/BQg+IkRbN/Ymm+2 hCCR8EUHN8S+JQcjCOHAXfWuPEkLd7nv9t+qQXSM/QavsklUizOIaacWaQB9+Q6Eusps U/7fNNXsnfqBitfq4vaK67jWc5BR69wzylzV49WUE789LxoUTcZyW66rMhgoNtuyrJW0 PaPOZ5tkqzv3wvSNu/MakQtbF7VQj30ox1mvgbmGETITGak8Cpnjzv8dhkMhG/5u7odz 0ffOP+Bq7hCyC3keS443AUuiTi8H/bEEnprwWGUR3Y/y9Aqo9iwkvlJ1t1wSS5pTKqEh Q3HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713210166; x=1713814966; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pel4IuSMXhoiMO3e3jJODv6FFXqtNPQdDIe5/vhiNjE=; b=QUB9Ko+1POdvbRQ2X19fS63PMy+6iPCTUdWkYbpAUYkbGjw+lSVeyeGurKaNHjbfI4 hmg63e6XhG7ssNmz+C99TTzL0wcoEyiDa3us+eLynMp0m5L5xqcTi2EmMvGWrk/QvsBc YuWAFORgfDWCTAxt0LvDJytRtiTm0RMJsnuxODTWUjxOdlUHgQDPOy17Zj3ejbcJBPVF epjzCESyQ0FsezmEczfW3Px9Wo0Ev7x0TEfnL66n4pczIddRAwgb6eF0Ewqp7fGL501Y iLvROh8ebC6l3EF7LnUWayd03ahe85W1DHSzzdxSg+vJeFLzC64d0IafzZy2ekHAWOBe NUTw== X-Forwarded-Encrypted: i=1; AJvYcCUEKS3jd2HW9ddElRl4N07FDzfZ2I7Q2NrEaobp/hyNN9bzQnj5r9e84AsRCK0nNVpNPA1fJmb+ls8U7AB9D7fG+gT4Nuu9vG6GYDwjK7EFACjISH4= X-Gm-Message-State: AOJu0YysMnexZMOKnIIlUxDV1P8nttzlLS26qY5L0YFjvbsJMfy7CQf9 n7At1DUHWRMwKvIFWDvKFevY1OIOqBXwjQdoBQcMVlbJl3hpQ0EK2G1+ZUNds1E= X-Google-Smtp-Source: AGHT+IGjEnRycaBaSeP36Mt4IjxeEF3ElKi4vzIgUYlEGvDUqVdK0yPDppZzA2T8o+u/CJIaTfH0/g== X-Received: by 2002:ac2:4144:0:b0:519:231:e4c0 with SMTP id c4-20020ac24144000000b005190231e4c0mr1585142lfi.43.1713210165791; Mon, 15 Apr 2024 12:42:45 -0700 (PDT) Received: from [172.30.205.18] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id o21-20020ac24355000000b00516cba5b4cesm1334507lfl.46.2024.04.15.12.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 12:42:45 -0700 (PDT) Message-ID: Date: Mon, 15 Apr 2024 21:42:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Add PSCI SYSTEM_RESET2 types for qcm6490-idp To: Elliot Berman , Dmitry Baryshkov Cc: Bjorn Andersson , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andy Yan , Lorenzo Pieralisi , Mark Rutland , Bartosz Golaszewski , Satya Durga Srinivasu Prabhala , Melody Olvera , Shivendra Pratap , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240414-arm-psci-system_reset2-vendor-reboots-v2-0-da9a055a648f@quicinc.com> <20240414-arm-psci-system_reset2-vendor-reboots-v2-4-da9a055a648f@quicinc.com> <20240414173158942-0700.eberman@hu-eberman-lv.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240414173158942-0700.eberman@hu-eberman-lv.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_124247_593760_A4551887 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/24 02:32, Elliot Berman wrote: > On Mon, Apr 15, 2024 at 02:13:29AM +0300, Dmitry Baryshkov wrote: >> On Sun, 14 Apr 2024 at 22:32, Elliot Berman wrote: >>> >>> Add nodes for the vendor-defined system resets. "bootloader" will cause >>> device to reboot and stop in the bootloader's fastboot mode. "edl" will >>> cause device to reboot into "emergency download mode", which permits >>> loading images via the Firehose protocol. >>> >>> Co-developed-by: Shivendra Pratap >>> Signed-off-by: Shivendra Pratap >>> Signed-off-by: Elliot Berman >>> --- >>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> index e4bfad50a669..a966f6c8dd7c 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> @@ -126,6 +126,11 @@ debug_vm_mem: debug-vm@d0600000 { >>> }; >>> }; >>> >>> + psci { >> >> Please use a label instead. Otherwise it looks as if you are adding >> new device node. >> > > Right. Fixed for the next revision. Are you guys planning to make this sorta ABI-like? If so (which would be greatly appreciated by the way..), perhaps you could stick these magic values in dt-bindings and give them cool names FWIW DEN0022 (my second-favorite book) suggests these values are almost totally vendor-defined, so if I were Qualcomm, I'd take the creative liberty to come up with a set of numbers and never ever ever change them Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel