Re: [PATCH 1/8] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY document

[Tzu-Hao Wei <twei@axiado.com>]

On 12/23/2025 10:23 PM, Krzysztof Kozlowski wrote:
> On Mon, Dec 22, 2025 at 04:45:00PM +0800, Tzu-Hao Wei wrote:
>> From: SriNavmani A <srinavmani@axiado.com>
>>
>> Add device tree bindings for the Axiado AX3000 eMMC PHY. The bindings
>> define the required properties for configuring the external Arasan
>> eMMC PHY, including register base addresses and clock references
>> needed for HS200 mode operation.
> 
> Do not say what the bindings are supposed to do. We can read the diff.
> Explain the hardware.
> 
Simplified the messages in the new patch.

>>
>> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
>> ---
>>  .../bindings/phy/axiado,ax3000-emmc-phy.yaml       | 46 ++++++++++++++++++++++
>>  1 file changed, 46 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..f88941ce60cbd99a73e8c504e0bf36c626bbf674
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
>> @@ -0,0 +1,46 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/axiado,ax3000-emmc-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Axiado AX3000 Arasan eMMC PHY
>> +
>> +maintainers:
>> +  - SriNavmani A <srinavmani@axiado.com>
>> +  - Tzu-Hao Wei <twei@axiado.com>
>> +  - Prasad Bolisetty <pbolisetty@axiado.com>
>> +
>> +description: |+
>> +  Bindings for eMMC PHY on Axiado AX3000 SoC.
> 
> Irrelevant
> 
Removed.

>> +
>> +  - compatible:         Should be one of the following:
>> +                        "axiado,ax3000-emmc-phy"
>> +  - reg:
>> +      maxItems: 1
> 
> Entire description is not correct. Do you see any file written like
> this/
> 
Revised. It can pass DT_SCHEMA_CHECK and CHECK_DTBS now.

>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - axiado,ax3000-emmc-phy
>> +
>> +  "#phy-cells":
>> +    const: 0
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - "#phy-cells"
>> +  - compatible
>> +  - reg
> 
> Wrong order, use the same as in properties.
> 
Fixed.

>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    emmc_phy: emmc-phy@80801C00 {
> 
> Drop label and node is just phy@
> 
> Also, use lowercase hex everywhere.
> 
> Read DTS coding style - Axiado already received this feedback, so you
> should follow it in all your submissions.
> 
> Best regards,
> Krzysztof
> 
Dropped label, used lowercase hex.

Thanks for your feedback.
We will follow the style in the future.

Best regards,
TH