From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB286C433F5 for ; Fri, 8 Apr 2022 07:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1+0sE+PXq12KSGBYdda2SqEI2be1Ldt7a3jtO6c91NE=; b=IcCbkz7bLrI5Kh Qbe+LHiIpfVY+dZiGkf9uB9jCpk5yMsK0eEWdcCDpsOf187q977o7cB8f7B4WFni38Hm/q7m8E5ha e8pv6YPLDitA5ya9PkbPUBTjgh79azSF79Vk/inlVWnyuiDSGXttq0tC5Cq+qQy7Kww4yxP4NmMg3 /qacOXtVTdSL8Y8HlPozS6u9FeYsO9M61jTelB2ZQdjwTrCY3eQ0fSwj5E/kfrN/3LyITvQeanByx 9Zqg5hnuyGXYtvp6blrfwlqvjcDo0O1UVWgHW0ueTKmviu22dwwtXa7NezYRHqfsUrCUrgGIZqm9M 98l7/CAMQeIvnd9ORnFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncioF-00FRXh-2r; Fri, 08 Apr 2022 07:13:31 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncioB-00FRWC-E5 for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 07:13:28 +0000 Received: by mail-ej1-x633.google.com with SMTP id l7so10064381ejn.2 for ; Fri, 08 Apr 2022 00:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7EjkArby+YXeQWnUCkFmhxaHZGauplRCYZjUw5rv+0E=; b=P3LNs91PmjyMcGXqs/1qd6aAe2pOkmQxK2rpdZbLEkBXDUDRk1fTEc9BkEXcXU5Vb3 /dJlnetRZAdhTIaUdabV8GVVwltmE/N2sndujl+MwI3vTYlyDtARgSTA76FwOFTSVdTN 6Atdx5uuBt5qm+yTZJAkE5VhEmA8DHYlFY2qFFJWJyHusu21pSV/r5l60d8DS2bAApbq FzF6c+PqaqkBuH+Xz24uigvxKPryBg3zRM8mEPhDjFB3f5CTxMTdPf9oZlDPKXgU7z/i 29Et5h7AetTRIOOB4m6cDydCNGMqD53CSbGV5M6LLC5x9qODa4fivDnEIwns/yTKVeNo CVjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7EjkArby+YXeQWnUCkFmhxaHZGauplRCYZjUw5rv+0E=; b=2IIBg+jZWBnSKk5kJu6YUNWyJuhWrAJIH2YM768jFoqs8AHPmeJNZIOtPsSgPkCq5v kosx4hdi9d9H58IB2x0qcl2DcDEvi4j4rExSgqXVgbRNCpiHR8DuXZZTSjYRPXrU8xvS DAfcmsh3O5gn7IRRzQqJ6dY+Kj4T7BXPhl7SB43jl6PFz9UX5fRRKyXC3SMO+dMYTZCV 1nV5SFG161rdaGZaPd4hVLJYjfmX8GTD3AnlbyBGmjSrNZrT5x17icVyIZzrE9SmpNC1 u+hKbMs8FD0/ByL+7jQygybpR/5qfQCBagXnFAsv05O2A8uIooHEdp4TuAPCcoCbraNV xf/g== X-Gm-Message-State: AOAM533IxjAv9vWe6/clUzHaXWSTOBpU23Vt3PyDKexXjM+6gXs0SoYC Y0pLsp5GLVj1EBz0tPaLL4NC2A== X-Google-Smtp-Source: ABdhPJzgnGNDsxiLx/GHTVMUuI/MW9bJw8r0RLq06fINFbNAkHJSZCT3Ee2wL1N2t9btbxnWKy/woA== X-Received: by 2002:a17:906:c108:b0:6e4:a223:1af9 with SMTP id do8-20020a170906c10800b006e4a2231af9mr10017771ejc.441.1649402005890; Fri, 08 Apr 2022 00:13:25 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id c11-20020a056402120b00b004196059efd1sm10428943edw.75.2022.04.08.00.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 00:13:25 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2022 09:13:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support Content-Language: en-US To: Tim Harvey , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shawn Guo Cc: Rob Herring , Fabio Estevam , NXP Linux Team , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team References: <20220407210411.8167-1-tharvey@gateworks.com> <20220407210411.8167-2-tharvey@gateworks.com> From: Krzysztof Kozlowski In-Reply-To: <20220407210411.8167-2-tharvey@gateworks.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_001327_556902_4B29917F X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2022 23:04, Tim Harvey wrote: > The Gateworks GW7400 is an ARM based single board computer (SBC) > featuring: > - i.MX8M Plus SoC > - LPDDR4 DRAM > - eMMC FLASH Thank you for your patch. There is something to discuss/improve. (...) > + > +#include > +#include > +#include > + > +#include "imx8mp.dtsi" > + > +/ { > + model = "Gateworks Venice GW74xx i.MX8MP board"; > + compatible = "gw,imx8mp-gw74xx", "fsl,imx8mp"; Deprecated vendor prefix. > + > + aliases { > + ethernet0 = &eqos; > + ethernet1 = &fec; > + ethernet2 = &lan1; > + ethernet3 = &lan2; > + ethernet4 = &lan3; > + ethernet5 = &lan4; > + ethernet6 = &lan5; > + }; > + > + chosen { > + stdout-path = &uart2; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x0 0x40000000 0 0x80000000>; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + user-pb { Generic node names please, so "key-0" or "user-pb-key" (although adding specific parts is really not needed, because you have the label). > + label = "user_pb"; > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + > + user-pb1x { > + label = "user_pb1x"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <0>; > + }; > + > + key-erased { > + label = "key_erased"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <1>; > + }; > + > + eeprom-wp { > + label = "eeprom_wp"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <2>; > + }; > + > + tamper { > + label = "tamper"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <5>; > + }; > + > + switch-hold { > + label = "switch_hold"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <7>; > + }; > + }; > + > + led-controller { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_leds>; > + > + led-0 { > + function = LED_FUNCTION_STATUS; LED_FUNCTION_HEARTBEAT > + color = ; > + gpios = <&gpio2 15 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + linux,default-trigger = "heartbeat"; > + }; > + > + led-1 { > + function = LED_FUNCTION_STATUS; > + color = ; > + gpios = <&gpio2 16 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + }; > + }; > + > + pps { > + compatible = "pps-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pps>; > + gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>; > + status = "okay"; No need for status. > + }; > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel