From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6263C433E0 for ; Thu, 4 Feb 2021 02:11:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E19364F59 for ; Thu, 4 Feb 2021 02:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E19364F59 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ePG4lifIOETv43Y7XsiKNl7fNgbPRwrIfW2cAy3KeNM=; b=wqYoPosBnqzjfDDJ9ATyh1aTcC U8IEoqM4iijUvHpyTYdsUc2EfgQsv3S2uluAtu3tis3DZ20UT1lOufQXnx8ajkeeFbNVKhH+CIefh +dG74lT6FIwRPaDbKpO4yvMDnQH9jOXzcoP7L6aRns+rwJ/+Kl62tEY+WM2ja9OHamd3Jqyqtbr6y em3Zdzu/EA3aSvw+evB2YWnXgf7zR96TlCDIeKW4NUuJecNVVXX27/eJv0BtBk+kma06GJdsVZ/h3 5LLUoEDo6GXpDv2qQu1hwKRJBxEQZKmRs5CiLeW5D3Hy5gWPoOMruEJRTNej2L1ZCojK2ZtQbi+9V 47/SQGOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7U5t-0002oa-0E; Thu, 04 Feb 2021 02:10:05 +0000 Received: from [2601:1c0:6280:3f0::aec2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7U5p-0002nc-Ap; Thu, 04 Feb 2021 02:10:01 +0000 Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c To: Bhaskar Chowdhury , linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210204011821.18356-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: Date: Wed, 3 Feb 2021 18:09:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210204011821.18356-1-unixbhaskar@gmail.com> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: > > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Plus get rid of few blank lines. > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V1: > Fix typo in the subject line > Give explanation of all the changes in changelog text > > drivers/net/ethernet/i825xx/ether1.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c > index a0bfb509e002..850ea32091ed 100644 > --- a/drivers/net/ethernet/i825xx/ether1.c > +++ b/drivers/net/ethernet/i825xx/ether1.c a. don't delete the blank lines b. the change below is not described and does not change any whitespace AFAICT. I.e., DDT [don't do that]. > @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) > { > struct net_device *dev = ecard_get_drvdata(ec); > > - ecard_set_drvdata(ec, NULL); > + ecard_set_drvdata(ec, NULL); > > unregister_netdev(dev); > free_netdev(dev); -- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel