From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8A58C7EE23 for ; Thu, 8 Jun 2023 06:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Yaow3xMYYK1/mJR/hiFkyMAaZOZAr7tnYpD5vXB/0s=; b=Ax+oJYjN2VV7NA GCuLqpEY59AOMLwO1VyqkpAaQTqY+x9Dg5OZ0WbZMGkCwdJkT0rYl+5GBJ8rVhUjSXhhb9R7SP+ff wTrycHZaUYcGD9vP9dsd6oEqq8MSzPjjpNPL5KDY8ZKCnHZX99rtQqQjaVDCCmejgYXWeV3W8R+IK +rYJtMUuevpgPC7wWC75Dh4JqyKOyM2h+gJjOlQWXeeoPcBe8nKF8Qja4P/pofkejIoGARqAIsl4N iNYYLgn+b3Zi1bRxbI7Xgh3B4PqlxCt6uA2VEbKc/rQ6E7o6rs2bZlcr3bp8W2XnCXtDIEGn0/fHa 06GT+rgITxlrEaak6GRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q79Ja-008HFl-1b; Thu, 08 Jun 2023 06:40:10 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q79JY-008HEo-0S for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 06:40:09 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-974638ed5c5so62133466b.1 for ; Wed, 07 Jun 2023 23:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686206407; x=1688798407; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oVRZfjPusUlMd2YSAWkUFw8x4CXFJxYh+aCGHiCjN5A=; b=xqI+reGDDN9cNUgG8bBTYU3s/nwG1PuvXOzHTpns4U2llK/sWtFsXu4o2iTRqW4nko 2cdhmsc4/LtNfg3u/NU3tA7N3vf3bh8GCoYVjdffQjmRW4hV5zq41p2HxgflyOADfA5H ndTJJnG1CHYwzWyDHOG3XSqa0VoUJYcOls4so/APVmpetMjI5U1Sc+iAd9HK14dtEMZF 4JcJy4NSNowUarzzT65nN0OytYabtvVXzMcvm5WKRYrR9iV+zJomX4j9SQ20L0d0l+07 Sk1hhQslbx6Bpfd62KwUXXE7GSNs6cBTl38hGJJXWtJy+mRXCImcErhmqxG3SIwESpee uMfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686206407; x=1688798407; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oVRZfjPusUlMd2YSAWkUFw8x4CXFJxYh+aCGHiCjN5A=; b=FAXEKWSxlhjR9BEDXM7m2aIq8y1UL30gzZT7VmC1y5pchUMyptwD/S4RD1hUFaaWXn pXGIvGKlFQeDCq95cf0jdXi7Okc18ixw0x8ZdgxOdbyBlqLvj/3/IfrnIzxU9z0bfQFE t8jF92tzLkAfNpbsHhMYpdjczJ8ZORzQ8+UffnzizanOgNMbrt51xgwF0OtVlxKc5Ha3 uIb0ARfoQxJNoMAHMhJzwqruQ/JFe75auapAMnqqBi6y5oX/U8ra4oCVchAYNHrOTwDG 0VY3emSWyYWeG4StlKz3w0e3iKWR2/6u08dVhukf1T8riAC+EMif6JeZuM0K2wa2/aAh MQZA== X-Gm-Message-State: AC+VfDxIfkSZgha+y31hUYue7D5WtnF1cR2DUg0Amn1x76I56ePjI0ss +rFXZwBb8SyrYzLjP6tAqqIVHw== X-Google-Smtp-Source: ACHHUZ7Y49qxpbARq0/PESo5rGH/0TBRzIPZEdIk349An/yWXAvAuSNvyKVBJn4VTWgCDaiQFX9UyA== X-Received: by 2002:a17:907:9404:b0:977:e8ca:ab34 with SMTP id dk4-20020a170907940400b00977e8caab34mr1008654ejc.22.1686206406850; Wed, 07 Jun 2023 23:40:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id e26-20020a170906249a00b009662c57b4ffsm273586ejb.96.2023.06.07.23.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 23:40:06 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 08:40:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH Control documentation Content-Language: en-US To: Billy Tsai , jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, corbet@lwn.net, p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org, patrick@stwcx.xyz References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> <20230608021839.12769-3-billy_tsai@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230608021839.12769-3-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_234008_177822_635A0772 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2023 04:18, Billy Tsai wrote: > Document the compatible for aspeed,ast2600-tach device. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > > Signed-off-by: Billy Tsai > --- > .../bindings/hwmon/aspeed,ast2600-tach.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > new file mode 100644 > index 000000000000..627aa00f2e92 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Aspeed, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-tach.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed Ast2600 Tach controller > + > +maintainers: > + - Billy Tsai > + > +description: | > + The Aspeed Tach controller can support upto 1 fan input. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-tach > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 NAK, not true based on previous discussions. Device does not come with resets and clocks. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel