From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 638A7C4363C for ; Wed, 7 Oct 2020 08:44:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA1FF20797 for ; Wed, 7 Oct 2020 08:44:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NTJSoADm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA1FF20797 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To:Date:To: From:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xDIAFwl42/osHJe21zXDTtGDGPNo3Yazr9cO+qcRrH8=; b=NTJSoADmFhJ/p5HxMxx+rfRbh y3BDnrRP9DUN/Ht5UI+IkmtBQqWConLJgOqap2cbGep4vR/hk7l0zKzjA1/oRr3khgs8gLx20avCD mEv60Fze5/vpvMiesVZu/DsQ6pgyep6Gbq2ztzN+lMZuJpU5q/uIHTYvUzDnE1LWmYPpBeZPJpJPB iZRXliOLwjml8RLg6s8Hle6SKJngpRXmTH+1M8DMxJ2KLEAdvpHGFacZKO2sQ2ZzfyFUtOYRr8ZzJ nZ7U6XKAvi74umfOoEJReNG0c/SuQNDfl6opu0DTKTyAETeO0xHQRRaTfPbj9x6+RyL3dMfSLKbny VoEhyL3EQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ52u-0006MJ-Bx; Wed, 07 Oct 2020 08:43:36 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ52r-0006Kf-Jk for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 08:43:34 +0000 Received: from [2a0a:edc0:0:900:6245:cbff:fea0:1793] (helo=kresse.office.stw.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kQ52k-0007tg-Os; Wed, 07 Oct 2020 10:43:27 +0200 Message-ID: From: Lucas Stach To: Marek Vasut , Laurent Pinchart , dri-devel@lists.freedesktop.org Date: Wed, 07 Oct 2020 10:43:25 +0200 In-Reply-To: References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:6245:cbff:fea0:1793 X-SA-Exim-Mail-From: l.stach@pengutronix.de Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_044333_654156_F8FFD059 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Guido =?ISO-8859-1?Q?G=FCnther?= , Stefan Agner , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > On 10/7/20 3:24 AM, Laurent Pinchart wrote: > [...] > > +properties: > > + compatible: > > + enum: > > + - fsl,imx23-lcdif > > + - fsl,imx28-lcdif > > + - fsl,imx6sx-lcdif > > + - fsl,imx8mq-lcdif > > There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, > so the DT must specify compatible = "fsl,imx8mq-lcdif", > "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). > > Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or > dropped from the YAML file or neither ? Neither. As far as we know the block is compatible, so the DT should claim that it's compatible to "fsl,imx28-lcdif". However we don't know if there are any surprises, so we add the SoC specific compatible to be able to change the driver matching later without changing the DT if the need arises. For the DT validation to pass the SoC specific compatible needs to be documented, even if it currently unused by the driver. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel