From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Ryan Chen <ryan_chen@aspeedtech.com>
Cc: benh@kernel.crashing.org, joel@jms.id.au, andi.shyti@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrew@codeconstruct.com.au, p.zabel@pengutronix.de,
andriy.shevchenko@linux.intel.com, naresh.solanki@9elements.com,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML
Date: Fri, 24 Oct 2025 15:56:03 +0800 [thread overview]
Message-ID: <bf3d6690b9124ecf74df6c0f9f1c0f72ae1db9f7.camel@codeconstruct.com.au> (raw)
In-Reply-To: <2939cae6-2e8a-4528-8e27-8c932e2f82de@kernel.org>
Hi Krzysztof,
> Although now I saw next patch, so clearly this commit is incomplete.
The split that Ryan has done here - by shifting to an identical separate
binding, then making the changes explicit - allows us to review the
actual changes without losing them in the move. Sounds like a benefit to
me?
> You just need allOf:if:then: section to narrow the
> constraints/presence of properties.
That seems like a more complex approach. This is separate IP from the
2500 controllers, wouldn't that warrant a new binding spec?
Cheers,
Jeremy
next prev parent reply other threads:[~2025-10-24 7:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 1:35 [PATCH v20 0/4] Add ASPEED AST2600 I2C controller driver Ryan Chen
2025-10-21 1:35 ` [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML Ryan Chen
2025-10-24 6:45 ` Krzysztof Kozlowski
2025-10-24 6:50 ` Krzysztof Kozlowski
2025-10-24 7:56 ` Jeremy Kerr [this message]
2025-10-24 8:06 ` Krzysztof Kozlowski
2025-10-24 8:35 ` Krzysztof Kozlowski
2025-10-24 8:41 ` Jeremy Kerr
2025-10-24 12:36 ` Ryan Chen
2025-10-24 12:43 ` Krzysztof Kozlowski
2025-10-24 8:40 ` Jeremy Kerr
2025-10-24 12:30 ` Krzysztof Kozlowski
2025-10-24 12:47 ` Ryan Chen
2025-10-24 13:13 ` Jeremy Kerr
2025-10-24 8:14 ` Krzysztof Kozlowski
2025-10-29 8:29 ` Ryan Chen
2025-10-29 10:52 ` Krzysztof Kozlowski
2025-11-11 4:57 ` Ryan Chen
2025-11-13 9:34 ` Ryan Chen
2025-11-13 10:40 ` Krzysztof Kozlowski
2025-11-14 6:17 ` Ryan Chen
2025-10-21 1:35 ` [PATCH v20 2/4] dt-bindings: i2c: ast2600-i2c.yaml: Add global-regs and transfer-mode properties Ryan Chen
2025-10-21 1:35 ` [PATCH v20 3/4] i2c: ast2600: Add controller driver for new register layout Ryan Chen
2025-10-24 9:10 ` Philipp Zabel
2025-10-25 2:57 ` Ryan Chen
2025-10-21 1:35 ` [PATCH v20 4/4] i2c: ast2600: Add target mode support Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf3d6690b9124ecf74df6c0f9f1c0f72ae1db9f7.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).