From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C47C43334 for ; Wed, 8 Jun 2022 10:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C8304r960udN6G5h9B/7xNtr5HY7CRuP5o/qSVxzmIY=; b=P6f+1CYMXUxSPc pdTWGRcXGUx9Nw2pl/v0QsgUIW865EYt015AP61ox4tYyFYF4aci+JA0yu6BFck5cErmQMHmOxpnC h1EnbEJ1KoVvxUcPWWn+xJH25xhwJOE7+0yN8GYQVARcYGtHwAtF1rJa6BZoLDijJC8HnBWumlLeH 6OQqmxZ956AaXyfecYzuYFfjdWAOqtNO+GChckR/QHgmRI9+S8vYgC6S2kDU8+7xxLxMYJw9FPLEn fM8WSk7O7AVH9oS31Hdq4g9pSTkIroAnz60qQS3V8Yxsd+r0LPnsSH7hdb1b2Lay5Nm0Ek+ANAcs9 adMgJD+NcD2lufPttWfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysa1-00CbIm-Ks; Wed, 08 Jun 2022 10:06:25 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysZx-00CbHN-GF for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 10:06:22 +0000 Received: by mail-ej1-x636.google.com with SMTP id s12so33219347ejx.3 for ; Wed, 08 Jun 2022 03:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3J02Cy+NQfGm8eV9KXhCD+MqMYdiX+58OLIgnc/8epc=; b=IMJozpnrngI0y4iXwqWP72b84kfB4aNdhVQEbM8V/kkVCEolj6yjfMGAfBxkFB1cNQ xQNoHORJyBpbstcHefYhvnN2pvdrhUXXseBwJ0ONtoIi02CV9fa7yedi6l54sewGvk8j TN3TIX5Hejet+8VZroyCyUobF3JFKxK/iEApe/3CSgLAB3Po09mYcdpCLf+ZvjEPKGyl DqZfgw00JleReC4QKzzWGH7wFevd7z305S6FE1TaMTmmjwN4JvBFRfbr34UI8HZiCXGy Fev4FGzYiRF/p4JYukVG3FNQqICash3M96PZ5mqEj+LVVPQuga/aSPhYcHdYYAd+C895 BrLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3J02Cy+NQfGm8eV9KXhCD+MqMYdiX+58OLIgnc/8epc=; b=ja+JLeC1zPSmQ42PnJXlP9CvPrFyHhBdjZT3+XFB02sKPn/EviliG/8U1K8GP1cvT3 BNv7iyIg+VqS+C2+LFgyUx1ELyEhA0N+dlxHwNdVVLhZH39A4gcdK0FnwKeIvPAru8IW OdWUwB04HjNSUV43aC1tgpiVVHF8iMZPNwf4F46HIxvsUWRa9hD5aY+asnQ5END+GPjf iZmElTshcypOUfsYmHjd5EbmgLR6CjbeWzLqR4+9VhkMK0Voe3f/Jq05yVP0V1Efa7Ot RiAlh2OEcbc7mj6gn4fueuLORmyNdLk/gd+loMu2BNmLNNnBPkX5jf/Fs2TDTDxAcpN9 +7Jw== X-Gm-Message-State: AOAM530X3XYUoOi3AoBV/1KxiCSgUlBZ7+FHg+f3EP5O8AjFAMYSvWgD BJ8uFHDzkbAzo+vbeINhYDgrVg== X-Google-Smtp-Source: ABdhPJxsAIrFE3btqqb5RrORPvxSxuVZHyAl3KpL5wCgHxpsvLqD8dGERxMUjIqaeaFK4tHV94VjMw== X-Received: by 2002:a17:906:4785:b0:6fe:f8ac:2494 with SMTP id cw5-20020a170906478500b006fef8ac2494mr30359804ejc.199.1654682779982; Wed, 08 Jun 2022 03:06:19 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q1-20020a1709066ac100b006feed212f50sm8856606ejs.184.2022.06.08.03.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 03:06:19 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 12:06:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 09/20] dt-bindings: reset: npcm: add GCR syscon property Content-Language: en-US To: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-10-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220608095623.22327-10-tmaimon77@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_030621_646905_54A70136 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2022 11:56, Tomer Maimon wrote: > Describe syscon property that handles general > control registers(GCR) in Nuvoton BMC NPCM > reset driver. I already asked about this. Could you please implement the comments you receive? It's not just one, it's several of them have to be repeated. > > Signed-off-by: Tomer Maimon > --- > .../devicetree/bindings/reset/nuvoton,npcm-reset.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > index 0998f481578d..c6bbc1589ab9 100644 > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > @@ -19,6 +19,10 @@ properties: > '#reset-cells': > const: 2 > > + nuvoton,sysgcr: > + $ref: "/schemas/types.yaml#/definitions/phandle" Skip quotes. > + description: a phandle to access GCR registers. > + > nuvoton,sw-reset-number: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 1 > @@ -31,6 +35,7 @@ required: > - compatible > - reg > - '#reset-cells' > + - nuvoton,sysgcr Aren't you breaking existing DTBs? > > additionalProperties: false > > @@ -41,6 +46,7 @@ examples: > compatible = "nuvoton,npcm750-reset"; > reg = <0xf0801000 0x70>; > #reset-cells = <2>; > + nuvoton,sysgcr = <&gcr>; > nuvoton,sw-reset-number = <2>; > }; > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel