public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant
Date: Fri, 19 May 2017 11:11:06 +0200	[thread overview]
Message-ID: <bf63ad43-5648-d289-4414-5d187b37f229@gmail.com> (raw)
In-Reply-To: <20170519065331.27670-9-clabbe.montjoie@gmail.com>



On 19/05/17 08:53, Corentin Labbe wrote:
> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

>   drivers/crypto/mediatek/mtk-sha.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/mediatek/mtk-sha.c b/drivers/crypto/mediatek/mtk-sha.c
> index 2226f12d1c7a..5f4f845adbb8 100644
> --- a/drivers/crypto/mediatek/mtk-sha.c
> +++ b/drivers/crypto/mediatek/mtk-sha.c
> @@ -12,6 +12,7 @@
>    * Some ideas are from atmel-sha.c and omap-sham.c drivers.
>    */
>   
> +#include <crypto/hmac.h>
>   #include <crypto/sha.h>
>   #include "mtk-platform.h"
>   
> @@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
>   	memcpy(bctx->opad, bctx->ipad, bs);
>   
>   	for (i = 0; i < bs; i++) {
> -		bctx->ipad[i] ^= 0x36;
> -		bctx->opad[i] ^= 0x5c;
> +		bctx->ipad[i] ^= HMAC_IPAD_VALUE;
> +		bctx->opad[i] ^= HMAC_OPAD_VALUE;
>   	}
>   
>   	return 0;
> 

  reply	other threads:[~2017-05-19  9:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  6:53 [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 1/9] crypto: add hmac " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 2/9] crypto: brcm - Use " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 3/9] crypto: ixp4xx " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 4/9] crypto: marvell " Corentin Labbe
2017-05-19  9:17   ` Boris Brezillon
2017-05-19  6:53 ` [PATCH v2 5/9] crypto: mv_cesa " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 6/9] crypto: omap-sham " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 7/9] crypto: qat " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 8/9] crypto: mediatek " Corentin Labbe
2017-05-19  9:11   ` Matthias Brugger [this message]
2017-05-19  6:53 ` [PATCH v2 9/9] crypto: ccp " Corentin Labbe
2017-05-19 20:32   ` Gary R Hook
2017-05-23  5:03 ` [PATCH v2 0/9] crypto: add HMAC " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf63ad43-5648-d289-4414-5d187b37f229@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox