From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8688DC04AB1 for ; Thu, 9 May 2019 15:03:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 597FD205C9 for ; Thu, 9 May 2019 15:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S6hjjEj4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 597FD205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sehH64vBqZmhsdfouYo7xNa0Kfu6Usv93SPAHXO/ueo=; b=S6hjjEj49qSd7H OafQUFeOoGQ3xq7ejgw9cpN9UWAz5WMH1iqJfUIaXG9o0kb8jQFprTVhRISWRLOg3rgFgsgqtrjq7 yRcIGiZe3DBgS8ioItZcTTzkkriS25mG12W6AL96G458ZaIBguY6Vg6cxJlYrNn6ObLbZUz54XXHH k2APCjDYeepm0ldtLoJJyPwYmlBqt7NmmP3d27Y62ZdW9A3OcxTktPRwSMNUlVaXOcTJvWfGSRlNK rzV1+AVlvt2ZuwKQ97agVdAuBxjobGZJ+aTZ7GzLwymhT+IRz42GcDeouhIuFJrOMIryT/Dy6p6Ti 5H1+csNhRt8Y4gEzCmvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOkaS-0003s2-0w; Thu, 09 May 2019 15:03:56 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOkaL-0003r4-HC for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2019 15:03:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EEA7374; Thu, 9 May 2019 08:03:49 -0700 (PDT) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52BDD3F6C4; Thu, 9 May 2019 08:03:45 -0700 (PDT) Subject: Re: [PATCH v8 05/20] KVM: PPC: Book3S HV: Remove pmd_is_leaf() To: Paul Mackerras References: <20190403141627.11664-1-steven.price@arm.com> <20190403141627.11664-6-steven.price@arm.com> <20190429020555.GB11154@blackberry> From: Steven Price Message-ID: Date: Thu, 9 May 2019 16:03:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190429020555.GB11154@blackberry> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190509_080349_571062_D7E312A8 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , linux-mm@kvack.org, "H. Peter Anvin" , "Liang, Kan" , Michael Ellerman , x86@kernel.org, Ingo Molnar , Benjamin Herrenschmidt , Arnd Bergmann , kvm-ppc@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/04/2019 03:05, Paul Mackerras wrote: > On Wed, Apr 03, 2019 at 03:16:12PM +0100, Steven Price wrote: >> Since pmd_large() is now always available, pmd_is_leaf() is redundant. >> Replace all uses with calls to pmd_large(). > > NAK. I don't want to do this, because pmd_is_leaf() is purely about > the guest page tables (the "partition-scoped" radix tree which > specifies the guest physical to host physical translation), not about > anything to do with the Linux process page tables. The guest page > tables have the same format as the Linux process page tables, but they > are managed separately. Fair enough, I'll drop this patch in the next posting. > If it makes things clearer, I could rename it to "guest_pmd_is_leaf()" > or something similar. I'll leave that decision up to you - it might prevent similar confusion in the future. Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel