From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Md Danish Anwar <a0501179@ti.com>, linux-kernel@vger.kernel.org
Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com,
andrew@lunn.ch, netdev@vger.kernel.org, kishon@ti.com,
rogerq@kernel.org, afd@ti.com, edumazet@google.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
ssantosh@kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
Date: Fri, 4 Nov 2022 08:57:16 -0400 [thread overview]
Message-ID: <bf6bef84-8f67-4bde-e7d1-4f98e3a45455@linaro.org> (raw)
In-Reply-To: <41d5952b-51f8-bbc6-2e81-22d6f66320ee@ti.com>
On 04/11/2022 03:28, Md Danish Anwar wrote:
>>> * It includes indentation, formatting, and other minor changes.
>>> ---
>>> .../bindings/net/ti,icssg-prueth.yaml | 181 ++++++++++++++++++
>>> 1 file changed, 181 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> new file mode 100644
>>> index 000000000000..40af968e9178
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> @@ -0,0 +1,181 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/net/ti,icssg-prueth.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: |+
>>
>> Missed Rob's comment.
>>
>
> I'll remove this in the next version of this series.
>
>>> + Texas Instruments ICSSG PRUSS Ethernet
>>> +
>>> +maintainers:
>>> + - Puranjay Mohan <p-mohan@ti.com>
>>> +
>>> +description:
>>> + Ethernet based on the Programmable Real-Time
>>> + Unit and Industrial Communication Subsystem.
>>> +
>>> +allOf:
>>> + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ti,am654-icssg-prueth # for AM65x SoC family
>>> +
>>> + pinctrl-0:
>>> + maxItems: 1
>>> +
>>> + pinctrl-names:
>>> + items:
>>> + - const: default
>>
>> You do not need these usually, they are coming from schema.
>>
> Here from what I understand, I need to delete the below block, right?
Yes, entire pinctrl-0 and pinctr-names are not needed. You specify them
ony if they differ from usual.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-04 12:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:51 [PATCH v2 0/2] Introduce ICSSG based ethernet Driver Puranjay Mohan
2022-05-31 9:51 ` [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Puranjay Mohan
2022-05-31 10:08 ` Krzysztof Kozlowski
2022-05-31 11:27 ` Puranjay Mohan
2022-05-31 11:48 ` Krzysztof Kozlowski
2022-05-31 11:59 ` Puranjay Mohan
2022-05-31 12:01 ` Krzysztof Kozlowski
2022-06-01 4:28 ` Puranjay Mohan
2022-06-05 15:11 ` Andrew Lunn
2022-11-04 7:28 ` Md Danish Anwar
2022-11-04 12:57 ` Krzysztof Kozlowski [this message]
2022-05-31 13:21 ` Rob Herring
[not found] ` <20220531095108.21757-3-p-mohan@ti.com>
2022-05-31 10:20 ` [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Krzysztof Kozlowski
2022-05-31 11:23 ` Paolo Abeni
2022-11-04 8:29 ` Md Danish Anwar
2022-05-31 13:11 ` Randy Dunlap
2022-06-05 15:37 ` Andrew Lunn
2022-11-04 10:26 ` Md Danish Anwar
2022-06-05 16:24 ` Christophe JAILLET
2022-11-04 9:50 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf6bef84-8f67-4bde-e7d1-4f98e3a45455@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a0501179@ti.com \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).