From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 400B6C433F5 for ; Thu, 10 Feb 2022 08:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ATZCvy1tP9309ZLWGPpzwFuvTipPtT4Hes7GPeeB2h4=; b=YmP5sV65uUyEma fl5lPXDVmsyIg62x5BQ6+ufDL3NiHKJr3IupokITTDchxbQWBtCa10dj4/jeikeN097gZkoklI6tz 4KLmGg3QIMKqSafCFqg/j5tpxztgs+AxCgl6C8jZV53CATTTFKoO/cLxRzIBZVFY8at2o5iVA6bQC f4A5nNBwch9utwn+QqRlX7D9ViiiG/crb/UlvpZXLlVxzmml+HXnSZM9tCrQBCN/WLQZjUYWGCY14 /wobyra8IHCro07qLQdTYjWN37TacVLlq5uxkU8X/knnAkqxdrCeRMA82LSwt55+VFZ/09wLL7Hd+ 2EahN77TnD+1ixalwW2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI4yJ-003695-G7; Thu, 10 Feb 2022 08:38:36 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI4xV-0035fs-0C for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 08:37:46 +0000 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21A78BKh010054; Thu, 10 Feb 2022 09:37:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=9L+fPaBLdaNdwtQhHw2KK50BP8s+igQHUs4+4EbCqQ0=; b=PR/yoAOh6w01v9x58jlCjryk/LiQ7pLPNxgEzGP5gGrrQ1yiLathkRsK882OjYebXUCe oJ1HNoVXd61EPVWnQCcSt9Rs7UJ02MrtsLakubab2/jmr4d82NHZ7Bnj/FHSCWU8Mt7P qYS/WI3VMIPwoV2iOGwps2al94VDah7Ny8zKWPhCyBiUmJzBmsPzF5pQoAxhxs7n2NpC Tp/JOqxTAkcQySp2jo1h4hUzhe1xi2MZMxw2pGzkbhNHcPz8lEcKBMoVOsC0Edfn1qEX eIl5X9ZviOk+fs0pwaZkfnF478sPwvAA2oYvBPMGutAJEWszx4Gc3DQK4p+3ff9vvOnV jQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3e4x268h50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Feb 2022 09:37:39 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 251CC100038; Thu, 10 Feb 2022 09:37:39 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1F2D92138DE; Thu, 10 Feb 2022 09:37:39 +0100 (CET) Received: from [10.201.21.201] (10.75.127.45) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Thu, 10 Feb 2022 09:37:38 +0100 Message-ID: Date: Thu, 10 Feb 2022 09:37:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 09/12] ARM: dts: sti: move usb picophy nodes out of soc in stih410.dtsi Content-Language: en-US To: Alain Volmat , , , , , , References: <20211202075105.195664-1-avolmat@me.com> <20211202075105.195664-10-avolmat@me.com> From: Patrice CHOTARD In-Reply-To: <20211202075105.195664-10-avolmat@me.com> X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_03,2022-02-09_01,2021-12-02_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_003745_398015_DD76C9E3 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alain On 12/2/21 08:51, Alain Volmat wrote: > Move the usb2_picophy1 and usb2_picophy2 nodes out of the soc section. > Since they are controlled via syscfg, there is no reg property needed, > which is required when having the node within the soc section. > > Signed-off-by: Alain Volmat > --- > arch/arm/boot/dts/stih410.dtsi | 42 ++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi > index fe83d9a522bf..ce2f62cf129b 100644 > --- a/arch/arm/boot/dts/stih410.dtsi > +++ b/arch/arm/boot/dts/stih410.dtsi > @@ -12,31 +12,29 @@ aliases { > bdisp0 = &bdisp0; > }; > > - soc { > - usb2_picophy1: phy2@0 { > - compatible = "st,stih407-usb2-phy"; > - reg = <0 0>; > - #phy-cells = <0>; > - st,syscfg = <&syscfg_core 0xf8 0xf4>; > - resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > - <&picophyreset STIH407_PICOPHY0_RESET>; > - reset-names = "global", "port"; > + usb2_picophy1: phy2 { > + compatible = "st,stih407-usb2-phy"; > + #phy-cells = <0>; > + st,syscfg = <&syscfg_core 0xf8 0xf4>; > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > + <&picophyreset STIH407_PICOPHY0_RESET>; > + reset-names = "global", "port"; > + > + status = "disabled"; > + }; > > - status = "disabled"; > - }; > + usb2_picophy2: phy3 { > + compatible = "st,stih407-usb2-phy"; > + #phy-cells = <0>; > + st,syscfg = <&syscfg_core 0xfc 0xf4>; > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > + <&picophyreset STIH407_PICOPHY1_RESET>; > + reset-names = "global", "port"; > > - usb2_picophy2: phy3@0 { > - compatible = "st,stih407-usb2-phy"; > - reg = <0 0>; > - #phy-cells = <0>; > - st,syscfg = <&syscfg_core 0xfc 0xf4>; > - resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > - <&picophyreset STIH407_PICOPHY1_RESET>; > - reset-names = "global", "port"; > - > - status = "disabled"; > - }; > + status = "disabled"; > + }; > > + soc { > ohci0: usb@9a03c00 { > compatible = "st,st-ohci-300x"; > reg = <0x9a03c00 0x100>; Reviewed-by: Patrice Chotard Thanks Patrice _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel