From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3D9AC64EC4 for ; Fri, 10 Mar 2023 14:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=66XLdjfZbedwJLlr1L8+WhRXlccrCLYOEgpwLr6HGN0=; b=z+4hv4NrPqu+d+ Hi6XTH2TMSIEB4gqA4j0AeZZersjcfmgkC7vU1ksfpti95PhNpWiQBHFLJ/jlDrfkx6U01LsLyW8G u1qz8LwdUhkrfz2W6tH92L4fBILQjtUHJrOxgEv6LTAGcqvcmGdl+P8mLAKTDHYUoKo1rMXWQ9eBF jz2j8mnUbpuaHDHLd/4sCZIZ8VdbIHw4l4qw3NOdf84UagSHFnBGhH3vCezZJA34KeNWXVPo7jAZ1 QZ6Qdn6xnA/T/WJw/hHvToahdCRVuVpaR08dRxnVh7goMaCVxPRpgstTAsAq+OTXt7mkGLXdT3P/i py7cfezTRp/2oAsOlGDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1padYt-00Ehq4-Pb; Fri, 10 Mar 2023 14:17:35 +0000 Received: from mx0a-00190b01.pphosted.com ([2620:100:9001:583::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1padYq-00Ehm8-LM for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2023 14:17:34 +0000 Received: from pps.filterd (m0050093.ppops.net [127.0.0.1]) by m0050093.ppops.net-00190b01. (8.17.1.19/8.17.1.19) with ESMTP id 32AAG6AP028235; Fri, 10 Mar 2023 14:15:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=a1Tdrh1E0sqCNPCvXDdc0TRelX2Ah/cezVnHkMNv/UY=; b=eefwoN0TjGvXBQC04slfoKfvhTTLolPovjJL/gylN5k54KLZVvCutn11IhdJ8clf4Ye/ MI8mkpoq1Ejyow/8cX/lOFAzKcrOgjtavucrIYFmGdZUi5URzWNWuwwPJKaU17YB76ZW EoIONZAHadXf/jIzvkJlufH0Y3I1v8w/mSp9cCZIkrSoyFHPHFO/+4Rmx6EtsSzO1jo5 hvB+qBJ9dumpSkyXcLNg4tr8X9rdUCJeLoadWa3PCc1pH3qDvqKn6VEmfYRdB6MzTb8g TeuUjSRmzTh2gakZAlRHyNRruS5Ky0/+wokG0SOCOMffK6b0TFAAR7+HahClun5XhlVE iA== Received: from prod-mail-ppoint3 (a72-247-45-31.deploy.static.akamaitechnologies.com [72.247.45.31] (may be forged)) by m0050093.ppops.net-00190b01. (PPS) with ESMTPS id 3p6fhe8fp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Mar 2023 14:15:56 +0000 Received: from pps.filterd (prod-mail-ppoint3.akamai.com [127.0.0.1]) by prod-mail-ppoint3.akamai.com (8.17.1.19/8.17.1.19) with ESMTP id 32AAPe6m025465; Fri, 10 Mar 2023 09:15:55 -0500 Received: from prod-mail-relay19.dfw02.corp.akamai.com ([172.27.165.173]) by prod-mail-ppoint3.akamai.com (PPS) with ESMTP id 3p6ffv0jgy-1; Fri, 10 Mar 2023 09:15:55 -0500 Received: from [172.19.47.124] (bos-lpa4700a.bos01.corp.akamai.com [172.19.47.124]) by prod-mail-relay19.dfw02.corp.akamai.com (Postfix) with ESMTP id C68FF600FA; Fri, 10 Mar 2023 14:15:54 +0000 (GMT) Message-ID: Date: Fri, 10 Mar 2023 09:15:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] ARM: dyndbg: allow including dyndbg.h in decompressor To: Arnd Bergmann , Vincenzo Palazzo , Luis Chamberlain Cc: Arnd Bergmann , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230310140133.291594-1-arnd@kernel.org> Content-Language: en-US From: Jason Baron In-Reply-To: <20230310140133.291594-1-arnd@kernel.org> X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-10_06,2023-03-10_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303100113 X-Proofpoint-GUID: ZqomsXiNACum6iYNz7RRMp-vffyiTo6d X-Proofpoint-ORIG-GUID: ZqomsXiNACum6iYNz7RRMp-vffyiTo6d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-10_06,2023-03-10_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0 clxscore=1011 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303100115 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_061732_724379_D4D12341 X-CRM114-Status: GOOD ( 29.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/10/23 9:01 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > After a change to linux/module.h, dyndbg.h is now included > indirectly from the decompressor for lz4 support, which in turn > causes a build failure on 32-bit Arm: > > In file included from include/linux/module.h:30, > from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39, > from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:10, > from arch/arm/boot/compressed/decompress.c:59: > include/linux/dynamic_debug.h: In function 'ddebug_dyndbg_module_param_cb': > include/linux/dynamic_debug.h:307:14: error: implicit declaration of function 'strcmp' [-Werror=implicit-function-declaration] > 307 | if (!strcmp(param, "dyndbg")) { > | ^~~~~~ > include/linux/dynamic_debug.h:1:1: note: 'strcmp' is defined in header ''; did you forget to '#include '? > +++ |+#include > > The decompressor has its own replacement for the linux/string.h contents, > so the normal declaration is not visible here. Since the function is > not actually called, it is sufficient to add a declaration, and this > is in fact the correct one as it matches the definition in > arch/arm/boot/compressed/string.c. > > Fixes: 7deabd674988 ("dyndbg: use the module notifier callbacks") > Signed-off-by: Arnd Bergmann > --- > The patch that caused the problem is in linux-next, maybe fold > the fix into that patch if possible > --- > arch/arm/boot/compressed/decompress.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/compressed/decompress.c b/arch/arm/boot/compressed/decompress.c > index 74255e819831..0669851394f0 100644 > --- a/arch/arm/boot/compressed/decompress.c > +++ b/arch/arm/boot/compressed/decompress.c > @@ -31,6 +31,7 @@ > /* Not needed, but used in some headers pulled in by decompressors */ > extern char * strstr(const char * s1, const char *s2); > extern size_t strlen(const char *s); > +extern int strcmp(const char *cs, const char *ct); > extern int memcmp(const void *cs, const void *ct, size_t count); > extern char * strchrnul(const char *, int); > Hi Arnd, Thank you for the fix up, I was about to look into this... Acked-by: Jason Baron Thanks, -Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel