From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3507CC64ED8 for ; Mon, 27 Feb 2023 15:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Wh6qSYAPTh7wPsqFR65NQ3Lto5UcH+OLaAvASH+Txc=; b=eUUNxJNCVc5+jR /FcG1M8SEvCmAp5O+R5AyUVcOBeayio7N8fugI+Xv4304zMR4C6UgIspKet7ZF75S9km37cyLcqnC u6qymkafm/OC3m7WpUNxcT9vvm8QfafTY5X62qyj7fJdrhOvZblZjNWWCYB2aCZTrQokaf64IM8PG K6PVw4o/mi5oMcWipAnfyZGELhBdQeZ2akqRXzdXoJUWojRjyK9XGo6mVp2OHHNNBM4i9bAIFjDTx 1GQYJs0QI+bnADuBb931lZM1vcj1PdkfkglLLIx+es9/xWRqD2AlVavuq63WC+0vQzbkD7mpmoE/g UZ0O2fVFTawFc60GY4wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWfqf-00AGIH-FZ; Mon, 27 Feb 2023 15:55:33 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWfqT-00AGC7-VV for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 15:55:23 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 36B9885A7B; Mon, 27 Feb 2023 16:55:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677513320; bh=7Dn6cBLdopBkp2Exs4jgSx9A/9zgQJ9kdSt/LUQ/hCY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uThjkZICZ3yBvyipTGKiglELLQos6I0Gk+4Ju/aQt99bivUvDCoV3rKYkYgECddGO K0EJaWaD1fJCf5HMc9xOb+uIjTlvWCeDt/k+S4kAFyIDkzbNNWye1AS5YEyQYM/Uc7 OOz/24oZS5D1s8E7PRP2lBEbIgTDQpLml7w8nqU+4IURtHwXCMOrtfrtHOkMxBhlor PyJqMbLCY0PQSvf/1sIICY5VduyGRe1yfQdD+2EdrkNIXL1U66+/f7AMuEZPr2Xkp1 FiTA6dN5lOj89gjI99eysNJSZi+u46vfj1WlYBAJquHrLNEHju0QLiF6NgUZMtBB7p EvhyZCrYG9zSg== Message-ID: Date: Mon, 27 Feb 2023 16:55:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/4] soc: imx: imx8m-blk-ctrl: Scan subnodes and bind drivers to them To: Lucas Stach , linux-arm-kernel@lists.infradead.org Cc: Alexander Stein , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org References: <20230223151043.41548-1-marex@denx.de> <20230223151043.41548-3-marex@denx.de> <8477c32f-28e6-96f2-a4ec-b378b142d234@denx.de> <40830b7ba59797f890c365072d064b358622f59a.camel@pengutronix.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <40830b7ba59797f890c365072d064b358622f59a.camel@pengutronix.de> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_075522_214781_6A3B7AF4 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/24/23 14:09, Lucas Stach wrote: > Am Freitag, dem 24.02.2023 um 13:08 +0100 schrieb Marek Vasut: >> On 2/24/23 10:08, Lucas Stach wrote: >> >> Hi, >> >>>> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c >>>> index 399cb85105a18..77e7dc4eb8cff 100644 >>>> --- a/drivers/soc/imx/imx8m-blk-ctrl.c >>>> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c >>>> @@ -310,7 +310,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) >>>> >>>> dev_set_drvdata(dev, bc); >>>> >>>> - return 0; >>>> + return devm_of_platform_populate(dev); >>> >>> You need to handle the return value, not simply pass it through as the >>> return value of the probe function. When devm_of_platform_populate >>> fails you miss to clean up the genpd provider and detach from the power >>> domains. >> >> Hmmm, but then I cannot use the devm_ variant, can I ? > > Why not? If everything works okay the devm will just take care of > cleaning up the platform devices when the blk-ctrl is removed. If it > fails you just need to roll back the non-devm parts of the blk-ctrl > probe routine. All right, I just sent a V5. Thanks for the clarification. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel