From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9F2C433ED for ; Tue, 13 Apr 2021 20:11:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD2E9613CD for ; Tue, 13 Apr 2021 20:11:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD2E9613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aPoS+C/2kkphYzANONCztH93ZiZc/ywp0S4b5YqhDaI=; b=CF4MCV5c9zHFBGE0hiiPA5eT2 TmM+hrTTgiPXUQ0LdglPYrQnDbe+Koltf+zhiWOHDyrH6YRe804rQMzIgtzon9240oc6q6lZAV1BU VNexN/BOSMt2bys+0LCDsducUfFwkj+w2glWoTciUCgOFibPg943SutkwYyls4ScpnE2bLKJ6P5wG CzvQ+up64F51+SfOVWxbYLyxoRJQr8dDvH5hmM0EShhpu3k/Bt80GCAhoZ0iseeCBD2ocrqGWx0bW lsO/g2xWDIVTZrXIir/ZXCljBxhXqU1h+tBZj+dMOaK01UsNVLNf+f6OgBCrGstWHktd0FjQ4IT43 vClmJ72XQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWPLP-00ALqu-S1; Tue, 13 Apr 2021 20:09:08 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWPLN-00ALqB-BV for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 20:09:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Mime-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=TWVqT+biIie5U0vDKWFF2EaxQEXoONy8pq4DWay0w6Y=; b=PKdpeIlVQJbz4T8HI0oETgx1Nx NV+ZefMSnbQT9K33HR4ER1lNoBQgaJsQcCIHkKS1vlv7sXWKXF5M4cv5LTD9MvWd7qce29VRbmG1Q r9lHnfAFGo7vM9bDlaZu3HcSSx3BNRu5uEh4AZDxlAAXKLsqLcjYQdS4kLY4NhMemk2IFH4602Jc0 JVVVEGeeUkCYkVGG+4QG9qC2qqUKokbvdt9H6bW1d3w5gPh+IdbhMVYzcZDld4Th8wacgcSsKCvFw PtGKRcZEXqK/fcKjKKIVGTlt1P9pp6fH8numuK0jhSY6QQGFNUeVO131lu0JK9/r3wSvwLewF7S/r uNMgRynA==; Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWPLK-007IPy-9T for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 20:09:04 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13DK3PxC175481; Tue, 13 Apr 2021 16:08:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=TWVqT+biIie5U0vDKWFF2EaxQEXoONy8pq4DWay0w6Y=; b=KhXBibXvJI+rnP0pS7hcSgn/qdTnz27Z8935SnwVOtICrV4bsECVWGLwijBpVlso1nKn iMJDVn60rp9U3T8S4Au+fqdswYnzHx3YIWHPCZBJCar22DxE2TUNBFkMWAAjifjofZwt HmvylbpgnqXctUwyY7eqv6rfffPZU7pu7VJopCprRIrjLfkV+4ms8H6anVbKJCnezU5K RI7JMX4O8HVqa8nkU7CyZ0jR4zMqC4eVGWg9ISlFEiKF4qx2nGKMooLae2PjJ6Xyris7 tr9yh9YKnf7Nz+sI0aHJZnx9fr4edK4RAL9Ty6TvBoFQ8H4nW9WJuRwIBiuNpn5HKYp8 kQ== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 37wckq9g7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 16:08:54 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13DK719c024092; Tue, 13 Apr 2021 20:08:54 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma03dal.us.ibm.com with ESMTP id 37u3n9aebm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 20:08:54 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13DK8rhj26542510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Apr 2021 20:08:53 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1DB86A051; Tue, 13 Apr 2021 20:08:52 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9F40F6A047; Tue, 13 Apr 2021 20:08:52 +0000 (GMT) Received: from v0005c16 (unknown [9.211.55.32]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 13 Apr 2021 20:08:52 +0000 (GMT) Message-ID: Subject: Re: [PATCH] fsi: aspeed: Emit fewer barriers in opb operations From: Eddie James To: Joel Stanley , Jeremy Kerr , Andrew Jeffery Cc: linux-fsi@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Date: Tue, 13 Apr 2021 15:08:52 -0500 In-Reply-To: <20210223041737.171274-1-joel@jms.id.au> References: <20210223041737.171274-1-joel@jms.id.au> Organization: IBM X-Mailer: Evolution 3.28.5 (3.28.5-14.el8) Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mnCVsRH21Y0gM829eFc6Q5aqg77Dckpe X-Proofpoint-GUID: mnCVsRH21Y0gM829eFc6Q5aqg77Dckpe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-13_15:2021-04-13, 2021-04-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1011 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104130132 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_130902_685973_822F5E01 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-02-23 at 14:47 +1030, Joel Stanley wrote: > When setting up a read or write to the OPB memory space, we must > perform > five or six AHB writes. The ordering of these up until the trigger > write > does not matter, so use writel_relaxed. Reviewed-by: Eddie James I have also tested this patch on hardware, so Tested-by: Eddie James > > The generated code goes from (Debian GCC 10.2.1-6): > > mov r8, r3 > mcr 15, 0, sl, cr7, cr10, {4} > str sl, [r6, #20] > mcr 15, 0, sl, cr7, cr10, {4} > str r3, [r6, #24] > mcr 15, 0, sl, cr7, cr10, {4} > str r1, [r6, #28] > mcr 15, 0, sl, cr7, cr10, {4} > str r2, [r6, #32] > mcr 15, 0, sl, cr7, cr10, {4} > mov r1, #1 > str r1, [r6, #64] ; 0x40 > mcr 15, 0, sl, cr7, cr10, {4} > str r1, [r6, #4] > > to this: > > str r3, [r7, #20] > str r2, [r7, #24] > str r1, [r7, #28] > str r3, [r7, #64] > mov r8, #0 > mcr 15, 0, r8, cr7, cr10, {4} > str r3, [r7, #4] > > Signed-off-by: Joel Stanley > --- > drivers/fsi/fsi-master-aspeed.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi- > master-aspeed.c > index 90dbe58ca1ed..09fff86b2bac 100644 > --- a/drivers/fsi/fsi-master-aspeed.c > +++ b/drivers/fsi/fsi-master-aspeed.c > @@ -101,11 +101,11 @@ static int __opb_write(struct fsi_master_aspeed > *aspeed, u32 addr, > u32 reg, status; > int ret; > > - writel(CMD_WRITE, base + OPB0_RW); > - writel(transfer_size, base + OPB0_XFER_SIZE); > - writel(addr, base + OPB0_FSI_ADDR); > - writel(val, base + OPB0_FSI_DATA_W); > - writel(0x1, base + OPB_IRQ_CLEAR); > + writel_relaxed(CMD_WRITE, base + OPB0_RW); > + writel_relaxed(transfer_size, base + OPB0_XFER_SIZE); > + writel_relaxed(addr, base + OPB0_FSI_ADDR); > + writel_relaxed(val, base + OPB0_FSI_DATA_W); > + writel_relaxed(0x1, base + OPB_IRQ_CLEAR); > writel(0x1, base + OPB_TRIGGER); > > ret = readl_poll_timeout(base + OPB_IRQ_STATUS, reg, > @@ -149,10 +149,10 @@ static int __opb_read(struct fsi_master_aspeed > *aspeed, uint32_t addr, > u32 result, reg; > int status, ret; > > - writel(CMD_READ, base + OPB0_RW); > - writel(transfer_size, base + OPB0_XFER_SIZE); > - writel(addr, base + OPB0_FSI_ADDR); > - writel(0x1, base + OPB_IRQ_CLEAR); > + writel_relaxed(CMD_READ, base + OPB0_RW); > + writel_relaxed(transfer_size, base + OPB0_XFER_SIZE); > + writel_relaxed(addr, base + OPB0_FSI_ADDR); > + writel_relaxed(0x1, base + OPB_IRQ_CLEAR); > writel(0x1, base + OPB_TRIGGER); > > ret = readl_poll_timeout(base + OPB_IRQ_STATUS, reg, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel