From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: andi@etezian.org, broonie@kernel.org, alim.akhtar@samsung.com,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] spi: Return true/false (not 1/0) from bool function
Date: Thu, 9 Jun 2022 08:36:26 +0200 [thread overview]
Message-ID: <c0062aad-50f2-a9ea-ad04-8af9e70f8bba@linaro.org> (raw)
In-Reply-To: <20220609060323.106095-1-yang.lee@linux.alibaba.com>
On 09/06/2022 08:03, Yang Li wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> function. This fixes the following warnings from coccicheck:
>
> ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function
> 's3c64xx_spi_can_dma' with return type bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
It was reported by coccinelle, not robot, wasn't it?
I cannot find this report. This is an open source work and public
collaboration. The "Reported-by" usually means that the issue was
reported. Usually in public. Can we see the report?
Otherwise adding non-public reports is useless and clutters our
report-credit-system.
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/spi/spi-s3c64xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 82558e37c735..28e7b7cb68a7 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master,
> if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
> return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1;
> } else {
> - return 0;
> + return false;
> }
>
> }
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-09 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 6:03 [PATCH -next] spi: Return true/false (not 1/0) from bool function Yang Li
2022-06-09 6:36 ` Krzysztof Kozlowski [this message]
2022-06-09 15:28 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0062aad-50f2-a9ea-ad04-8af9e70f8bba@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abaci@linux.alibaba.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).