From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70DF9C433EF for ; Thu, 9 Jun 2022 06:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JaCJg2SaJfDfBhSUnQdCLnX/GBZv0oaBYYnuJECElpU=; b=4sE73xzWhpsMDK 3PMeOGRCsLTaQSVEegE3RX5vyaQJmpY8oibHtfoOxkn5NHPlZpH6jq5vFmxY9mKKXO7+oHbqcHgQw nt6m20abzUv7bQKMJtwPzn4s1fbjFhvita7flgUpQYuHFBeN96xoDihoOrvJOrZ9b56fXeiHLD7F6 q3bAOSwB2v2lA6FiOSzvL3y5fV2lZRz4RiJ18iMofSVxemRi0NQoUQXzt/KXWRCggeAeAEsgLWWSo awuNIN3C3Rg4LZ2LgUZ4eG5Y0qxrqnt0aFJ7jFgg6tnQqkwNa7ZzKu+6K2YD8ZkTRAwOMv4kAAmso Bf24he7w+WnDgkfiN6Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzBmW-00H7ns-8D; Thu, 09 Jun 2022 06:36:36 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzBmS-00H7mI-VI for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 06:36:34 +0000 Received: by mail-ed1-x52a.google.com with SMTP id h19so29900928edj.0 for ; Wed, 08 Jun 2022 23:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=NJcB6ULEi06ujOrbXg5DIncgArHtF9TanOoBMremDoQ=; b=VtJkNhAWYfQbqsjEIqLeHUu8ofkD3JeBO5CAZb7XAu6cAU2WkhI/YKTE6hWXet6Uq6 79NRAFd/OHqYqij5QY1xxZshI6ekUmeJe0tTu3BhxnQbpLljmRCEeqMLCsjI72VW7cvL EXVgEEJn5M49qbr0EMje6ivbOqBZ0kpzPVi7GbeuH9HmRuf4SAyYmENok9Iv0l0tAYVK CtuILTdGChDDFgBcROHLcdJsN3dxqq6B0nbuS/tjC0Uv+F3wonK0GJ7IvkjK4nf5iEcr DNHei/sAkbeEqFnRZeLP1jSDWuE5YOkiMF1UNZX18T+KyCZ3DSNrNqH5OLXTWRBaUIK2 oh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NJcB6ULEi06ujOrbXg5DIncgArHtF9TanOoBMremDoQ=; b=Xv5bvjjIbsHPw9VR8mSOJIgijNduHuS/SvK2QtKsbTJ1yn3oiHoaTtn5rLXF+DDBqL YSQZ9M49PAC6OxVFp9vczvUF3GI/ySHeJlkpBc7UnxjhH+FdaQjpuSOVF3RoXD/3AZRf P70VnRkvvyTQ9xX1fwjVkEMF19vtPt578IVEhYqsOnbNU/OrjRhbKjJaqJUW//3xqFrM hvmJx+vkYzRJ3ba9SYUiSyMEy9vZ1OiY8x9ZGgEgTIVEjK7B5ygM66GozLvRr/zKiohl CZi0UYYZnR2QsRQ3UB0XsUFVhRAXYU0XUg4Azy3zVPPqPWz805SxCsM1lmSbKzaSX434 yBDw== X-Gm-Message-State: AOAM533K8c0L9z6VG+GwGuGM6VX/ZXq+s7uZ6/EK/ozTnH8tPfQdl8hK z9SlfCUoEvv91T/qIhfKi+aUsw== X-Google-Smtp-Source: ABdhPJyrrS9vRDWjaFmMAy4TlrvqadM+BD1Szg6LB3GdLycpZnPGz4Dvs0SeaGaMZu6Wd8cJjTPXzA== X-Received: by 2002:a05:6402:43c5:b0:42d:e4f6:d63e with SMTP id p5-20020a05640243c500b0042de4f6d63emr43390497edc.303.1654756588798; Wed, 08 Jun 2022 23:36:28 -0700 (PDT) Received: from [192.168.0.194] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z3-20020a170906270300b00704a5c530ccsm10311579ejc.162.2022.06.08.23.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 23:36:27 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 08:36:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH -next] spi: Return true/false (not 1/0) from bool function Content-Language: en-US To: Yang Li Cc: andi@etezian.org, broonie@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20220609060323.106095-1-yang.lee@linux.alibaba.com> From: Krzysztof Kozlowski In-Reply-To: <20220609060323.106095-1-yang.lee@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_233633_064124_F853807D X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2022 08:03, Yang Li wrote: > Return boolean values ("true" or "false") instead of 1 or 0 from bool > function. This fixes the following warnings from coccicheck: > > ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function > 's3c64xx_spi_can_dma' with return type bool > > Reported-by: Abaci Robot It was reported by coccinelle, not robot, wasn't it? I cannot find this report. This is an open source work and public collaboration. The "Reported-by" usually means that the issue was reported. Usually in public. Can we see the report? Otherwise adding non-public reports is useless and clutters our report-credit-system. > Signed-off-by: Yang Li > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 82558e37c735..28e7b7cb68a7 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master, > if (sdd->rx_dma.ch && sdd->tx_dma.ch) { > return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1; > } else { > - return 0; > + return false; > } > > } Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel