From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6489EC4363A for ; Fri, 30 Oct 2020 11:44:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29862076E for ; Fri, 30 Oct 2020 11:44:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P9jn+3NU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29862076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KhWEitmKrcSGPkRGLc2aOPoCmYgkgpAwbP0u+tFLw0k=; b=P9jn+3NUx2x1+1CEQCmoAV151 tPBCuW2R0HnTVzBBVeY8m6gGor2UNcZ/GDBD5PcHLzZWqF5uqGz7oLpswdRuqQhNpLri8slfUcHN5 PDJ91Pp0VJg4FHepg2kqKOE69ALoXy6ZDYr8iEPYrGxetHJKd0OahLpzjMBorWcEwbEomtHT95W8e IirJ49Aeksa/wu9+5egMf0OuL+AuXBsy0VxTRLwNtMG/YEA2Px6yIJsY3VFdJwHyaP5TbS08ou/dq ZieZCrXGCk5gsLm19UG1dzXjDNfahhtKkTrCqgsU8xeOiYF74IgkLqtJ2m4h0epl8q6Io/g2SXNc9 KgCTccvgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYSp0-0004Wb-PK; Fri, 30 Oct 2020 11:43:54 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYSoe-0004PP-Re; Fri, 30 Oct 2020 11:43:46 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id F132C1F45EBC Subject: Re: [PATCH v2 1/2] dt-bindings: power: Add MT8167 power domains To: Fabien Parent , Rob Herring , Matthias Brugger , Weiyi Lu References: <20201027131122.374046-1-fparent@baylibre.com> From: Enric Balletbo i Serra Message-ID: Date: Fri, 30 Oct 2020 12:43:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201027131122.374046-1-fparent@baylibre.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_074333_195598_B613613D X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabien, Thank you for the patch and base it on [0] On 27/10/20 14:11, Fabien Parent wrote: > Add power domains dt-bindings for MT8167. > > Signed-off-by: Fabien Parent > --- > > This patch depends on the SCPSYS PM domains driver [0]. > > v2: > * Implement on top of new SCPSYS PM domains driver [0] > > [0] https://patchwork.kernel.org/project/linux-mediatek/list/?series=370737 > > .../power/mediatek,power-controller.yaml | 2 ++ > include/dt-bindings/power/mt8167-power.h | 18 ++++++++++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 include/dt-bindings/power/mt8167-power.h > > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > index 0318ffb1133c..73e5452c3a5d 100644 > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > @@ -23,6 +23,7 @@ properties: > > compatible: > enum: > + - mediatek,mt8167-power-controller > - mediatek,mt8173-power-controller > - mediatek,mt8183-power-controller > - mediatek,mt8192-power-controller > @@ -59,6 +60,7 @@ patternProperties: > reg: > description: | > Power domain index. Valid values are defined in: > + "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain. > "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain. > "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain. > "include/dt-bindings/power/mt8192-power.h" - for MT8192 type power domain. > diff --git a/include/dt-bindings/power/mt8167-power.h b/include/dt-bindings/power/mt8167-power.h > new file mode 100644 > index 000000000000..7e3babfc2eef > --- /dev/null > +++ b/include/dt-bindings/power/mt8167-power.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: GPL-2.0 > + * > + * Copyright (c) 2020 MediaTek Inc. > + */ > + > +#ifndef _DT_BINDINGS_POWER_MT8167_POWER_H > +#define _DT_BINDINGS_POWER_MT8167_POWER_H > + > +#define MT8167_POWER_DOMAIN_MM 0 > +#define MT8167_POWER_DOMAIN_DISP 0 Is that correct? Both domains have the same index? > +#define MT8167_POWER_DOMAIN_VDEC 1 > +#define MT8167_POWER_DOMAIN_ISP 2 > +#define MT8167_POWER_DOMAIN_CONN 3 > +#define MT8167_POWER_DOMAIN_MFG_ASYNC 4 > +#define MT8167_POWER_DOMAIN_MFG_2D 5 > +#define MT8167_POWER_DOMAIN_MFG 6 > + > +#endif /* _DT_BINDINGS_POWER_MT8167_POWER_H */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel