From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] soc: ti: knav_qmss_queue: use of_property_read_bool
Date: Fri, 5 Aug 2016 13:47:25 +0100 [thread overview]
Message-ID: <c010a500-87ce-19ad-0109-f57eba3c6981@arm.com> (raw)
In-Reply-To: <1470387411-15879-11-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
On 05/08/16 09:56, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
This caught my eye since Rob told me off for doing the same recently[1].
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..56b5d7c 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1240,7 +1240,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
> if (of_get_property(node, "qalloc-by-id", NULL))
According to the binding, "qalloc-by-id" _is_ a boolean property, so
this one really does deserve to be of_property_read_bool()...
> range->flags |= RANGE_RESERVED;
>
> - if (of_get_property(node, "accumulator", NULL)) {
> + if (of_property_read_bool(node, "accumulator")) {
...whereas "accumulator" must have a value, so this isn't technically
appropriate. In general, most of these "if the property exists, read the
property and do stuff" checks are probably a sign of code that could be
simplified by refactoring the "do stuff" step to just specifically
handle the "read the property" step returning -EINVAL when it's not present.
Robin.
[1]:https://www.mail-archive.com/iommu at lists.linux-foundation.org/msg13375.html
> ret = knav_init_acc_range(kdev, node, range);
> if (ret < 0) {
> devm_kfree(dev, range);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2016-08-05 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 12:47 ` Robin Murphy [this message]
2016-08-05 12:59 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c010a500-87ce-19ad-0109-f57eba3c6981@arm.com \
--to=robin.murphy@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox