From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13480C6FD1F for ; Tue, 26 Mar 2024 16:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F1OXbOQyUSMNCqsSTmwwAg1NxBayPrYVJye+GB8M25g=; b=s1fKjThpOyYkXO 20YVlyt2kYQVxFIMBRxuAND4Fy22zUmX5DHXk5eGAkSxo/243lXmVvxhg5SA2KfsgWRwLJW7/l7JA Qm5Rkv7n03/DfxOdXCFA26QabXQEGi7KNANXBE2yaG78EvMlQsfqCCIFzX85MRxWEtX86q5DZ0tkM jaEAMe954wRdTHdUAAr4TFSKApVyXw8q9rOcTzS5zIcxQxqHrhtCAaboiX9KQS6EsBeTzBC9wIm/w 7508Fp8uU+0Xq4n3sASHZPFaKxqc8jMWbusQIdtM/HGmZXSJM/5FoLQKWM+8M9TiucCDguQItNBc5 gthx1XMc0GVpty79fesw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp9Fe-00000005MoH-1NwJ; Tue, 26 Mar 2024 16:02:14 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp85y-00000004ywI-40Du for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 14:48:14 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42QEm1EK121149; Tue, 26 Mar 2024 09:48:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1711464481; bh=r5kO6gHMdss7KBmKCinOi5uDLA/3tf7mzyqUper/ros=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=aX8o8gh7KKSVG4M7zvZf6QdRV0MxzOhc7xOYlTaQ09TlWUVrmBPwsevCzu0CVAtlS AC+bAqo8Px8MIFR6Mn8IrXfNVy+BndDAQ//MSqChtLf8djsMse1NL205ti9ThBmGco uxQ+49u6vtwOcpq66Fo7x5M4wrs0FM1snZK1xZm4= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42QEm1qk022383 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Mar 2024 09:48:01 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 26 Mar 2024 09:48:01 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 26 Mar 2024 09:48:01 -0500 Received: from localhost (uda0492258.dhcp.ti.com [172.24.227.9]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42QEm0PX024629; Tue, 26 Mar 2024 09:48:00 -0500 Date: Tue, 26 Mar 2024 20:17:59 +0530 From: Siddharth Vadapalli To: Niklas Cassel CC: Siddharth Vadapalli , , , , , , , , , , , , , Subject: Re: [PATCH v5] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: References: <20240326111905.2369778-1-s-vadapalli@ti.com> <2e40b30d-b063-48ac-a566-f66eb2788003@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2e40b30d-b063-48ac-a566-f66eb2788003@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_074811_380311_FB59C599 X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 08:00:04PM +0530, Siddharth Vadapalli wrote: > On Tue, Mar 26, 2024 at 02:56:26PM +0100, Niklas Cassel wrote: > > On Tue, Mar 26, 2024 at 04:49:05PM +0530, Siddharth Vadapalli wrote: > > > In the process of converting .scan_bus() callbacks to .add_bus(), the > > > ks_pcie_v3_65_scan_bus() function was changed to ks_pcie_v3_65_add_bus(). > > > The .scan_bus() method belonged to ks_pcie_host_ops which was specific > > > to controller version 3.65a, while the .add_bus() method had been added > > > to ks_pcie_ops which is shared between the controller versions 3.65a and > > > 4.90a. Neither the older ks_pcie_v3_65_scan_bus() method, nor the newer > > > ks_pcie_v3_65_add_bus() method are applicable to the controller version > > > 4.90a which is present in AM654x SoCs. > > > > > ... > > > > + } while (val & DBI_CS2); > > > +} > > > + > > > static int ks_pcie_msi_host_init(struct dw_pcie_rp *pp) > > > { > > > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > > + struct keystone_pcie *ks_pcie = to_keystone_pcie(pci); > > > + > > > + /* Configure and set up BAR0 */ > > > + ks_pcie_set_dbi_mode(ks_pcie); > > > + > > > + /* Enable BAR0 */ > > > + dw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_0, 1); > > > + dw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_0, SZ_4K - 1); > > > + > > > + ks_pcie_clear_dbi_mode(ks_pcie); > > > + > > > + /* > > > + * For BAR0, just setting bus address for inbound writes (MSI) should > > > + * be sufficient. Use physical address to avoid any conflicts. > > > + */ > > > > This comment seems to have wrong indentation. > > With that fixed: > > > > Reviewed-by: Niklas Cassel > > I will fix it and post the v6 patch. I have posted the v6 patch at: https://lore.kernel.org/r/20240326144258.2404433-1-s-vadapalli@ti.com/ Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel