From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66F13EB64D7 for ; Tue, 20 Jun 2023 06:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GyxTsw82+HvM1yDWs1BV0ceZeTBl1aUrJG/bTmrsU7Y=; b=ih3hAKZPnS7J2X 8Lud2q1w2D3MbE4bc91EQJKz0NQs12Y4m60Fs2AokmA0fdbUj+BMRkUIH1UaOcDuZPaewkutL9UCA 37c9pSisvJ6SnhTm5AM1qk7rvYihtUxs6my12JTISUfYN8DuBlnlUnwzjxsrPzP8gwgJfdJo/ZFG+ jG84uPyIBU5a+TWqTutkcyzP/JaMWPrgYQRqqMaI2eC3Mb5NJiSqcpPHWCgmCDZ72cdJLT3m+rh4W Gq3g2nLDnKJYrHaUWlsp3MRtIzO0bTDTcPZZSi8JyluSfLpkGxo70n6Thua0sHu+GnwNoblTf3qvg LD9xX0hvA02dQ/638tbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBUiA-00AGIq-1Y; Tue, 20 Jun 2023 06:19:30 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBUi7-00AGHH-1b for linux-arm-kernel@lists.infradead.org; Tue, 20 Jun 2023 06:19:28 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4f841b7a697so5172312e87.3 for ; Mon, 19 Jun 2023 23:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687241965; x=1689833965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oO29vTyH00u9Cnemrj5+OqL3rJnNJVkGd7KyzUdckJc=; b=hhdBu0W0qX/0/mlBgaMXaWbidX+xQtAYl6qYY+nmVWaza8SKXp8lBxfRt5xhYLWeKs PhgczPVyujwWmSC3ENjjPyOBy68r7jBItGsyQJfBSfKe1Z0p1sFMZFGhHgKMtOcOPlRY L1u/Ip5qIvpvReKWaCRb250l26d6M5goqG8H4r9Sk+OnFl/2OuvTszgDkCGu3VqqyLBI ZNEdyBYQ+amc3AxWZ9rzjXyTNWYbUQj2yzg/P3fX3AUn2tgMr40B0JdBvQ0FX1amZZim UgZgYdaInNdGZ4WUU/IFcmKxqEWecp5ryF3B2ms5whBegxaZQ91ilzhe5laJK9Ri9jro aSmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687241965; x=1689833965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oO29vTyH00u9Cnemrj5+OqL3rJnNJVkGd7KyzUdckJc=; b=TtwE8vTaljwIQIdDTboinW9Be6GNwjBRyWISjbwb/B/7N95IYLxDWrGVGDGkKAaNft klbCoy8JoHA7cnggnk2PLCMv6UUKIsrN3Q5uNSCCnPOKN9esOIEpaLEM2TS2+SGWrRqA tK8XCKv0Tmc0rG6AfXsA2tNz1b9jLd6D3Wfi2n9t4YFxNvcwoCFcujUBB6ssDGD5ZFib MUcvU576BWPp3z61YrwqZDSs5FRXVgevFyu6RQqJDWp2/abdL5NewrdOF6D/dbD30b4b kTkEOWuUUV814ybq/Kst/xVjcAhS4PiMSoiLW2U6lIYtR7BPmGYO8utKEUo5SFOJeTTa 9AeA== X-Gm-Message-State: AC+VfDy15mVJK38ryJC8EVAj2UoKGFPZTygboqPMK1Vs90KV7KLRKyiL M5KzB47/0rx3psyL1fxAFVUtUQ== X-Google-Smtp-Source: ACHHUZ7usY0XPsrJHRsdCyO8q/9zfJ/EGU8VDFSPYhYiP4eZgWJnkQnPQtutOJF8jpavCoGfWRglig== X-Received: by 2002:a19:6909:0:b0:4f8:6d54:72fb with SMTP id e9-20020a196909000000b004f86d5472fbmr2856355lfc.62.1687241965041; Mon, 19 Jun 2023 23:19:25 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id x7-20020a5d54c7000000b0031270cf1904sm1181896wrv.59.2023.06.19.23.19.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 23:19:24 -0700 (PDT) Message-ID: Date: Tue, 20 Jun 2023 08:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc To: Furkan Kardame , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, heiko@sntech.de, broonie@kernel.org, deller@gmx.de, dsterba@suse.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230619184856.23066-1-f.kardame@manjaro.org> <20230619184856.23066-3-f.kardame@manjaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230619184856.23066-3-f.kardame@manjaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230619_231927_562143_DD8034EA X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/06/2023 20:48, Furkan Kardame wrote: > Add dts for Firefly Station P2. > Working IO: > * eMMC > * HDMI > * LAN > * LED > * SD Card > * UART > * USB2 > * USB3 ... > + }; > + > + hdmi-con { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; Missing indentation. ... > + > + vcc3v3_lcd0_n: vcc3v3-lcd0-n-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_lcd0_n"; > + regulator-boot-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; How do you turn this regulator off in suspend? > + }; > + }; > + > + vcc3v3_lcd1_n: vcc3v3-lcd1-n-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_lcd1_n"; > + regulator-boot-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; Same question here. > + }; > + }; > +}; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel