From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 547BDC43334 for ; Fri, 24 Jun 2022 18:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hMo2Q126a1dESp5Ugmg8bHDREiYgcq+imRY946WAmHA=; b=u9ZJ/iT78PVY7Z ebeHsr5aW1GTqFHuh6sanywD4qow4WAPSAGeVOe9RlSjkdgjvT3nhdO0tf7CWA6lU6yQ+FkMxrxek xBgwKuKau8+cTsXKanKDsqBhZb0wccdLemBaT3+8fK2n7ebMMaGS/GMt+RfV2sJK6tUgGHRhjQgue eO1QGDONpHpqmp5YWSAYlrr5qpY9hBhB8lUquxtfmzUm8auN5DfA/PZzIWb/5G5Z92jABktoyP4Sh cBCIplFS6YtkUz/rePlC3Tvv/W8O4BdQD6DtCg4/pyW/TS5Gq9UBSSuC4XCysOfi4V47Wk6CrVOP5 5Ot1aRVWF6ONbhKj/y7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4niv-003PPZ-NZ; Fri, 24 Jun 2022 18:08:05 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4nis-003POP-Uq for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 18:08:04 +0000 Received: by mail-wr1-x42f.google.com with SMTP id v14so4144630wra.5 for ; Fri, 24 Jun 2022 11:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JQitULWmHnKy7C2KWjW3JWCf8vDb5NvNlwl4b24k9NQ=; b=yQ289iPIrenzsMATI9KyJ7iKpC12z1HDpCP3uaB+If+6X4HrWwmpIVkXWJy2rRLTSj DsFX84I6XSTweQtQPxPiS3ZCjz3CJji+hv6qyGcZoQeWZjKzJR21XVlOXeqwOEfQx73N BL8MXnEBQYKoqGZLvi8kVDT64A4UBxAhvtZ6cx26TzpXDaYJmjI5ZZIf2dMaDrLRxLai 1d3UhzWObsLmTg96qpGBmZqp/8hu1W5wHxbQSfYmWi+KZxFQkNv2y3aFInAskYhRd4WN tjh7GLS8nlPM6hTxheACc5aLBlB8OCk0JuP/6bp9gKYkbEFxFekUt24Wa0vfAcMgPsc1 UYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JQitULWmHnKy7C2KWjW3JWCf8vDb5NvNlwl4b24k9NQ=; b=0D4whW0B8iyhlhHHavrUP9KErB37tHAgdi3Q8KvS3gvF2ey3b3C/7YMNLY7+xIsM2M q5Cuwo6m0DoMdVA7ZRg0seGU/YOViafeyRGfmW9jlvNpNPP4GhBpzhw/YkBhTUCoqN3S BUFj6tFZnzp1tiEghewP2wXd3k83+wDl4hW5CWlNkhKq0ByC8PqDXDp5TeGmO6Bg5mF3 wshL6eFHIQ2sk2KNJS+uOZ6ll3bgtJlazfVmhVamq2gpLZq3oksNxqWmfqmc4a2YaDFl bVGIYWL64m2P4h0PaNEfDlogPuHx4QgFGuY2WeVJvwGBxnT6EO9luAU3BH+pIsmbn1W5 VFAw== X-Gm-Message-State: AJIora+Lqf3TIpmMRtyf5XOSaMD6tdw4PT/ZBhLk5z5jTx4W/NmPGm7B jQ0k+ynluRyoLOeIDryiRs+uFQ== X-Google-Smtp-Source: AGRyM1vH2dwrQTE+lvYQLwlqgfGnCgkakQOQnLE1QU3ILOlC7Duc8q7H8ZEN76zExDlSPxpr7QuXhA== X-Received: by 2002:a05:6000:18a9:b0:218:7791:a9ad with SMTP id b9-20020a05600018a900b002187791a9admr438347wri.116.1656094079135; Fri, 24 Jun 2022 11:07:59 -0700 (PDT) Received: from [192.168.0.237] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g4-20020a5d5544000000b0021a39f5ba3bsm3004772wrw.7.2022.06.24.11.07.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 11:07:58 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 20:07:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: pci-exynos.c phy_init() usage Content-Language: en-US To: Bjorn Helgaas , Jaehoon Chung , Jingoo Han Cc: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Alim Akhtar , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220624173541.GA1543581@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220624173541.GA1543581@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_110803_036731_2D5719AD X-CRM114-Status: UNSURE ( 8.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/2022 19:35, Bjorn Helgaas wrote: > In exynos_pcie_host_init() [1], we call: > > phy_reset(ep->phy); > phy_power_on(ep->phy); > phy_init(ep->phy); > > The phy_init() function comment [2] says it must be called before > phy_power_on(). Is exynos doing this backwards? Looks like. I don't have Exynos hardware with a PCI, so cannot test/fix/verify. Luckily for Exynos ;-) it's not alone in this pattern: drivers/net/ethernet/marvell/sky2.c drivers/usb/dwc2/platform.c > > Bjorn > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel