From: Markus Elfring <Markus.Elfring@web.de>
To: Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Cc: Christophe Leroy <chleroy@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Roy Pledge <Roy.Pledge@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [v2 2/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_create()
Date: Mon, 27 Jul 2026 15:14:54 +0200 [thread overview]
Message-ID: <c0cb0888-f37e-4c22-8763-39928385396c@web.de> (raw)
In-Reply-To: <lzwhee46xmnhgr2vjwzuoe2ysmlqavhpyod5kn67avwockpzin@dq2pbhluryme>
>> Scope-based resource management became supported for some
>> programming interfaces by contributions of Peter Zijlstra on 2023-05-26.
>> See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:
>> Introduce __cleanup() based infrastructure").
>>
>> * Thus use the attribute “__free(kfree)”.
>>
>> * Omit two kfree() calls accordingly.
>>
>> * Reduce the scopes for the local variables “obj”
>> and “qman_256_cycles_per_ns”.
>
> Remove these changes. All variables should be defined at the start of
> the function, especially since there is no strong reason not to.
Can such a feedback be also interpreted in the way that you have got still difficulties
with complete support of scope-based resource management?
Regards,
Markus
next prev parent reply other threads:[~2026-07-27 13:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:02 [PATCH] soc: fsl: dpio: Use common error handling code in two functions Markus Elfring
2026-07-04 9:19 ` Christophe Leroy (CS GROUP)
2026-07-04 10:11 ` Markus Elfring
2026-07-06 10:36 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management " Markus Elfring
2026-07-06 10:38 ` [PATCH v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create() Markus Elfring
2026-07-27 11:31 ` Dan Carpenter
2026-07-27 12:08 ` Ioana Ciornei
2026-07-27 12:24 ` [v2 " Markus Elfring
2026-07-27 12:46 ` Ioana Ciornei
2026-07-27 12:52 ` Markus Elfring
2026-07-06 10:40 ` [PATCH v2 2/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_create() Markus Elfring
2026-07-27 11:32 ` Dan Carpenter
2026-07-27 12:14 ` [v2 " Markus Elfring
2026-07-27 12:09 ` [PATCH v2 " Ioana Ciornei
2026-07-27 13:14 ` Markus Elfring [this message]
2026-07-27 9:57 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management in two functions Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0cb0888-f37e-4c22-8763-39928385396c@web.de \
--to=markus.elfring@web.de \
--cc=Roy.Pledge@nxp.com \
--cc=chleroy@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox