linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: Georgi Djakov <georgi.djakov@linaro.org>,
	Leonard Crestez <cdleonard@gmail.com>,
	akashast@codeaurora.org, Shawn Guo <shawnguo@kernel.org>,
	kernel@pengutronix.de
Cc: NXP Linux Team <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: question: interconnect: changes in 5.10 / imx8mq ?
Date: Mon, 30 Nov 2020 21:34:11 +0100	[thread overview]
Message-ID: <c110af2f-635a-71f5-735c-1346b7af0ef9@posteo.de> (raw)

hi,

what I've used on v5.9 on imx8mq in order to hook up dram frequency to 
interconnect (via mxsfb/lcdif) - and has worked fine - is:

* add the NOC node description with "#interconnect-cells = <1>;"
https://source.puri.sm/martin.kepplinger/linux-next/-/commit/8a6b8486a3e94e2886bde01000f9532e03d243a4
(original author is Leonard. I'll preserve authorship when submitting)

* add "interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
" to lcdif:
https://source.puri.sm/martin.kepplinger/linux-next/-/commit/6c4bbcdc315da01a9dc8bbda36290587ce1ed33a

* hook up the driver
https://source.puri.sm/martin.kepplinger/linux-next/-/commit/63679bcfa586578fc4345010a30ff7ac1af4c3c6
(I know this doesn't use devm_* and has to be cleaned up)


on v5.9 this would nicely have the driver's value set:

  node                                  tag          avg         peak
--------------------------------------------------------------------
NOC                                                   0       678900
   30320000.lcd-controller                0            0       678900
DRAM                                                  0       678900
   30320000.lcd-controller                0            0       678900
(...)

now on 5.10, I get dram always running at the highest speed because the 
*node* "requests" a lot, see the interconnect_summary:

  node                                  tag          avg         peak
--------------------------------------------------------------------
NOC                                          2147483647   2147483647
   30320000.lcd-controller                0            0       678900
DRAM                                         2147483647   2147483647
   30320000.lcd-controller                0            0       678900
(...)

the above is with screen on of course, as can be seen by the value from 
the driver. That *is* set to 0 as expected, but still, the "2147483647" 
remains:

  node                                  tag          avg         peak
--------------------------------------------------------------------
NOC                                          2147483647   2147483647
   30320000.lcd-controller                0            0            0
DRAM                                         2147483647   2147483647
   30320000.lcd-controller                0            0            0
(...)



what am I doing wrong on recent kernels?

thanks a lot!

                                   martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-11-30 20:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 20:34 Martin Kepplinger [this message]
2020-11-30 21:18 ` question: interconnect: changes in 5.10 / imx8mq ? Georgi Djakov
2020-11-30 22:10   ` Martin Kepplinger
2020-12-01  0:36     ` Martin Kepplinger
2020-12-01  9:10       ` Georgi Djakov
2020-12-01 11:35         ` Martin Kepplinger
2020-12-01 12:35           ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c110af2f-635a-71f5-735c-1346b7af0ef9@posteo.de \
    --to=martink@posteo.de \
    --cc=akashast@codeaurora.org \
    --cc=cdleonard@gmail.com \
    --cc=georgi.djakov@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).