From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correctlinkage with CONFIG_THUMB2_KERNEL
Date: Tue, 7 Dec 2010 11:59:26 +0530 [thread overview]
Message-ID: <c1241a78873c5a18f5e7b4df96ac2143@mail.gmail.com> (raw)
In-Reply-To: <1291656937-24992-4-git-send-email-dave.martin@linaro.org>
> -----Original Message-----
> From: linaro-dev-bounces at lists.linaro.org [mailto:linaro-dev-
> bounces at lists.linaro.org] On Behalf Of Dave Martin
> Sent: Monday, December 06, 2010 11:06 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: Tony Lindgren; Dave Martin; linux-omap at vger.kernel.org; linaro-
> dev at lists.linaro.org
> Subject: [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for
> correctlinkage with CONFIG_THUMB2_KERNEL
>
> almost all code for v7+ platforms) is deprecated/incorrect.
>
> ENDPROC() tags the affected symbol as a function symbol, which will
> ensure that link-time fixups don't accidentally switch to the
> wrong instruction set.
>
> omap_secondary_startup might still need to be changed to ARM,
> depending on the compatibility status of bootloaders.
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> ---
> KernelVersion: 2.6.37-rc4
Looks ok to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> arch/arm/mach-omap2/omap-headsmp.S | 2 +-
> arch/arm/mach-omap2/omap44xx-smc.S | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap-headsmp.S b/arch/arm/mach-
> omap2/omap-headsmp.S
> index 6ae937a..4ee6aec 100644
> --- a/arch/arm/mach-omap2/omap-headsmp.S
> +++ b/arch/arm/mach-omap2/omap-headsmp.S
> @@ -45,5 +45,5 @@ hold: ldr r12,=0x103
> * should now contain the SVC stack for this core
> */
> b secondary_startup
> -END(omap_secondary_startup)
> +ENDPROC(omap_secondary_startup)
>
> diff --git a/arch/arm/mach-omap2/omap44xx-smc.S b/arch/arm/mach-
> omap2/omap44xx-smc.S
> index 1980dc3..e69d37d 100644
> --- a/arch/arm/mach-omap2/omap44xx-smc.S
> +++ b/arch/arm/mach-omap2/omap44xx-smc.S
> @@ -29,7 +29,7 @@ ENTRY(omap_smc1)
> dsb
> smc #0
> ldmfd sp!, {r2-r12, pc}
> -END(omap_smc1)
> +ENDPROC(omap_smc1)
>
> ENTRY(omap_modify_auxcoreboot0)
> stmfd sp!, {r1-r12, lr}
> @@ -37,7 +37,7 @@ ENTRY(omap_modify_auxcoreboot0)
> dsb
> smc #0
> ldmfd sp!, {r1-r12, pc}
> -END(omap_modify_auxcoreboot0)
> +ENDPROC(omap_modify_auxcoreboot0)
>
> ENTRY(omap_auxcoreboot_addr)
> stmfd sp!, {r2-r12, lr}
> @@ -45,7 +45,7 @@ ENTRY(omap_auxcoreboot_addr)
> dsb
> smc #0
> ldmfd sp!, {r2-r12, pc}
> -END(omap_auxcoreboot_addr)
> +ENDPROC(omap_auxcoreboot_addr)
>
> ENTRY(omap_read_auxcoreboot0)
> stmfd sp!, {r2-r12, lr}
> @@ -54,4 +54,4 @@ ENTRY(omap_read_auxcoreboot0)
> smc #0
> mov r0, r0, lsr #9
> ldmfd sp!, {r2-r12, pc}
> -END(omap_read_auxcoreboot0)
> +ENDPROC(omap_read_auxcoreboot0)
> --
> 1.7.1
>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev at lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
prev parent reply other threads:[~2010-12-07 6:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 17:35 [PATCH v2 0/3] ARM: omap: Thumb-2 kernel compatibility fixes Dave Martin
2010-12-06 17:35 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-06 18:17 ` Catalin Marinas
2010-12-06 18:41 ` Dave Martin
2010-12-07 6:31 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL Santosh Shilimkar
2010-12-07 10:16 ` Dave Martin
2010-12-07 11:59 ` Jean Pihet
2010-12-07 14:53 ` Dave Martin
2010-12-07 14:55 ` Dave Martin
2010-12-07 19:15 ` Nicolas Pitre
2010-12-08 10:24 ` Dave Martin
2010-12-08 16:56 ` Nicolas Pitre
2010-12-06 17:35 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL Dave Martin
2010-12-07 6:28 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL Santosh Shilimkar
2010-12-07 16:50 ` Dave Martin
2010-12-07 19:29 ` Russell King - ARM Linux
2010-12-08 11:40 ` Dave Martin
2010-12-08 5:57 ` Santosh Shilimkar
2010-12-08 5:59 ` Santosh Shilimkar
2010-12-08 10:40 ` Dave Martin
2010-12-08 10:45 ` Santosh Shilimkar
2010-12-08 11:05 ` Dave Martin
2010-12-08 11:10 ` Santosh Shilimkar
2010-12-08 11:25 ` Dave Martin
2010-12-06 17:35 ` [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-07 6:29 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1241a78873c5a18f5e7b4df96ac2143@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).