From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Daniel Drake <dan@reactivated.net>,
maz@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, bcm-kernel-feedback-list@broadcom.com
Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com,
andrea.porta@suse.com
Subject: Re: [PATCH] arm64: dts: broadcom: bcm2712: Remove non-functional EL2 virtual timer
Date: Mon, 13 Jul 2026 09:15:14 -0700 [thread overview]
Message-ID: <c131f3fa-1918-49ec-b083-11ceb03eb40e@broadcom.com> (raw)
In-Reply-To: <20260619204832.586079-1-dan@reactivated.net>
On 6/19/26 13:48, Daniel Drake wrote:
> Commit d87773de9efe1 ("clocksource/drivers/arm_arch_timer: Default to
> EL2 virtual timer when running VHE") causes boot to hang on
> Raspberry Pi 5. The newly-selected EL2 virtual timer does not generate
> any interrupts, even though the GIC_DIST_ENABLE_SET flag has been
> confirmed set via readback.
>
> The reasons for this failure are unknown, however it is likely that
> this timer was never tested. Raspberry Pi's original devicetree did
> not include this timer interrupt; it was only introduced via a
> suggestion[1] made in code review as part of the upstreaming process.
> (Current RPi firmware versions do include this timer, but only because
> they rebased on top of the upstreamed devicetree starting with
> Linux 6.12)
>
> Until more is known about this non-firing timer interrupt, remove
> the devicetree entry to enable RPi5 devices to boot.
>
> [1] https://lore.kernel.org/all/12363be5b11c752b7155cc0c416fdfd2@kernel.org/
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/all/ea15cce1-b393-43f6-8d58-3d6f90f0c0cd@samsung.com/
> Signed-off-by: Daniel Drake <dan@reactivated.net>
We know why now: the interrupt line was never connected in the first
place as this was not identified as being a requirement *sigh*.
Can you amend your patch with that detail, re-submit and add a:
Fixes: faa3381267d0 ("arm64: dts: broadcom: Add minimal support for
Raspberry Pi 5")
Thank you Daniel!
--
Florian
prev parent reply other threads:[~2026-07-13 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260619204921eucas1p1c4a9fe8e8a41f552d4637dee2b26f4e4@eucas1p1.samsung.com>
2026-06-19 20:48 ` [PATCH] arm64: dts: broadcom: bcm2712: Remove non-functional EL2 virtual timer Daniel Drake
2026-06-19 21:04 ` Marek Szyprowski
2026-06-20 8:49 ` Marc Zyngier
2026-06-21 20:03 ` Florian Fainelli
2026-06-21 20:58 ` Daniel Drake
2026-06-22 6:20 ` Marek Szyprowski
2026-07-06 21:49 ` Daniel Drake
2026-07-09 13:18 ` Florian Fainelli
2026-07-10 8:17 ` Marc Zyngier
2026-07-13 16:15 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c131f3fa-1918-49ec-b083-11ceb03eb40e@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dan@reactivated.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox