From: Marek Vasut <marex@denx.de>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node
Date: Fri, 1 Sep 2023 17:49:44 +0200 [thread overview]
Message-ID: <c14a6e7b-3bfc-2dd9-378e-fb587e3e03e8@denx.de> (raw)
In-Reply-To: <CAHCN7xJpug+ap4koX_3w_YTvHF9NC8-2S0f69SsDNY_6T+rcPQ@mail.gmail.com>
On 9/1/23 13:06, Adam Ford wrote:
> On Thu, Aug 31, 2023 at 4:53 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 8/31/23 06:44, Adam Ford wrote:
>>> The i.MX8MP has a micfil controller which is used for interfacing
>>> with a pulse density microphone. Add the node and mark it as
>>> disabled by default.
>>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>> ---
>>> V3: The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is
>>> called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out.
>>>
>>> V2: No change
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> index 3167706d81e1..341fd0369ce9 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> @@ -1479,6 +1479,27 @@ easrc: easrc@30c90000 {
>>> fsl,asrc-format = <2>;
>>> status = "disabled";
>>> };
>>> +
>>> + micfil: audio-controller@30ca0000 {
>>> + compatible = "fsl,imx8mp-micfil";
>>> + reg = <0x30ca0000 0x10000>;
>>> + #sound-dai-cells = <0>;
>>> + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_IPG>,
>>> + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_SEL>,
>>> + <&clk IMX8MP_AUDIO_PLL1_OUT>,
>>> + <&clk IMX8MP_AUDIO_PLL2_OUT>,
>>> + <&clk IMX8MP_CLK_EXT3>;
>>> + clock-names = "ipg_clk", "ipg_clk_app",
>>> + "pll8k", "pll11k", "clkext3";
>>> + dmas = <&sdma2 24 25 0x80000000>;
>>> + dma-names = "rx";
>>
>> Is dma-names really required if there is only a single DMA channel in DT ?
>
> I would normally agree with you, the DT binding file shows it's
> required, and the driver looks like it's searching for a channel name
> called 'rx'
Maybe something that can be improved both in the driver and bindings ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-01 21:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 4:44 [PATCH V3 1/3] arm64: dts: imx8mp: Add easrc node Adam Ford
2023-08-31 4:44 ` [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node Adam Ford
2023-08-31 21:53 ` Marek Vasut
2023-09-01 11:06 ` Adam Ford
2023-09-01 15:49 ` Marek Vasut [this message]
2023-09-25 1:12 ` Shawn Guo
2023-10-04 1:12 ` Fabio Estevam
2023-10-04 12:15 ` Adam Ford
2023-08-31 4:44 ` [PATCH V3 3/3] clk: imx8mp: Remove non-existent IMX8MP_CLK_AUDIOMIX_PDM_ROOT Adam Ford
2023-08-31 18:25 ` Rob Herring
2023-08-31 21:52 ` [PATCH V3 1/3] arm64: dts: imx8mp: Add easrc node Marek Vasut
2023-09-01 11:02 ` Adam Ford
2023-09-01 15:47 ` Marek Vasut
2023-09-25 1:07 ` Shawn Guo
2023-09-25 1:12 ` Shawn Guo
2023-10-04 8:39 ` (subset) " Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14a6e7b-3bfc-2dd9-378e-fb587e3e03e8@denx.de \
--to=marex@denx.de \
--cc=abelvesa@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).